[INFO] updating cached repository willsalz/inverted_index [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/willsalz/inverted_index [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/willsalz/inverted_index" "work/ex/clippy-test-run/sources/stable/gh/willsalz/inverted_index"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/willsalz/inverted_index'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/willsalz/inverted_index" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/willsalz/inverted_index"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/willsalz/inverted_index'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fb03bc52766dbfef6bd4ab5a856a639429a37c4a [INFO] sha for GitHub repo willsalz/inverted_index: fb03bc52766dbfef6bd4ab5a856a639429a37c4a [INFO] validating manifest of willsalz/inverted_index on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of willsalz/inverted_index on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing willsalz/inverted_index [INFO] finished frobbing willsalz/inverted_index [INFO] frobbed toml for willsalz/inverted_index written to work/ex/clippy-test-run/sources/stable/gh/willsalz/inverted_index/Cargo.toml [INFO] started frobbing willsalz/inverted_index [INFO] finished frobbing willsalz/inverted_index [INFO] frobbed toml for willsalz/inverted_index written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/willsalz/inverted_index/Cargo.toml [INFO] crate willsalz/inverted_index has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting willsalz/inverted_index against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/willsalz/inverted_index:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e47ffa862d308e80cdd211828a5ac0a4e8fc71a453189b4c88ec31e69d16b2f [INFO] running `"docker" "start" "-a" "4e47ffa862d308e80cdd211828a5ac0a4e8fc71a453189b4c88ec31e69d16b2f"` [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking inverted_index v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return InvertedIndex { [INFO] [stderr] 21 | | index: HashMap::new(), [INFO] [stderr] 22 | | docs: HashMap::new(), [INFO] [stderr] 23 | | num_docs: 0, [INFO] [stderr] 24 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | InvertedIndex { [INFO] [stderr] 21 | index: HashMap::new(), [INFO] [stderr] 22 | docs: HashMap::new(), [INFO] [stderr] 23 | num_docs: 0, [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn delete(&mut self, doc_id: DocId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return InvertedIndex { [INFO] [stderr] 21 | | index: HashMap::new(), [INFO] [stderr] 22 | | docs: HashMap::new(), [INFO] [stderr] 23 | | num_docs: 0, [INFO] [stderr] 24 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | InvertedIndex { [INFO] [stderr] 21 | index: HashMap::new(), [INFO] [stderr] 22 | docs: HashMap::new(), [INFO] [stderr] 23 | num_docs: 0, [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn delete(&mut self, doc_id: DocId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `InvertedIndex` [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> InvertedIndex { [INFO] [stderr] 20 | | return InvertedIndex { [INFO] [stderr] 21 | | index: HashMap::new(), [INFO] [stderr] 22 | | docs: HashMap::new(), [INFO] [stderr] 23 | | num_docs: 0, [INFO] [stderr] 24 | | }; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | for (_, mut posting_list) in &mut self.index { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 55 | for mut posting_list in self.index.values_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / match self.index.get(token) { [INFO] [stderr] 71 | | Some(ids) => { [INFO] [stderr] 72 | | for id in ids { [INFO] [stderr] 73 | | docs.insert(*id); [INFO] [stderr] ... | [INFO] [stderr] 76 | | _ => {} [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(ids) = self.index.get(token) { [INFO] [stderr] 71 | for id in ids { [INFO] [stderr] 72 | docs.insert(*id); [INFO] [stderr] 73 | } [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `InvertedIndex` [INFO] [stderr] --> src/lib.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn new() -> InvertedIndex { [INFO] [stderr] 20 | | return InvertedIndex { [INFO] [stderr] 21 | | index: HashMap::new(), [INFO] [stderr] 22 | | docs: HashMap::new(), [INFO] [stderr] 23 | | num_docs: 0, [INFO] [stderr] 24 | | }; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:55:38 [INFO] [stderr] | [INFO] [stderr] 55 | for (_, mut posting_list) in &mut self.index { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 55 | for mut posting_list in self.index.values_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | / match self.index.get(token) { [INFO] [stderr] 71 | | Some(ids) => { [INFO] [stderr] 72 | | for id in ids { [INFO] [stderr] 73 | | docs.insert(*id); [INFO] [stderr] ... | [INFO] [stderr] 76 | | _ => {} [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | if let Some(ids) = self.index.get(token) { [INFO] [stderr] 71 | for id in ids { [INFO] [stderr] 72 | docs.insert(*id); [INFO] [stderr] 73 | } [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.70s [INFO] running `"docker" "inspect" "4e47ffa862d308e80cdd211828a5ac0a4e8fc71a453189b4c88ec31e69d16b2f"` [INFO] running `"docker" "rm" "-f" "4e47ffa862d308e80cdd211828a5ac0a4e8fc71a453189b4c88ec31e69d16b2f"` [INFO] [stdout] 4e47ffa862d308e80cdd211828a5ac0a4e8fc71a453189b4c88ec31e69d16b2f