[INFO] updating cached repository william42/advent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/william42/advent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/william42/advent" "work/ex/clippy-test-run/sources/stable/gh/william42/advent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/william42/advent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/william42/advent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/william42/advent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/william42/advent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afd88192741ee5c2205ca0c2053592907134660c [INFO] sha for GitHub repo william42/advent: afd88192741ee5c2205ca0c2053592907134660c [INFO] validating manifest of william42/advent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of william42/advent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing william42/advent [INFO] finished frobbing william42/advent [INFO] frobbed toml for william42/advent written to work/ex/clippy-test-run/sources/stable/gh/william42/advent/Cargo.toml [INFO] started frobbing william42/advent [INFO] finished frobbing william42/advent [INFO] frobbed toml for william42/advent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/william42/advent/Cargo.toml [INFO] crate william42/advent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting william42/advent against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/william42/advent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd84c36003d78ad7cd48e8795fa7bd8cef03ba11fa937d00bffeeb7f0b1755d6 [INFO] running `"docker" "start" "-a" "cd84c36003d78ad7cd48e8795fa7bd8cef03ba11fa937d00bffeeb7f0b1755d6"` [INFO] [stderr] Checking advent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `process_frequency` [INFO] [stderr] --> src/main.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | fn process_frequency(line: String) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day1a` [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | fn day1a() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day1b` [INFO] [stderr] --> src/main.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | fn day1b() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day2a` [INFO] [stderr] --> src/main.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | fn day2a() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day2b` [INFO] [stderr] --> src/main.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn day2b() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `CRect` [INFO] [stderr] --> src/main.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | struct CRect { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day3line` [INFO] [stderr] --> src/main.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | fn day3line(line: String) -> CRect { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day3a` [INFO] [stderr] --> src/main.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | fn day3a() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day3b` [INFO] [stderr] --> src/main.rs:145:1 [INFO] [stderr] | [INFO] [stderr] 145 | fn day3b() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `polymer` [INFO] [stderr] --> src/main.rs:173:1 [INFO] [stderr] | [INFO] [stderr] 173 | / fn polymer(r: &mut I, prev: Option) -> Option [INFO] [stderr] 174 | | where [INFO] [stderr] 175 | | I: Iterator>, [INFO] [stderr] 176 | | { [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day5a` [INFO] [stderr] --> src/main.rs:195:1 [INFO] [stderr] | [INFO] [stderr] 195 | fn day5a() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `poly_without` [INFO] [stderr] --> src/main.rs:206:1 [INFO] [stderr] | [INFO] [stderr] 206 | fn poly_without(i: u8) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day5b` [INFO] [stderr] --> src/main.rs:223:1 [INFO] [stderr] | [INFO] [stderr] 223 | fn day5b() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day8a` [INFO] [stderr] --> src/main.rs:249:1 [INFO] [stderr] | [INFO] [stderr] 249 | fn day8a() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | if line.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | total = total + freq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += freq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | let mut it = rest.splitn(2, ","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:107:33 [INFO] [stderr] | [INFO] [stderr] 107 | let mut it = rest.splitn(2, "x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | if x >= &2 { [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:262:20 [INFO] [stderr] | [INFO] [stderr] 262 | if i <= 0 || i > children.len() { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using i == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: function is never used: `process_frequency` [INFO] [stderr] --> src/main.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | fn process_frequency(line: String) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day1a` [INFO] [stderr] --> src/main.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | fn day1a() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day1b` [INFO] [stderr] --> src/main.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | fn day1b() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day2a` [INFO] [stderr] --> src/main.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | fn day2a() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day2b` [INFO] [stderr] --> src/main.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | fn day2b() -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `CRect` [INFO] [stderr] --> src/main.rs:88:1 [INFO] [stderr] | [INFO] [stderr] 88 | struct CRect { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day3line` [INFO] [stderr] --> src/main.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | fn day3line(line: String) -> CRect { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day3a` [INFO] [stderr] --> src/main.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | fn day3a() -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day3b` [INFO] [stderr] --> src/main.rs:145:1 [INFO] [stderr] | [INFO] [stderr] 145 | fn day3b() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `polymer` [INFO] [stderr] --> src/main.rs:173:1 [INFO] [stderr] | [INFO] [stderr] 173 | / fn polymer(r: &mut I, prev: Option) -> Option [INFO] [stderr] 174 | | where [INFO] [stderr] 175 | | I: Iterator>, [INFO] [stderr] 176 | | { [INFO] [stderr] ... | [INFO] [stderr] 192 | | } [INFO] [stderr] 193 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day5a` [INFO] [stderr] --> src/main.rs:195:1 [INFO] [stderr] | [INFO] [stderr] 195 | fn day5a() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `poly_without` [INFO] [stderr] --> src/main.rs:206:1 [INFO] [stderr] | [INFO] [stderr] 206 | fn poly_without(i: u8) -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day5b` [INFO] [stderr] --> src/main.rs:223:1 [INFO] [stderr] | [INFO] [stderr] 223 | fn day5b() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `day8a` [INFO] [stderr] --> src/main.rs:249:1 [INFO] [stderr] | [INFO] [stderr] 249 | fn day8a() -> u32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | if line.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | total = total + freq; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += freq` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | let mut it = rest.splitn(2, ","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:107:33 [INFO] [stderr] | [INFO] [stderr] 107 | let mut it = rest.splitn(2, "x"); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | if x >= &2 { [INFO] [stderr] | ^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:262:20 [INFO] [stderr] | [INFO] [stderr] 262 | if i <= 0 || i > children.len() { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using i == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cd84c36003d78ad7cd48e8795fa7bd8cef03ba11fa937d00bffeeb7f0b1755d6"` [INFO] running `"docker" "rm" "-f" "cd84c36003d78ad7cd48e8795fa7bd8cef03ba11fa937d00bffeeb7f0b1755d6"` [INFO] [stdout] cd84c36003d78ad7cd48e8795fa7bd8cef03ba11fa937d00bffeeb7f0b1755d6