[INFO] updating cached repository willemv/advent_of_code_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/willemv/advent_of_code_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/willemv/advent_of_code_rust" "work/ex/clippy-test-run/sources/stable/gh/willemv/advent_of_code_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/willemv/advent_of_code_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/willemv/advent_of_code_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/willemv/advent_of_code_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/willemv/advent_of_code_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 76e62042b330b1201712782ba49ba31c97757292 [INFO] sha for GitHub repo willemv/advent_of_code_rust: 76e62042b330b1201712782ba49ba31c97757292 [INFO] validating manifest of willemv/advent_of_code_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of willemv/advent_of_code_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing willemv/advent_of_code_rust [INFO] finished frobbing willemv/advent_of_code_rust [INFO] frobbed toml for willemv/advent_of_code_rust written to work/ex/clippy-test-run/sources/stable/gh/willemv/advent_of_code_rust/Cargo.toml [INFO] started frobbing willemv/advent_of_code_rust [INFO] finished frobbing willemv/advent_of_code_rust [INFO] frobbed toml for willemv/advent_of_code_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/willemv/advent_of_code_rust/Cargo.toml [INFO] crate willemv/advent_of_code_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting willemv/advent_of_code_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/willemv/advent_of_code_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2947ccf965ef03c2833e95b71a8a618a886dd8447f6dba5dc7ccaa2891b76f4 [INFO] running `"docker" "start" "-a" "d2947ccf965ef03c2833e95b71a8a618a886dd8447f6dba5dc7ccaa2891b76f4"` [INFO] [stderr] Checking iterslide v1.0.0 [INFO] [stderr] Checking advent_of_code_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return combination; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `combination` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_two.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | return max - min; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max - min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_one.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return combination; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `combination` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day_two.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | return max - min; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max - min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_two.rs:15:46 [INFO] [stderr] | [INFO] [stderr] 15 | let items: Vec = line.split("\t").map(|item| item.parse::().unwrap()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day_two.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | let max = item_ref.into_iter().max().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day_two.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | let min = item_ref.into_iter().min().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day_two.rs:15:46 [INFO] [stderr] | [INFO] [stderr] 15 | let items: Vec = line.split("\t").map(|item| item.parse::().unwrap()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day_two.rs:17:32 [INFO] [stderr] | [INFO] [stderr] 17 | let max = item_ref.into_iter().max().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/day_two.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | let min = item_ref.into_iter().min().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "d2947ccf965ef03c2833e95b71a8a618a886dd8447f6dba5dc7ccaa2891b76f4"` [INFO] running `"docker" "rm" "-f" "d2947ccf965ef03c2833e95b71a8a618a886dd8447f6dba5dc7ccaa2891b76f4"` [INFO] [stdout] d2947ccf965ef03c2833e95b71a8a618a886dd8447f6dba5dc7ccaa2891b76f4