[INFO] updating cached repository whothey/firstfollow
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/whothey/firstfollow
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/whothey/firstfollow" "work/ex/clippy-test-run/sources/stable/gh/whothey/firstfollow"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/whothey/firstfollow'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/whothey/firstfollow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whothey/firstfollow"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whothey/firstfollow'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ed70ddfb2c949e42afc1b1b7e51e22ef854739a2
[INFO] sha for GitHub repo whothey/firstfollow: ed70ddfb2c949e42afc1b1b7e51e22ef854739a2
[INFO] validating manifest of whothey/firstfollow on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of whothey/firstfollow on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing whothey/firstfollow
[INFO] finished frobbing whothey/firstfollow
[INFO] frobbed toml for whothey/firstfollow written to work/ex/clippy-test-run/sources/stable/gh/whothey/firstfollow/Cargo.toml
[INFO] started frobbing whothey/firstfollow
[INFO] finished frobbing whothey/firstfollow
[INFO] frobbed toml for whothey/firstfollow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whothey/firstfollow/Cargo.toml
[INFO] crate whothey/firstfollow has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting whothey/firstfollow against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/whothey/firstfollow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f981d6b19a55ee30000ddffb23c70ad4ddfc554dcc30ffc96cf7182db371e225
[INFO] running `"docker" "start" "-a" "f981d6b19a55ee30000ddffb23c70ad4ddfc554dcc30ffc96cf7182db371e225"`
[INFO] [stderr]     Checking libc v0.2.26
[INFO] [stderr]     Checking thread_local v0.3.4
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr]     Checking env_logger v0.4.3
[INFO] [stderr]     Checking firstfollow v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/formalgrammar/mod.rs:275:17
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 write!(buf, " | <>\n").unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/formalgrammar/mod.rs:277:17
[INFO] [stderr]     |
[INFO] [stderr] 277 |                 write!(buf, "\n").unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/formalgrammar/mod.rs:296:17
[INFO] [stderr]     |
[INFO] [stderr] 296 |                 write!(buf, " | <>\n").unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/formalgrammar/mod.rs:298:17
[INFO] [stderr]     |
[INFO] [stderr] 298 |                 write!(buf, "\n").unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/formalgrammar/mod.rs:275:17
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 write!(buf, " | <>\n").unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/formalgrammar/mod.rs:277:17
[INFO] [stderr]     |
[INFO] [stderr] 277 |                 write!(buf, "\n").unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/formalgrammar/mod.rs:296:17
[INFO] [stderr]     |
[INFO] [stderr] 296 |                 write!(buf, " | <>\n").unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/formalgrammar/mod.rs:298:17
[INFO] [stderr]     |
[INFO] [stderr] 298 |                 write!(buf, "\n").unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `is_terminal`
[INFO] [stderr]   --> src/formalgrammar/symbol.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn is_terminal(&self) -> bool {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `is_nonterminal`
[INFO] [stderr]   --> src/formalgrammar/symbol.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn is_nonterminal(&self) -> bool {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/formalgrammar/symbol.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 | /         match self {
[INFO] [stderr] 28 | |             &Symbol::NonTerminal(ref s) => write!(f, "<{}>", s),
[INFO] [stderr] 29 | |             &Symbol::Terminal(ref s) => write!(f, "{}", s)
[INFO] [stderr] 30 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 27 |         match *self {
[INFO] [stderr] 28 |             Symbol::NonTerminal(ref s) => write!(f, "<{}>", s),
[INFO] [stderr] 29 |             Symbol::Terminal(ref s) => write!(f, "{}", s)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/formalgrammar/parser.rs:41:21
[INFO] [stderr]    |
[INFO] [stderr] 41 | /                     match ch {
[INFO] [stderr] 42 | |                         '<' => self.read_state = ParserState::StateName,
[INFO] [stderr] 43 | |                         _  => ()
[INFO] [stderr] 44 | |                     }
[INFO] [stderr]    | |_____________________^ help: try this: `if let '<' = ch { self.read_state = ParserState::StateName }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/formalgrammar/parser.rs:66:28
[INFO] [stderr]    |
[INFO] [stderr] 66 |                         if self.buffer.len() > 0 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buffer.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/formalgrammar/parser.rs:72:28
[INFO] [stderr]    |
[INFO] [stderr] 72 |                         if self.buffer.len() > 0 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buffer.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/formalgrammar/parser.rs:95:12
[INFO] [stderr]    |
[INFO] [stderr] 95 |         if self.buffer.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buffer.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/formalgrammar/parser.rs:110:12
[INFO] [stderr]     |
[INFO] [stderr] 110 |         if tname.len() == 0 { return; }
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tname.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/formalgrammar/parser.rs:125:22
[INFO] [stderr]     |
[INFO] [stderr] 125 |         let sym = if ntname.len() == 0 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ntname.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/formalgrammar/parser.rs:140:12
[INFO] [stderr]     |
[INFO] [stderr] 140 |         if rule.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rule.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/formalgrammar/mod.rs:52:42
[INFO] [stderr]    |
[INFO] [stderr] 52 |     pub fn add_rule_to(&mut self, state: &String, rule: Rule) -> Result<(), String> {
[INFO] [stderr]    |                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/formalgrammar/mod.rs:66:15
[INFO] [stderr]    |
[INFO] [stderr] 66 |         while first_updated == true {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `first_updated`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/formalgrammar/mod.rs:70:45
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 first.entry(key.to_owned()).or_insert(HashSet::new());
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:85:25
[INFO] [stderr]     |
[INFO] [stderr] 85  | /                         match symbol {
[INFO] [stderr] 86  | |                             &Symbol::NonTerminal(ref name) => {
[INFO] [stderr] 87  | |                                 // If state accept, then let the iteration continue, else, stops the
[INFO] [stderr] 88  | |                                 // iteration
[INFO] [stderr] ...   |
[INFO] [stderr] 100 | |                             _ => break
[INFO] [stderr] 101 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 85  |                         match *symbol {
[INFO] [stderr] 86  |                             Symbol::NonTerminal(ref name) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:106:25
[INFO] [stderr]     |
[INFO] [stderr] 106 | /                         match symbol {
[INFO] [stderr] 107 | |                             &Symbol::Terminal(ref content) => {
[INFO] [stderr] 108 | |                                 let mut set = first.get_mut(key).unwrap(); 
[INFO] [stderr] 109 | |                                 let     old = &set.clone();
[INFO] [stderr] ...   |
[INFO] [stderr] 132 | |                             _ => ()
[INFO] [stderr] 133 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 106 |                         match *symbol {
[INFO] [stderr] 107 |                             Symbol::Terminal(ref content) => {
[INFO] [stderr] 108 |                                 let mut set = first.get_mut(key).unwrap(); 
[INFO] [stderr] 109 |                                 let     old = &set.clone();
[INFO] [stderr] 110 | 
[INFO] [stderr] 111 |                                 set.insert(content.chars().nth(0).unwrap());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/formalgrammar/mod.rs:149:18
[INFO] [stderr]     |
[INFO] [stderr] 149 |                 .or_insert(HashSet::new())
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/formalgrammar/mod.rs:154:27
[INFO] [stderr]     |
[INFO] [stderr] 154 |         for (_, rules) in &self.map {
[INFO] [stderr]     |                           ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 154 |         for rules in self.map.values() {
[INFO] [stderr]     |             ^^^^^    ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:160:21
[INFO] [stderr]     |
[INFO] [stderr] 160 | /                     match symbol {
[INFO] [stderr] 161 | |                         &Symbol::NonTerminal(ref name) if grab_to.is_none() => {
[INFO] [stderr] 162 | |                             grab_to = Some(name.clone());
[INFO] [stderr] 163 | |                         },
[INFO] [stderr] ...   |
[INFO] [stderr] 186 | |                         _ => ()
[INFO] [stderr] 187 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 160 |                     match *symbol {
[INFO] [stderr] 161 |                         Symbol::NonTerminal(ref name) if grab_to.is_none() => {
[INFO] [stderr] 162 |                             grab_to = Some(name.clone());
[INFO] [stderr] 163 |                         },
[INFO] [stderr] 164 |                         Symbol::NonTerminal(ref name) if grab_to.is_some() => {
[INFO] [stderr] 165 |                             let target = grab_to.take().unwrap();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/formalgrammar/mod.rs:168:38
[INFO] [stderr]     |
[INFO] [stderr] 168 |                                     .or_insert(HashSet::new());
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/formalgrammar/mod.rs:182:34
[INFO] [stderr]     |
[INFO] [stderr] 182 |                                 .or_insert(HashSet::new());
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/formalgrammar/mod.rs:184:40
[INFO] [stderr]     |
[INFO] [stderr] 184 |                             set.insert(s.chars().nth(0).unwrap().clone());
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.chars().nth(0).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:202:25
[INFO] [stderr]     |
[INFO] [stderr] 202 | /                         if let &Symbol::NonTerminal(ref name) = symbol {
[INFO] [stderr] 203 | |                             if let Some(target) = grab_to.take() {
[INFO] [stderr] 204 | |                                 let set = follow_map[&target].clone();
[INFO] [stderr] 205 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 218 | |                             grab_to.take();
[INFO] [stderr] 219 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 202 |                         if let Symbol::NonTerminal(ref name) = *symbol {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:229:25
[INFO] [stderr]     |
[INFO] [stderr] 229 | /                         if let &Symbol::NonTerminal(ref name) = revs {
[INFO] [stderr] 230 | |                             let set = follow_map[name].clone();
[INFO] [stderr] 231 | |
[INFO] [stderr] 232 | |                             let union = {
[INFO] [stderr] ...   |
[INFO] [stderr] 243 | |                             break;
[INFO] [stderr] 244 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 229 |                         if let Symbol::NonTerminal(ref name) = *revs {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `is_terminal`
[INFO] [stderr]   --> src/formalgrammar/symbol.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn is_terminal(&self) -> bool {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `is_nonterminal`
[INFO] [stderr]   --> src/formalgrammar/symbol.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn is_nonterminal(&self) -> bool {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/formalgrammar/symbol.rs:27:9
[INFO] [stderr]    |
[INFO] [stderr] 27 | /         match self {
[INFO] [stderr] 28 | |             &Symbol::NonTerminal(ref s) => write!(f, "<{}>", s),
[INFO] [stderr] 29 | |             &Symbol::Terminal(ref s) => write!(f, "{}", s)
[INFO] [stderr] 30 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 27 |         match *self {
[INFO] [stderr] 28 |             Symbol::NonTerminal(ref s) => write!(f, "<{}>", s),
[INFO] [stderr] 29 |             Symbol::Terminal(ref s) => write!(f, "{}", s)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/formalgrammar/parser.rs:41:21
[INFO] [stderr]    |
[INFO] [stderr] 41 | /                     match ch {
[INFO] [stderr] 42 | |                         '<' => self.read_state = ParserState::StateName,
[INFO] [stderr] 43 | |                         _  => ()
[INFO] [stderr] 44 | |                     }
[INFO] [stderr]    | |_____________________^ help: try this: `if let '<' = ch { self.read_state = ParserState::StateName }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/formalgrammar/parser.rs:66:28
[INFO] [stderr]    |
[INFO] [stderr] 66 |                         if self.buffer.len() > 0 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buffer.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/formalgrammar/parser.rs:72:28
[INFO] [stderr]    |
[INFO] [stderr] 72 |                         if self.buffer.len() > 0 {
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buffer.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/formalgrammar/parser.rs:95:12
[INFO] [stderr]    |
[INFO] [stderr] 95 |         if self.buffer.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buffer.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/formalgrammar/parser.rs:110:12
[INFO] [stderr]     |
[INFO] [stderr] 110 |         if tname.len() == 0 { return; }
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tname.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/formalgrammar/parser.rs:125:22
[INFO] [stderr]     |
[INFO] [stderr] 125 |         let sym = if ntname.len() == 0 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ntname.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/formalgrammar/parser.rs:140:12
[INFO] [stderr]     |
[INFO] [stderr] 140 |         if rule.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!rule.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/formalgrammar/mod.rs:52:42
[INFO] [stderr]    |
[INFO] [stderr] 52 |     pub fn add_rule_to(&mut self, state: &String, rule: Rule) -> Result<(), String> {
[INFO] [stderr]    |                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/formalgrammar/mod.rs:66:15
[INFO] [stderr]    |
[INFO] [stderr] 66 |         while first_updated == true {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `first_updated`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/formalgrammar/mod.rs:70:45
[INFO] [stderr]    |
[INFO] [stderr] 70 |                 first.entry(key.to_owned()).or_insert(HashSet::new());
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:85:25
[INFO] [stderr]     |
[INFO] [stderr] 85  | /                         match symbol {
[INFO] [stderr] 86  | |                             &Symbol::NonTerminal(ref name) => {
[INFO] [stderr] 87  | |                                 // If state accept, then let the iteration continue, else, stops the
[INFO] [stderr] 88  | |                                 // iteration
[INFO] [stderr] ...   |
[INFO] [stderr] 100 | |                             _ => break
[INFO] [stderr] 101 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 85  |                         match *symbol {
[INFO] [stderr] 86  |                             Symbol::NonTerminal(ref name) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:106:25
[INFO] [stderr]     |
[INFO] [stderr] 106 | /                         match symbol {
[INFO] [stderr] 107 | |                             &Symbol::Terminal(ref content) => {
[INFO] [stderr] 108 | |                                 let mut set = first.get_mut(key).unwrap(); 
[INFO] [stderr] 109 | |                                 let     old = &set.clone();
[INFO] [stderr] ...   |
[INFO] [stderr] 132 | |                             _ => ()
[INFO] [stderr] 133 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 106 |                         match *symbol {
[INFO] [stderr] 107 |                             Symbol::Terminal(ref content) => {
[INFO] [stderr] 108 |                                 let mut set = first.get_mut(key).unwrap(); 
[INFO] [stderr] 109 |                                 let     old = &set.clone();
[INFO] [stderr] 110 | 
[INFO] [stderr] 111 |                                 set.insert(content.chars().nth(0).unwrap());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/formalgrammar/mod.rs:149:18
[INFO] [stderr]     |
[INFO] [stderr] 149 |                 .or_insert(HashSet::new())
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's values
[INFO] [stderr]    --> src/formalgrammar/mod.rs:154:27
[INFO] [stderr]     |
[INFO] [stderr] 154 |         for (_, rules) in &self.map {
[INFO] [stderr]     |                           ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 154 |         for rules in self.map.values() {
[INFO] [stderr]     |             ^^^^^    ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:160:21
[INFO] [stderr]     |
[INFO] [stderr] 160 | /                     match symbol {
[INFO] [stderr] 161 | |                         &Symbol::NonTerminal(ref name) if grab_to.is_none() => {
[INFO] [stderr] 162 | |                             grab_to = Some(name.clone());
[INFO] [stderr] 163 | |                         },
[INFO] [stderr] ...   |
[INFO] [stderr] 186 | |                         _ => ()
[INFO] [stderr] 187 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 160 |                     match *symbol {
[INFO] [stderr] 161 |                         Symbol::NonTerminal(ref name) if grab_to.is_none() => {
[INFO] [stderr] 162 |                             grab_to = Some(name.clone());
[INFO] [stderr] 163 |                         },
[INFO] [stderr] 164 |                         Symbol::NonTerminal(ref name) if grab_to.is_some() => {
[INFO] [stderr] 165 |                             let target = grab_to.take().unwrap();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/formalgrammar/mod.rs:168:38
[INFO] [stderr]     |
[INFO] [stderr] 168 |                                     .or_insert(HashSet::new());
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/formalgrammar/mod.rs:182:34
[INFO] [stderr]     |
[INFO] [stderr] 182 |                                 .or_insert(HashSet::new());
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/formalgrammar/mod.rs:184:40
[INFO] [stderr]     |
[INFO] [stderr] 184 |                             set.insert(s.chars().nth(0).unwrap().clone());
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.chars().nth(0).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:202:25
[INFO] [stderr]     |
[INFO] [stderr] 202 | /                         if let &Symbol::NonTerminal(ref name) = symbol {
[INFO] [stderr] 203 | |                             if let Some(target) = grab_to.take() {
[INFO] [stderr] 204 | |                                 let set = follow_map[&target].clone();
[INFO] [stderr] 205 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 218 | |                             grab_to.take();
[INFO] [stderr] 219 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 202 |                         if let Symbol::NonTerminal(ref name) = *symbol {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/formalgrammar/mod.rs:229:25
[INFO] [stderr]     |
[INFO] [stderr] 229 | /                         if let &Symbol::NonTerminal(ref name) = revs {
[INFO] [stderr] 230 | |                             let set = follow_map[name].clone();
[INFO] [stderr] 231 | |
[INFO] [stderr] 232 | |                             let union = {
[INFO] [stderr] ...   |
[INFO] [stderr] 243 | |                             break;
[INFO] [stderr] 244 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 229 |                         if let Symbol::NonTerminal(ref name) = *revs {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.00s
[INFO] running `"docker" "inspect" "f981d6b19a55ee30000ddffb23c70ad4ddfc554dcc30ffc96cf7182db371e225"`
[INFO] running `"docker" "rm" "-f" "f981d6b19a55ee30000ddffb23c70ad4ddfc554dcc30ffc96cf7182db371e225"`
[INFO] [stdout] f981d6b19a55ee30000ddffb23c70ad4ddfc554dcc30ffc96cf7182db371e225