[INFO] updating cached repository wgoldie/rust-levenshtein [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wgoldie/rust-levenshtein [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wgoldie/rust-levenshtein" "work/ex/clippy-test-run/sources/stable/gh/wgoldie/rust-levenshtein"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wgoldie/rust-levenshtein'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wgoldie/rust-levenshtein" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wgoldie/rust-levenshtein"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wgoldie/rust-levenshtein'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] be33ed650392320e9ff185f3f71e75f0e03e822f [INFO] sha for GitHub repo wgoldie/rust-levenshtein: be33ed650392320e9ff185f3f71e75f0e03e822f [INFO] validating manifest of wgoldie/rust-levenshtein on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wgoldie/rust-levenshtein on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wgoldie/rust-levenshtein [INFO] finished frobbing wgoldie/rust-levenshtein [INFO] frobbed toml for wgoldie/rust-levenshtein written to work/ex/clippy-test-run/sources/stable/gh/wgoldie/rust-levenshtein/Cargo.toml [INFO] started frobbing wgoldie/rust-levenshtein [INFO] finished frobbing wgoldie/rust-levenshtein [INFO] frobbed toml for wgoldie/rust-levenshtein written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wgoldie/rust-levenshtein/Cargo.toml [INFO] crate wgoldie/rust-levenshtein has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wgoldie/rust-levenshtein against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wgoldie/rust-levenshtein:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a38a70ca6c5ba89bf7f3624707d008c3cd5aca66891c5eda4469105d6c596ec [INFO] running `"docker" "start" "-a" "5a38a70ca6c5ba89bf7f3624707d008c3cd5aca66891c5eda4469105d6c596ec"` [INFO] [stderr] Checking levenshtein v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/deterministic.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | pattern_advance_preempting_state.unwrap_or( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 53 | | State::Pending(StepState { index: index + 1, errors }) [INFO] [stderr] 54 | | ), [INFO] [stderr] | |_____________^ help: try this: `unwrap_or_else(|| State::Pending(StepState { index: index + 1, errors }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/deterministic.rs:69:54 [INFO] [stderr] | [INFO] [stderr] 69 | pattern_advance_preempting_state.unwrap_or( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 70 | | State::Pending(StepState { index: index + 1, errors: errors + 1}) [INFO] [stderr] 71 | | ), [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| State::Pending(StepState { index: index + 1, errors: errors + 1}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/deterministic.rs:76:54 [INFO] [stderr] | [INFO] [stderr] 76 | pattern_advance_preempting_state.unwrap_or( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 77 | | State::Pending(StepState { index: index + 1, errors: errors + 1}) [INFO] [stderr] 78 | | ), [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| State::Pending(StepState { index: index + 1, errors: errors + 1}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/deterministic.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | transition_table.insert(input, new_state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/deterministic.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | self.transition_map.insert(state.clone(), transition_table); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/deterministic.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | pattern_advance_preempting_state.unwrap_or( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 53 | | State::Pending(StepState { index: index + 1, errors }) [INFO] [stderr] 54 | | ), [INFO] [stderr] | |_____________^ help: try this: `unwrap_or_else(|| State::Pending(StepState { index: index + 1, errors }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/deterministic.rs:69:54 [INFO] [stderr] | [INFO] [stderr] 69 | pattern_advance_preempting_state.unwrap_or( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 70 | | State::Pending(StepState { index: index + 1, errors: errors + 1}) [INFO] [stderr] 71 | | ), [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| State::Pending(StepState { index: index + 1, errors: errors + 1}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/deterministic.rs:76:54 [INFO] [stderr] | [INFO] [stderr] 76 | pattern_advance_preempting_state.unwrap_or( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 77 | | State::Pending(StepState { index: index + 1, errors: errors + 1}) [INFO] [stderr] 78 | | ), [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| State::Pending(StepState { index: index + 1, errors: errors + 1}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/deterministic.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | transition_table.insert(input, new_state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/deterministic.rs:93:36 [INFO] [stderr] | [INFO] [stderr] 93 | self.transition_map.insert(state.clone(), transition_table); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "5a38a70ca6c5ba89bf7f3624707d008c3cd5aca66891c5eda4469105d6c596ec"` [INFO] running `"docker" "rm" "-f" "5a38a70ca6c5ba89bf7f3624707d008c3cd5aca66891c5eda4469105d6c596ec"` [INFO] [stdout] 5a38a70ca6c5ba89bf7f3624707d008c3cd5aca66891c5eda4469105d6c596ec