[INFO] updating cached repository wemyss/rustikub [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wemyss/rustikub [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wemyss/rustikub" "work/ex/clippy-test-run/sources/stable/gh/wemyss/rustikub"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wemyss/rustikub'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wemyss/rustikub" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wemyss/rustikub"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wemyss/rustikub'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 546c7dc14a3f9bae7b1e021ccf4b3f33e450aaf0 [INFO] sha for GitHub repo wemyss/rustikub: 546c7dc14a3f9bae7b1e021ccf4b3f33e450aaf0 [INFO] validating manifest of wemyss/rustikub on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wemyss/rustikub on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wemyss/rustikub [INFO] finished frobbing wemyss/rustikub [INFO] frobbed toml for wemyss/rustikub written to work/ex/clippy-test-run/sources/stable/gh/wemyss/rustikub/Cargo.toml [INFO] started frobbing wemyss/rustikub [INFO] finished frobbing wemyss/rustikub [INFO] frobbed toml for wemyss/rustikub written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wemyss/rustikub/Cargo.toml [INFO] crate wemyss/rustikub has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wemyss/rustikub against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wemyss/rustikub:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30dabdf5c8030cf578f32fdb327eb8bc4356d44bc5feafe633d5be9c29fe363f [INFO] running `"docker" "start" "-a" "30dabdf5c8030cf578f32fdb327eb8bc4356d44bc5feafe633d5be9c29fe363f"` [INFO] [stderr] Checking rustikub v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/tile.rs:43:4 [INFO] [stderr] | [INFO] [stderr] 43 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/tile.rs:43:4 [INFO] [stderr] | [INFO] [stderr] 43 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/game/utils.rs:32:2 [INFO] [stderr] | [INFO] [stderr] 32 | (a..(b+1)) [INFO] [stderr] | ^^^^^^^^^^ help: use: `(a..=b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game/utils.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | match tile_set.is_empty() { [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | true => [INFO] [stderr] 40 | | match run_size { [INFO] [stderr] 41 | | 0 => vec![vec![]], [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 38 | if tile_set.is_empty() { match run_size { [INFO] [stderr] 39 | 0 => vec![vec![]], [INFO] [stderr] 40 | _ => vec![], [INFO] [stderr] 41 | } } else { [INFO] [stderr] 42 | match run_size { [INFO] [stderr] 43 | 0 => vec![vec![]], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game/utils.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | let head = head[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `head[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/game/utils.rs:69:11 [INFO] [stderr] | [INFO] [stderr] 69 | for i in 1..(range_length+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=range_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/game/utils.rs:32:2 [INFO] [stderr] | [INFO] [stderr] 32 | (a..(b+1)) [INFO] [stderr] | ^^^^^^^^^^ help: use: `(a..=b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/game/utils.rs:38:2 [INFO] [stderr] | [INFO] [stderr] 38 | match tile_set.is_empty() { [INFO] [stderr] | _____^ [INFO] [stderr] 39 | | true => [INFO] [stderr] 40 | | match run_size { [INFO] [stderr] 41 | | 0 => vec![vec![]], [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 38 | if tile_set.is_empty() { match run_size { [INFO] [stderr] 39 | 0 => vec![vec![]], [INFO] [stderr] 40 | _ => vec![], [INFO] [stderr] 41 | } } else { [INFO] [stderr] 42 | match run_size { [INFO] [stderr] 43 | 0 => vec![vec![]], [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game/utils.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | let head = head[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `head[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/game/utils.rs:69:11 [INFO] [stderr] | [INFO] [stderr] 69 | for i in 1..(range_length+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `1..=range_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "30dabdf5c8030cf578f32fdb327eb8bc4356d44bc5feafe633d5be9c29fe363f"` [INFO] running `"docker" "rm" "-f" "30dabdf5c8030cf578f32fdb327eb8bc4356d44bc5feafe633d5be9c29fe363f"` [INFO] [stdout] 30dabdf5c8030cf578f32fdb327eb8bc4356d44bc5feafe633d5be9c29fe363f