[INFO] updating cached repository wbjohnston/mips [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wbjohnston/mips [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wbjohnston/mips" "work/ex/clippy-test-run/sources/stable/gh/wbjohnston/mips"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wbjohnston/mips'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wbjohnston/mips" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wbjohnston/mips"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wbjohnston/mips'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bef51cc8bc9c92f12abdf6881460db3a4a181401 [INFO] sha for GitHub repo wbjohnston/mips: bef51cc8bc9c92f12abdf6881460db3a4a181401 [INFO] validating manifest of wbjohnston/mips on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wbjohnston/mips on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wbjohnston/mips [INFO] finished frobbing wbjohnston/mips [INFO] frobbed toml for wbjohnston/mips written to work/ex/clippy-test-run/sources/stable/gh/wbjohnston/mips/Cargo.toml [INFO] started frobbing wbjohnston/mips [INFO] finished frobbing wbjohnston/mips [INFO] frobbed toml for wbjohnston/mips written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wbjohnston/mips/Cargo.toml [INFO] crate wbjohnston/mips has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wbjohnston/mips against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wbjohnston/mips:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90048bee754260b109f7f9f4f68632396a73b64015486d462617c8dba4e10e8b [INFO] running `"docker" "start" "-a" "90048bee754260b109f7f9f4f68632396a73b64015486d462617c8dba4e10e8b"` [INFO] [stderr] Checking mips v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/isa/instruction.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | offset: 33554433 [INFO] [stderr] | ^^^^^^^^ help: consider: `33_554_433` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | fn function_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | fn shift_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | fn opcode_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | fn offset_bits(v: &u32) -> u32 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | fn immediate_bits(v: &u32) -> u16 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | fn src1_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | fn src2_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | fn destination_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:153:35 [INFO] [stderr] | [INFO] [stderr] 153 | operand + imm as u32 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:157:35 [INFO] [stderr] | [INFO] [stderr] 157 | operand & imm as u32 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:161:40 [INFO] [stderr] | [INFO] [stderr] 161 | self.pc += imm as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:165:71 [INFO] [stderr] | [INFO] [stderr] 165 | ori => self.registers.store_by_idx(dst, operand | imm as u32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:168:38 [INFO] [stderr] | [INFO] [stderr] 168 | if operand < imm as u32 { 1 } else { 0 } [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `components::register_file::RegisterFile` [INFO] [stderr] --> src/core/components/register_file.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn new() -> Self [INFO] [stderr] 153 | | { [INFO] [stderr] 154 | | Self { [INFO] [stderr] 155 | | zero: 0, [INFO] [stderr] ... | [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:6:21 [INFO] [stderr] | [INFO] [stderr] 6 | fn function_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | fn shift_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | fn opcode_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | fn offset_bits(v: &u32) -> u32 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | fn immediate_bits(v: &u32) -> u16 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | fn src1_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | fn src2_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/isa/instruction.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | fn destination_bits(v: &u32) -> u8 [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:153:35 [INFO] [stderr] | [INFO] [stderr] 153 | operand + imm as u32 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:157:35 [INFO] [stderr] | [INFO] [stderr] 157 | operand & imm as u32 [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:161:40 [INFO] [stderr] | [INFO] [stderr] 161 | self.pc += imm as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:165:71 [INFO] [stderr] | [INFO] [stderr] 165 | ori => self.registers.store_by_idx(dst, operand | imm as u32), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/core/components/core.rs:168:38 [INFO] [stderr] | [INFO] [stderr] 168 | if operand < imm as u32 { 1 } else { 0 } [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(imm)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `components::register_file::RegisterFile` [INFO] [stderr] --> src/core/components/register_file.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / pub fn new() -> Self [INFO] [stderr] 153 | | { [INFO] [stderr] 154 | | Self { [INFO] [stderr] 155 | | zero: 0, [INFO] [stderr] ... | [INFO] [stderr] 187 | | } [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.33s [INFO] running `"docker" "inspect" "90048bee754260b109f7f9f4f68632396a73b64015486d462617c8dba4e10e8b"` [INFO] running `"docker" "rm" "-f" "90048bee754260b109f7f9f4f68632396a73b64015486d462617c8dba4e10e8b"` [INFO] [stdout] 90048bee754260b109f7f9f4f68632396a73b64015486d462617c8dba4e10e8b