[INFO] updating cached repository waku-waku/rust-samples [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/waku-waku/rust-samples [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/waku-waku/rust-samples" "work/ex/clippy-test-run/sources/stable/gh/waku-waku/rust-samples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/waku-waku/rust-samples'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/waku-waku/rust-samples" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/waku-waku/rust-samples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/waku-waku/rust-samples'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce06c702b94b5f8274bfac66e57d84538f10c6f8 [INFO] sha for GitHub repo waku-waku/rust-samples: ce06c702b94b5f8274bfac66e57d84538f10c6f8 [INFO] validating manifest of waku-waku/rust-samples on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of waku-waku/rust-samples on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing waku-waku/rust-samples [INFO] finished frobbing waku-waku/rust-samples [INFO] frobbed toml for waku-waku/rust-samples written to work/ex/clippy-test-run/sources/stable/gh/waku-waku/rust-samples/Cargo.toml [INFO] started frobbing waku-waku/rust-samples [INFO] finished frobbing waku-waku/rust-samples [INFO] frobbed toml for waku-waku/rust-samples written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/waku-waku/rust-samples/Cargo.toml [INFO] crate waku-waku/rust-samples has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting waku-waku/rust-samples against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/waku-waku/rust-samples:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f1fcda1bf8dc85318856bc5b3758644fe8ca37203c922423b55a5fd1d0f5fffe [INFO] running `"docker" "start" "-a" "f1fcda1bf8dc85318856bc5b3758644fe8ca37203c922423b55a5fd1d0f5fffe"` [INFO] [stderr] Checking rust-samples v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/make_rust_file.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/make_rust_file.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return buf.split_whitespace().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.split_whitespace().collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/make_rust_file.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return s.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `src` is never read [INFO] [stderr] --> src/make_rust_file.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | let mut src = String::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `string` is never read [INFO] [stderr] --> src/make_rust_file.rs:79:10 [INFO] [stderr] | [INFO] [stderr] 79 | let mut string = String::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/make_rust_file.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match file.read_to_string(&mut s) { [INFO] [stderr] 27 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 28 | | Error::description(&why)), [INFO] [stderr] 29 | | Ok(_) => (), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 27 | Error::description(&why)) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/make_rust_file.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / match file.write_all(s.as_bytes()) { [INFO] [stderr] 47 | | Err(why) => { [INFO] [stderr] 48 | | panic!("couldn't write to {}: {}", display, [INFO] [stderr] 49 | | Error::description(&why)) [INFO] [stderr] 50 | | }, [INFO] [stderr] 51 | | Ok(_) => (), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | if let Err(why) = file.write_all(s.as_bytes()) { [INFO] [stderr] 47 | panic!("couldn't write to {}: {}", display, [INFO] [stderr] 48 | Error::description(&why)) [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/make_rust_file.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / match file.write_all("".as_bytes()) { [INFO] [stderr] 70 | | Err(why) => { [INFO] [stderr] 71 | | panic!("couldn't write to {}: {}", display, [INFO] [stderr] 72 | | Error::description(&why)) [INFO] [stderr] 73 | | }, [INFO] [stderr] 74 | | Ok(_) => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let Err(why) = file.write_all("".as_bytes()) { [INFO] [stderr] 70 | panic!("couldn't write to {}: {}", display, [INFO] [stderr] 71 | Error::description(&why)) [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/make_rust_file.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | match file.write_all("".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/make_rust_file.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/make_rust_file.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return buf.split_whitespace().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.split_whitespace().collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/make_rust_file.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return s.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `src` is never read [INFO] [stderr] --> src/make_rust_file.rs:56:10 [INFO] [stderr] | [INFO] [stderr] 56 | let mut src = String::new(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `string` is never read [INFO] [stderr] --> src/make_rust_file.rs:79:10 [INFO] [stderr] | [INFO] [stderr] 79 | let mut string = String::new(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/make_rust_file.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / match file.read_to_string(&mut s) { [INFO] [stderr] 27 | | Err(why) => panic!("couldn't read {}: {}", display, [INFO] [stderr] 28 | | Error::description(&why)), [INFO] [stderr] 29 | | Ok(_) => (), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | if let Err(why) = file.read_to_string(&mut s) { panic!("couldn't read {}: {}", display, [INFO] [stderr] 27 | Error::description(&why)) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/make_rust_file.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / match file.write_all(s.as_bytes()) { [INFO] [stderr] 47 | | Err(why) => { [INFO] [stderr] 48 | | panic!("couldn't write to {}: {}", display, [INFO] [stderr] 49 | | Error::description(&why)) [INFO] [stderr] 50 | | }, [INFO] [stderr] 51 | | Ok(_) => (), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | if let Err(why) = file.write_all(s.as_bytes()) { [INFO] [stderr] 47 | panic!("couldn't write to {}: {}", display, [INFO] [stderr] 48 | Error::description(&why)) [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/make_rust_file.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / match file.write_all("".as_bytes()) { [INFO] [stderr] 70 | | Err(why) => { [INFO] [stderr] 71 | | panic!("couldn't write to {}: {}", display, [INFO] [stderr] 72 | | Error::description(&why)) [INFO] [stderr] 73 | | }, [INFO] [stderr] 74 | | Ok(_) => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let Err(why) = file.write_all("".as_bytes()) { [INFO] [stderr] 70 | panic!("couldn't write to {}: {}", display, [INFO] [stderr] 71 | Error::description(&why)) [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/make_rust_file.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | match file.write_all("".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.33s [INFO] running `"docker" "inspect" "f1fcda1bf8dc85318856bc5b3758644fe8ca37203c922423b55a5fd1d0f5fffe"` [INFO] running `"docker" "rm" "-f" "f1fcda1bf8dc85318856bc5b3758644fe8ca37203c922423b55a5fd1d0f5fffe"` [INFO] [stdout] f1fcda1bf8dc85318856bc5b3758644fe8ca37203c922423b55a5fd1d0f5fffe