[INFO] updating cached repository vsv/rustulator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vsv/rustulator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vsv/rustulator" "work/ex/clippy-test-run/sources/stable/gh/vsv/rustulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vsv/rustulator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vsv/rustulator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vsv/rustulator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vsv/rustulator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 875a742f80ddc775b845e99c66f12a7ec7c7cc9d [INFO] sha for GitHub repo vsv/rustulator: 875a742f80ddc775b845e99c66f12a7ec7c7cc9d [INFO] validating manifest of vsv/rustulator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vsv/rustulator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vsv/rustulator [INFO] finished frobbing vsv/rustulator [INFO] frobbed toml for vsv/rustulator written to work/ex/clippy-test-run/sources/stable/gh/vsv/rustulator/Cargo.toml [INFO] started frobbing vsv/rustulator [INFO] finished frobbing vsv/rustulator [INFO] frobbed toml for vsv/rustulator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vsv/rustulator/Cargo.toml [INFO] crate vsv/rustulator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vsv/rustulator against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vsv/rustulator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ccfc9e4968615806b44d7802f6c4f6e5e571a0cc925022d4f902ec3013f93927 [INFO] running `"docker" "start" "-a" "ccfc9e4968615806b44d7802f6c4f6e5e571a0cc925022d4f902ec3013f93927"` [INFO] [stderr] Checking rustulator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | let parser = Parser { token_stream: token_stream, curr_token: None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:6:27 [INFO] [stderr] | [INFO] [stderr] 6 | let parser = Parser { token_stream: token_stream, curr_token: None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lexer.rs:166:39 [INFO] [stderr] | [INFO] [stderr] 166 | let expected = [Token::Number(849345.0)]; [INFO] [stderr] | ^^^^^^^^ help: consider: `849_345.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parser` [INFO] [stderr] --> src/parser.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let parser = Parser { token_stream: token_stream, curr_token: None }; [INFO] [stderr] | ^^^^^^ help: consider using `_parser` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Print` [INFO] [stderr] --> src/lexer.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Print, // ';' [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `token_stream` [INFO] [stderr] --> src/parser.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | token_stream: lexer::TokenStream<'lt>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `curr_token` [INFO] [stderr] --> src/parser.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | curr_token: Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lexer.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn scan<'lt>(input: &'lt str) -> TokenStream<'lt> { [INFO] [stderr] 20 | | TokenStream { input_iter: input.chars(), lookahead: None } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | let mut num = ch.to_digit(10).unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ch.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | num = num * num_multiplier; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num *= num_multiplier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | num = num + add_multiplier * (d.to_digit(10).unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num += add_multiplier * (d.to_digit(10).unwrap() as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:39:50 [INFO] [stderr] | [INFO] [stderr] 39 | num = num + add_multiplier * (d.to_digit(10).unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | add_multiplier = add_multiplier * add_multiplier_modifier; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `add_multiplier *= add_multiplier_modifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parser` [INFO] [stderr] --> src/parser.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let parser = Parser { token_stream: token_stream, curr_token: None }; [INFO] [stderr] | ^^^^^^ help: consider using `_parser` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Print` [INFO] [stderr] --> src/lexer.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Print, // ';' [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `token_stream` [INFO] [stderr] --> src/parser.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | token_stream: lexer::TokenStream<'lt>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `curr_token` [INFO] [stderr] --> src/parser.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | curr_token: Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lexer.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn scan<'lt>(input: &'lt str) -> TokenStream<'lt> { [INFO] [stderr] 20 | | TokenStream { input_iter: input.chars(), lookahead: None } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | let mut num = ch.to_digit(10).unwrap() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ch.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | num = num * num_multiplier; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num *= num_multiplier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:39:21 [INFO] [stderr] | [INFO] [stderr] 39 | num = num + add_multiplier * (d.to_digit(10).unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num += add_multiplier * (d.to_digit(10).unwrap() as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:39:50 [INFO] [stderr] | [INFO] [stderr] 39 | num = num + add_multiplier * (d.to_digit(10).unwrap() as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(d.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lexer.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | add_multiplier = add_multiplier * add_multiplier_modifier; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `add_multiplier *= add_multiplier_modifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "ccfc9e4968615806b44d7802f6c4f6e5e571a0cc925022d4f902ec3013f93927"` [INFO] running `"docker" "rm" "-f" "ccfc9e4968615806b44d7802f6c4f6e5e571a0cc925022d4f902ec3013f93927"` [INFO] [stdout] ccfc9e4968615806b44d7802f6c4f6e5e571a0cc925022d4f902ec3013f93927