[INFO] updating cached repository voelklmichael/varidor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/voelklmichael/varidor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/voelklmichael/varidor" "work/ex/clippy-test-run/sources/stable/gh/voelklmichael/varidor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/voelklmichael/varidor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/voelklmichael/varidor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/voelklmichael/varidor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/voelklmichael/varidor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ba8691397116cc03e96eb6721db8449ff1bfca68 [INFO] sha for GitHub repo voelklmichael/varidor: ba8691397116cc03e96eb6721db8449ff1bfca68 [INFO] validating manifest of voelklmichael/varidor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of voelklmichael/varidor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing voelklmichael/varidor [INFO] finished frobbing voelklmichael/varidor [INFO] frobbed toml for voelklmichael/varidor written to work/ex/clippy-test-run/sources/stable/gh/voelklmichael/varidor/Cargo.toml [INFO] started frobbing voelklmichael/varidor [INFO] finished frobbing voelklmichael/varidor [INFO] frobbed toml for voelklmichael/varidor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/voelklmichael/varidor/Cargo.toml [INFO] crate voelklmichael/varidor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting voelklmichael/varidor against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/voelklmichael/varidor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7fe85e7b703ccc1bea423595e9da341bdc0068081951be053a25d74fad75d8f0 [INFO] running `"docker" "start" "-a" "7fe85e7b703ccc1bea423595e9da341bdc0068081951be053a25d74fad75d8f0"` [INFO] [stderr] Checking num-traits v0.2.0 [INFO] [stderr] Checking varidor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/javascript_interaction/mod.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/javascript_interaction/mod.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/javascript_interaction/mod.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/javascript_interaction/mod.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/board_square/square_board.rs:351:16 [INFO] [stderr] | [INFO] [stderr] 351 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 352 | | if let Some((second_field, _)) = Self::get_field_in_direction(first_field, direction) { [INFO] [stderr] 353 | | let second_direction: DirectionsSquare = match (direction, wall_direction) { [INFO] [stderr] 354 | | (DirectionsSquare::Left, WallDirections::Left) => DirectionsSquare::Down, [INFO] [stderr] ... | [INFO] [stderr] 416 | | } [INFO] [stderr] 417 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | } else if let Some((second_field, _)) = Self::get_field_in_direction(first_field, direction) { [INFO] [stderr] 352 | let second_direction: DirectionsSquare = match (direction, wall_direction) { [INFO] [stderr] 353 | (DirectionsSquare::Left, WallDirections::Left) => DirectionsSquare::Down, [INFO] [stderr] 354 | (DirectionsSquare::Left, WallDirections::Right) => DirectionsSquare::Up, [INFO] [stderr] 355 | (DirectionsSquare::Right, WallDirections::Left) => DirectionsSquare::Up, [INFO] [stderr] 356 | (DirectionsSquare::Right, WallDirections::Right) => DirectionsSquare::Down, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/javascript_interaction/strings.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return ptr as *mut c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr as *mut c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/board_square/square_board.rs:351:16 [INFO] [stderr] | [INFO] [stderr] 351 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 352 | | if let Some((second_field, _)) = Self::get_field_in_direction(first_field, direction) { [INFO] [stderr] 353 | | let second_direction: DirectionsSquare = match (direction, wall_direction) { [INFO] [stderr] 354 | | (DirectionsSquare::Left, WallDirections::Left) => DirectionsSquare::Down, [INFO] [stderr] ... | [INFO] [stderr] 416 | | } [INFO] [stderr] 417 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | } else if let Some((second_field, _)) = Self::get_field_in_direction(first_field, direction) { [INFO] [stderr] 352 | let second_direction: DirectionsSquare = match (direction, wall_direction) { [INFO] [stderr] 353 | (DirectionsSquare::Left, WallDirections::Left) => DirectionsSquare::Down, [INFO] [stderr] 354 | (DirectionsSquare::Left, WallDirections::Right) => DirectionsSquare::Up, [INFO] [stderr] 355 | (DirectionsSquare::Right, WallDirections::Left) => DirectionsSquare::Up, [INFO] [stderr] 356 | (DirectionsSquare::Right, WallDirections::Right) => DirectionsSquare::Down, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/javascript_interaction/strings.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return ptr as *mut c_void; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr as *mut c_void` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/board_square/square_board.rs:351:16 [INFO] [stderr] | [INFO] [stderr] 351 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 352 | | if let Some((second_field, _)) = Self::get_field_in_direction(first_field, direction) { [INFO] [stderr] 353 | | let second_direction: DirectionsSquare = match (direction, wall_direction) { [INFO] [stderr] 354 | | (DirectionsSquare::Left, WallDirections::Left) => DirectionsSquare::Down, [INFO] [stderr] ... | [INFO] [stderr] 416 | | } [INFO] [stderr] 417 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | } else if let Some((second_field, _)) = Self::get_field_in_direction(first_field, direction) { [INFO] [stderr] 352 | let second_direction: DirectionsSquare = match (direction, wall_direction) { [INFO] [stderr] 353 | (DirectionsSquare::Left, WallDirections::Left) => DirectionsSquare::Down, [INFO] [stderr] 354 | (DirectionsSquare::Left, WallDirections::Right) => DirectionsSquare::Up, [INFO] [stderr] 355 | (DirectionsSquare::Right, WallDirections::Left) => DirectionsSquare::Up, [INFO] [stderr] 356 | (DirectionsSquare::Right, WallDirections::Right) => DirectionsSquare::Down, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/board_square/square_board.rs:351:16 [INFO] [stderr] | [INFO] [stderr] 351 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 352 | | if let Some((second_field, _)) = Self::get_field_in_direction(first_field, direction) { [INFO] [stderr] 353 | | let second_direction: DirectionsSquare = match (direction, wall_direction) { [INFO] [stderr] 354 | | (DirectionsSquare::Left, WallDirections::Left) => DirectionsSquare::Down, [INFO] [stderr] ... | [INFO] [stderr] 416 | | } [INFO] [stderr] 417 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | } else if let Some((second_field, _)) = Self::get_field_in_direction(first_field, direction) { [INFO] [stderr] 352 | let second_direction: DirectionsSquare = match (direction, wall_direction) { [INFO] [stderr] 353 | (DirectionsSquare::Left, WallDirections::Left) => DirectionsSquare::Down, [INFO] [stderr] 354 | (DirectionsSquare::Left, WallDirections::Right) => DirectionsSquare::Up, [INFO] [stderr] 355 | (DirectionsSquare::Right, WallDirections::Left) => DirectionsSquare::Up, [INFO] [stderr] 356 | (DirectionsSquare::Right, WallDirections::Right) => DirectionsSquare::Down, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `SquareBoard3` [INFO] [stderr] --> src/board_square/square_board3.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub type SquareBoard3 = [INFO] [stderr] 37 | | SquareBoard; [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `SquareBoard4` [INFO] [stderr] --> src/board_square/square_board4.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub type SquareBoard4 = [INFO] [stderr] 37 | | SquareBoard; [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board_square/player.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | [White, Black].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/board_square/type_level_integers.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZE: Type; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `Type` to be `Copy` [INFO] [stderr] --> src/board_square/type_level_integers.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZE: Type; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board_square/square_board.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | [Up, Down, Left, Right].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if match is_left_or_right { [INFO] [stderr] | ____________^ [INFO] [stderr] 125 | | true => self.wall_positions.at( [INFO] [stderr] 126 | | lower_left_field.column, [INFO] [stderr] 127 | | lower_left_field.row + One::one(), [INFO] [stderr] ... | [INFO] [stderr] 134 | | ), [INFO] [stderr] 135 | | } == IsWall [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 124 | if if is_left_or_right { self.wall_positions.at( [INFO] [stderr] 125 | lower_left_field.column, [INFO] [stderr] 126 | lower_left_field.row + One::one(), [INFO] [stderr] 127 | is_left_or_right, [INFO] [stderr] 128 | ) } else { self.wall_positions.at( [INFO] [stderr] 129 | lower_left_field.column + One::one(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match is_left_or_right { [INFO] [stderr] 152 | | true => { [INFO] [stderr] 153 | | *self.wall_positions.at_mut( [INFO] [stderr] 154 | | lower_left_field.column, [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 151 | if is_left_or_right { [INFO] [stderr] 152 | *self.wall_positions.at_mut( [INFO] [stderr] 153 | lower_left_field.column, [INFO] [stderr] 154 | lower_left_field.row + One::one(), [INFO] [stderr] 155 | is_left_or_right, [INFO] [stderr] 156 | ) = WallPlaced::IsWall [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match is_left_or_right { [INFO] [stderr] 182 | | true => { [INFO] [stderr] 183 | | *self.wall_positions.at_mut( [INFO] [stderr] 184 | | lower_left_field.column, [INFO] [stderr] ... | [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 181 | if is_left_or_right { [INFO] [stderr] 182 | *self.wall_positions.at_mut( [INFO] [stderr] 183 | lower_left_field.column, [INFO] [stderr] 184 | lower_left_field.row + One::one(), [INFO] [stderr] 185 | is_left_or_right, [INFO] [stderr] 186 | ) = WallPlaced::IsEmpty [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/board_square/mod.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / if Self::get_field_in_direction(field, direction).is_none() { [INFO] [stderr] 90 | | None [INFO] [stderr] 91 | | } else { [INFO] [stderr] 92 | | Some(self.check_for_wall_unsafe(field, direction)) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `Self::get_field_in_direction(field, direction)?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/board_square/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / Self::get_surrounding_fields(field) [INFO] [stderr] 100 | | .iter() [INFO] [stderr] 101 | | .filter(|&&(_, direction)| { [INFO] [stderr] 102 | | self.check_for_wall_unsafe(field, direction) == WallPlaced::IsEmpty [INFO] [stderr] 103 | | }) [INFO] [stderr] 104 | | .map(|x| *x) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 99 | Self::get_surrounding_fields(field) [INFO] [stderr] 100 | .iter() [INFO] [stderr] 101 | .filter(|&&(_, direction)| { [INFO] [stderr] 102 | self.check_for_wall_unsafe(field, direction) == WallPlaced::IsEmpty [INFO] [stderr] 103 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/board_square/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / new_visited_fields [INFO] [stderr] 176 | | .iter() [INFO] [stderr] 177 | | .map(|&x| visited_fields.push(x)) [INFO] [stderr] 178 | | .collect::>(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/board_square/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / new_visited_fields [INFO] [stderr] 176 | | .iter() [INFO] [stderr] 177 | | .map(|&x| visited_fields.push(x)) [INFO] [stderr] 178 | | .collect::>(); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/javascript_interaction/strings.rs:16:35 [INFO] [stderr] | [INFO] [stderr] 16 | let _ = CString::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/strings.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let mut n = n as u64; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/javascript_interaction/strings.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | result = result * n; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `result *= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/javascript_interaction/strings.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | n = n - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/javascript_interaction/mod.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | / data.move_player_by_field(FieldIndexSquare { [INFO] [stderr] 110 | | column: column, [INFO] [stderr] 111 | | row: row, [INFO] [stderr] 112 | | }).map(|error| data.append_logbook(error.to_string().to_string())); [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let Some(error) = data.move_player_by_field(FieldIndexSquare { [INFO] [stderr] 110 | column: column, [INFO] [stderr] 111 | row: row, [INFO] [stderr] 112 | }) { data.append_logbook(error.to_string().to_string()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/javascript_interaction/mod.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | let dir_is_left_or_right = if y - (y / DISTANCE).floor() * DISTANCE < FIELD_WIDTH { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 116 | | true [INFO] [stderr] 117 | | } else { [INFO] [stderr] 118 | | false [INFO] [stderr] 119 | | }; [INFO] [stderr] | |_____________^ help: you can reduce it to: `y - (y / DISTANCE).floor() * DISTANCE < FIELD_WIDTH` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | red as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | green as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | blue as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `BOARDSIZE as usize` [INFO] [stderr] --> src/javascript_interaction/mod.rs:207:29 [INFO] [stderr] | [INFO] [stderr] 207 | for row_index in 0..BOARDSIZE as usize - 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | wall_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:222:21 [INFO] [stderr] | [INFO] [stderr] 222 | wall_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | wall_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `BOARDSIZE as usize` [INFO] [stderr] --> src/javascript_interaction/mod.rs:229:28 [INFO] [stderr] | [INFO] [stderr] 229 | for column_index in 0..BOARDSIZE as usize - 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:244:21 [INFO] [stderr] | [INFO] [stderr] 244 | wall_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:245:21 [INFO] [stderr] | [INFO] [stderr] 245 | wall_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:246:21 [INFO] [stderr] | [INFO] [stderr] 246 | wall_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:264:21 [INFO] [stderr] | [INFO] [stderr] 264 | wall_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:265:21 [INFO] [stderr] | [INFO] [stderr] 265 | wall_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | wall_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | wall_selected_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:284:17 [INFO] [stderr] | [INFO] [stderr] 284 | wall_selected_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:285:17 [INFO] [stderr] | [INFO] [stderr] 285 | wall_selected_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | wall_selected_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | wall_selected_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:295:17 [INFO] [stderr] | [INFO] [stderr] 295 | wall_selected_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:312:21 [INFO] [stderr] | [INFO] [stderr] 312 | red as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:313:21 [INFO] [stderr] | [INFO] [stderr] 313 | green as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:314:21 [INFO] [stderr] | [INFO] [stderr] 314 | blue as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn to_string(self) -> &'static str { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn to_string(self) -> &'static str { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `varidor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: type alias is never used: `SquareBoard3` [INFO] [stderr] --> src/board_square/square_board3.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub type SquareBoard3 = [INFO] [stderr] 37 | | SquareBoard; [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `SquareBoard4` [INFO] [stderr] --> src/board_square/square_board4.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub type SquareBoard4 = [INFO] [stderr] 37 | | SquareBoard; [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board_square/player.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | [White, Black].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/board_square/type_level_integers.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZE: Type; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `Type` to be `Copy` [INFO] [stderr] --> src/board_square/type_level_integers.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZE: Type; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board_square/square_board.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | [Up, Down, Left, Right].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if match is_left_or_right { [INFO] [stderr] | ____________^ [INFO] [stderr] 125 | | true => self.wall_positions.at( [INFO] [stderr] 126 | | lower_left_field.column, [INFO] [stderr] 127 | | lower_left_field.row + One::one(), [INFO] [stderr] ... | [INFO] [stderr] 134 | | ), [INFO] [stderr] 135 | | } == IsWall [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 124 | if if is_left_or_right { self.wall_positions.at( [INFO] [stderr] 125 | lower_left_field.column, [INFO] [stderr] 126 | lower_left_field.row + One::one(), [INFO] [stderr] 127 | is_left_or_right, [INFO] [stderr] 128 | ) } else { self.wall_positions.at( [INFO] [stderr] 129 | lower_left_field.column + One::one(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match is_left_or_right { [INFO] [stderr] 152 | | true => { [INFO] [stderr] 153 | | *self.wall_positions.at_mut( [INFO] [stderr] 154 | | lower_left_field.column, [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 151 | if is_left_or_right { [INFO] [stderr] 152 | *self.wall_positions.at_mut( [INFO] [stderr] 153 | lower_left_field.column, [INFO] [stderr] 154 | lower_left_field.row + One::one(), [INFO] [stderr] 155 | is_left_or_right, [INFO] [stderr] 156 | ) = WallPlaced::IsWall [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match is_left_or_right { [INFO] [stderr] 182 | | true => { [INFO] [stderr] 183 | | *self.wall_positions.at_mut( [INFO] [stderr] 184 | | lower_left_field.column, [INFO] [stderr] ... | [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 181 | if is_left_or_right { [INFO] [stderr] 182 | *self.wall_positions.at_mut( [INFO] [stderr] 183 | lower_left_field.column, [INFO] [stderr] 184 | lower_left_field.row + One::one(), [INFO] [stderr] 185 | is_left_or_right, [INFO] [stderr] 186 | ) = WallPlaced::IsEmpty [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/board_square/mod.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / if Self::get_field_in_direction(field, direction).is_none() { [INFO] [stderr] 90 | | None [INFO] [stderr] 91 | | } else { [INFO] [stderr] 92 | | Some(self.check_for_wall_unsafe(field, direction)) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `Self::get_field_in_direction(field, direction)?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/board_square/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / Self::get_surrounding_fields(field) [INFO] [stderr] 100 | | .iter() [INFO] [stderr] 101 | | .filter(|&&(_, direction)| { [INFO] [stderr] 102 | | self.check_for_wall_unsafe(field, direction) == WallPlaced::IsEmpty [INFO] [stderr] 103 | | }) [INFO] [stderr] 104 | | .map(|x| *x) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 99 | Self::get_surrounding_fields(field) [INFO] [stderr] 100 | .iter() [INFO] [stderr] 101 | .filter(|&&(_, direction)| { [INFO] [stderr] 102 | self.check_for_wall_unsafe(field, direction) == WallPlaced::IsEmpty [INFO] [stderr] 103 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/board_square/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / new_visited_fields [INFO] [stderr] 176 | | .iter() [INFO] [stderr] 177 | | .map(|&x| visited_fields.push(x)) [INFO] [stderr] 178 | | .collect::>(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/board_square/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / new_visited_fields [INFO] [stderr] 176 | | .iter() [INFO] [stderr] 177 | | .map(|&x| visited_fields.push(x)) [INFO] [stderr] 178 | | .collect::>(); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/javascript_interaction/strings.rs:16:35 [INFO] [stderr] | [INFO] [stderr] 16 | let _ = CString::from_raw(ptr); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/strings.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | let mut n = n as u64; [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/javascript_interaction/strings.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | result = result * n; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `result *= n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/javascript_interaction/strings.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | n = n - 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `n -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Usize4` [INFO] [stderr] --> src/board_square/type_level_integers.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | pub type Usize4 = UsizeNext; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Usize5` [INFO] [stderr] --> src/board_square/type_level_integers.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | pub type Usize5 = UsizeNext; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wall_lookup_unsafe` [INFO] [stderr] --> src/board_square/square_board.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / pub fn wall_lookup_unsafe( [INFO] [stderr] 201 | | &self, [INFO] [stderr] 202 | | lower_left_field: FieldIndexSquare, [INFO] [stderr] 203 | | is_left_or_right: bool, [INFO] [stderr] ... | [INFO] [stderr] 209 | | ) [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `croosing_lookup_unsafe` [INFO] [stderr] --> src/board_square/square_board.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn croosing_lookup_unsafe(&self, lower_left_field: FieldIndexSquare) -> WallCrossing { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `SquareBoard5` [INFO] [stderr] --> src/board_square/square_board5.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub type SquareBoard5 = [INFO] [stderr] 37 | | SquareBoard; [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `SquareBoard4` [INFO] [stderr] --> src/board_square/square_board4.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub type SquareBoard4 = [INFO] [stderr] 37 | | SquareBoard; [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotConnected` [INFO] [stderr] --> src/board_square/mod.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | NotConnected, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FieldsNotAdjacent` [INFO] [stderr] --> src/board_square/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | FieldsNotAdjacent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board_square/player.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | [White, Black].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/board_square/type_level_integers.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZE: Type; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `Type` to be `Copy` [INFO] [stderr] --> src/board_square/type_level_integers.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZE: Type; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/javascript_interaction/mod.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | / data.move_player_by_field(FieldIndexSquare { [INFO] [stderr] 110 | | column: column, [INFO] [stderr] 111 | | row: row, [INFO] [stderr] 112 | | }).map(|error| data.append_logbook(error.to_string().to_string())); [INFO] [stderr] | |______________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | if let Some(error) = data.move_player_by_field(FieldIndexSquare { [INFO] [stderr] 110 | column: column, [INFO] [stderr] 111 | row: row, [INFO] [stderr] 112 | }) { data.append_logbook(error.to_string().to_string()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/javascript_interaction/mod.rs:115:40 [INFO] [stderr] | [INFO] [stderr] 115 | let dir_is_left_or_right = if y - (y / DISTANCE).floor() * DISTANCE < FIELD_WIDTH { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 116 | | true [INFO] [stderr] 117 | | } else { [INFO] [stderr] 118 | | false [INFO] [stderr] 119 | | }; [INFO] [stderr] | |_____________^ help: you can reduce it to: `y - (y / DISTANCE).floor() * DISTANCE < FIELD_WIDTH` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | red as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:199:17 [INFO] [stderr] | [INFO] [stderr] 199 | green as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | blue as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `BOARDSIZE as usize` [INFO] [stderr] --> src/javascript_interaction/mod.rs:207:29 [INFO] [stderr] | [INFO] [stderr] 207 | for row_index in 0..BOARDSIZE as usize - 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | wall_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:222:21 [INFO] [stderr] | [INFO] [stderr] 222 | wall_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | wall_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `BOARDSIZE as usize` [INFO] [stderr] --> src/javascript_interaction/mod.rs:229:28 [INFO] [stderr] | [INFO] [stderr] 229 | for column_index in 0..BOARDSIZE as usize - 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:244:21 [INFO] [stderr] | [INFO] [stderr] 244 | wall_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:245:21 [INFO] [stderr] | [INFO] [stderr] 245 | wall_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:246:21 [INFO] [stderr] | [INFO] [stderr] 246 | wall_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:264:21 [INFO] [stderr] | [INFO] [stderr] 264 | wall_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.0)` [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board_square/square_board.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | [Up, Down, Left, Right].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if match is_left_or_right { [INFO] [stderr] | ____________^ [INFO] [stderr] 125 | | true => self.wall_positions.at( [INFO] [stderr] 126 | | lower_left_field.column, [INFO] [stderr] 127 | | lower_left_field.row + One::one(), [INFO] [stderr] ... | [INFO] [stderr] 134 | | ), [INFO] [stderr] 135 | | } == IsWall [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 124 | if if is_left_or_right { self.wall_positions.at( [INFO] [stderr] 125 | lower_left_field.column, [INFO] [stderr] 126 | lower_left_field.row + One::one(), [INFO] [stderr] 127 | is_left_or_right, [INFO] [stderr] 128 | ) } else { self.wall_positions.at( [INFO] [stderr] 129 | lower_left_field.column + One::one(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:265:21 [INFO] [stderr] | [INFO] [stderr] 265 | wall_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | wall_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:283:17 [INFO] [stderr] | [INFO] [stderr] 283 | wall_selected_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:284:17 [INFO] [stderr] | [INFO] [stderr] 284 | wall_selected_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:285:17 [INFO] [stderr] | [INFO] [stderr] 285 | wall_selected_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | wall_selected_color.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:294:17 [INFO] [stderr] | [INFO] [stderr] 294 | wall_selected_color.1 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:295:17 [INFO] [stderr] | [INFO] [stderr] 295 | wall_selected_color.2 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(wall_selected_color.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:312:21 [INFO] [stderr] | [INFO] [stderr] 312 | red as f64, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:313:21 [INFO] [stderr] | [INFO] [stderr] 313 | green as f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/javascript_interaction/mod.rs:314:21 [INFO] [stderr] | [INFO] [stderr] 314 | blue as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn to_string(self) -> &'static str { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn to_string(self) -> &'static str { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match is_left_or_right { [INFO] [stderr] 152 | | true => { [INFO] [stderr] 153 | | *self.wall_positions.at_mut( [INFO] [stderr] 154 | | lower_left_field.column, [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 151 | if is_left_or_right { [INFO] [stderr] 152 | *self.wall_positions.at_mut( [INFO] [stderr] 153 | lower_left_field.column, [INFO] [stderr] 154 | lower_left_field.row + One::one(), [INFO] [stderr] 155 | is_left_or_right, [INFO] [stderr] 156 | ) = WallPlaced::IsWall [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match is_left_or_right { [INFO] [stderr] 182 | | true => { [INFO] [stderr] 183 | | *self.wall_positions.at_mut( [INFO] [stderr] 184 | | lower_left_field.column, [INFO] [stderr] ... | [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 181 | if is_left_or_right { [INFO] [stderr] 182 | *self.wall_positions.at_mut( [INFO] [stderr] 183 | lower_left_field.column, [INFO] [stderr] 184 | lower_left_field.row + One::one(), [INFO] [stderr] 185 | is_left_or_right, [INFO] [stderr] 186 | ) = WallPlaced::IsEmpty [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `varidor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/board_square/mod.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / if Self::get_field_in_direction(field, direction).is_none() { [INFO] [stderr] 90 | | None [INFO] [stderr] 91 | | } else { [INFO] [stderr] 92 | | Some(self.check_for_wall_unsafe(field, direction)) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `Self::get_field_in_direction(field, direction)?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/board_square/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / Self::get_surrounding_fields(field) [INFO] [stderr] 100 | | .iter() [INFO] [stderr] 101 | | .filter(|&&(_, direction)| { [INFO] [stderr] 102 | | self.check_for_wall_unsafe(field, direction) == WallPlaced::IsEmpty [INFO] [stderr] 103 | | }) [INFO] [stderr] 104 | | .map(|x| *x) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 99 | Self::get_surrounding_fields(field) [INFO] [stderr] 100 | .iter() [INFO] [stderr] 101 | .filter(|&&(_, direction)| { [INFO] [stderr] 102 | self.check_for_wall_unsafe(field, direction) == WallPlaced::IsEmpty [INFO] [stderr] 103 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/board_square/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / new_visited_fields [INFO] [stderr] 176 | | .iter() [INFO] [stderr] 177 | | .map(|&x| visited_fields.push(x)) [INFO] [stderr] 178 | | .collect::>(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/board_square/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / new_visited_fields [INFO] [stderr] 176 | | .iter() [INFO] [stderr] 177 | | .map(|&x| visited_fields.push(x)) [INFO] [stderr] 178 | | .collect::>(); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `varidor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: type alias is never used: `Usize4` [INFO] [stderr] --> src/board_square/type_level_integers.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | pub type Usize4 = UsizeNext; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `Usize5` [INFO] [stderr] --> src/board_square/type_level_integers.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | pub type Usize5 = UsizeNext; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `wall_lookup_unsafe` [INFO] [stderr] --> src/board_square/square_board.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | / pub fn wall_lookup_unsafe( [INFO] [stderr] 201 | | &self, [INFO] [stderr] 202 | | lower_left_field: FieldIndexSquare, [INFO] [stderr] 203 | | is_left_or_right: bool, [INFO] [stderr] ... | [INFO] [stderr] 209 | | ) [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `croosing_lookup_unsafe` [INFO] [stderr] --> src/board_square/square_board.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn croosing_lookup_unsafe(&self, lower_left_field: FieldIndexSquare) -> WallCrossing { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `SquareBoard5` [INFO] [stderr] --> src/board_square/square_board5.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub type SquareBoard5 = [INFO] [stderr] 37 | | SquareBoard; [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `SquareBoard4` [INFO] [stderr] --> src/board_square/square_board4.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / pub type SquareBoard4 = [INFO] [stderr] 37 | | SquareBoard; [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NotConnected` [INFO] [stderr] --> src/board_square/mod.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | NotConnected, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FieldsNotAdjacent` [INFO] [stderr] --> src/board_square/mod.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | FieldsNotAdjacent, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board_square/player.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | [White, Black].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: a const item should never be interior mutable [INFO] [stderr] --> src/board_square/type_level_integers.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZE: Type; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::declare_interior_mutable_const)] on by default [INFO] [stderr] help: consider requiring `Type` to be `Copy` [INFO] [stderr] --> src/board_square/type_level_integers.rs:3:17 [INFO] [stderr] | [INFO] [stderr] 3 | const SIZE: Type; [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/board_square/square_board.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | [Up, Down, Left, Right].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if match is_left_or_right { [INFO] [stderr] | ____________^ [INFO] [stderr] 125 | | true => self.wall_positions.at( [INFO] [stderr] 126 | | lower_left_field.column, [INFO] [stderr] 127 | | lower_left_field.row + One::one(), [INFO] [stderr] ... | [INFO] [stderr] 134 | | ), [INFO] [stderr] 135 | | } == IsWall [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 124 | if if is_left_or_right { self.wall_positions.at( [INFO] [stderr] 125 | lower_left_field.column, [INFO] [stderr] 126 | lower_left_field.row + One::one(), [INFO] [stderr] 127 | is_left_or_right, [INFO] [stderr] 128 | ) } else { self.wall_positions.at( [INFO] [stderr] 129 | lower_left_field.column + One::one(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | / match is_left_or_right { [INFO] [stderr] 152 | | true => { [INFO] [stderr] 153 | | *self.wall_positions.at_mut( [INFO] [stderr] 154 | | lower_left_field.column, [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 151 | if is_left_or_right { [INFO] [stderr] 152 | *self.wall_positions.at_mut( [INFO] [stderr] 153 | lower_left_field.column, [INFO] [stderr] 154 | lower_left_field.row + One::one(), [INFO] [stderr] 155 | is_left_or_right, [INFO] [stderr] 156 | ) = WallPlaced::IsWall [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/board_square/square_board.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match is_left_or_right { [INFO] [stderr] 182 | | true => { [INFO] [stderr] 183 | | *self.wall_positions.at_mut( [INFO] [stderr] 184 | | lower_left_field.column, [INFO] [stderr] ... | [INFO] [stderr] 195 | | } [INFO] [stderr] 196 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 181 | if is_left_or_right { [INFO] [stderr] 182 | *self.wall_positions.at_mut( [INFO] [stderr] 183 | lower_left_field.column, [INFO] [stderr] 184 | lower_left_field.row + One::one(), [INFO] [stderr] 185 | is_left_or_right, [INFO] [stderr] 186 | ) = WallPlaced::IsEmpty [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/board_square/mod.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / if Self::get_field_in_direction(field, direction).is_none() { [INFO] [stderr] 90 | | None [INFO] [stderr] 91 | | } else { [INFO] [stderr] 92 | | Some(self.check_for_wall_unsafe(field, direction)) [INFO] [stderr] 93 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `Self::get_field_in_direction(field, direction)?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/board_square/mod.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / Self::get_surrounding_fields(field) [INFO] [stderr] 100 | | .iter() [INFO] [stderr] 101 | | .filter(|&&(_, direction)| { [INFO] [stderr] 102 | | self.check_for_wall_unsafe(field, direction) == WallPlaced::IsEmpty [INFO] [stderr] 103 | | }) [INFO] [stderr] 104 | | .map(|x| *x) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 99 | Self::get_surrounding_fields(field) [INFO] [stderr] 100 | .iter() [INFO] [stderr] 101 | .filter(|&&(_, direction)| { [INFO] [stderr] 102 | self.check_for_wall_unsafe(field, direction) == WallPlaced::IsEmpty [INFO] [stderr] 103 | }).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/board_square/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / new_visited_fields [INFO] [stderr] 176 | | .iter() [INFO] [stderr] 177 | | .map(|&x| visited_fields.push(x)) [INFO] [stderr] 178 | | .collect::>(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/board_square/mod.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / new_visited_fields [INFO] [stderr] 176 | | .iter() [INFO] [stderr] 177 | | .map(|&x| visited_fields.push(x)) [INFO] [stderr] 178 | | .collect::>(); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `varidor`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7fe85e7b703ccc1bea423595e9da341bdc0068081951be053a25d74fad75d8f0"` [INFO] running `"docker" "rm" "-f" "7fe85e7b703ccc1bea423595e9da341bdc0068081951be053a25d74fad75d8f0"` [INFO] [stdout] 7fe85e7b703ccc1bea423595e9da341bdc0068081951be053a25d74fad75d8f0