[INFO] updating cached repository vlttnv/rusty-shell
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/vlttnv/rusty-shell
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/vlttnv/rusty-shell" "work/ex/clippy-test-run/sources/stable/gh/vlttnv/rusty-shell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vlttnv/rusty-shell'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/vlttnv/rusty-shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vlttnv/rusty-shell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vlttnv/rusty-shell'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 32312888362183d17b23a778368864b9c7c54dae
[INFO] sha for GitHub repo vlttnv/rusty-shell: 32312888362183d17b23a778368864b9c7c54dae
[INFO] validating manifest of vlttnv/rusty-shell on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vlttnv/rusty-shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vlttnv/rusty-shell
[INFO] finished frobbing vlttnv/rusty-shell
[INFO] frobbed toml for vlttnv/rusty-shell written to work/ex/clippy-test-run/sources/stable/gh/vlttnv/rusty-shell/Cargo.toml
[INFO] started frobbing vlttnv/rusty-shell
[INFO] finished frobbing vlttnv/rusty-shell
[INFO] frobbed toml for vlttnv/rusty-shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vlttnv/rusty-shell/Cargo.toml
[INFO] crate vlttnv/rusty-shell has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vlttnv/rusty-shell against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vlttnv/rusty-shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 14dab16a68735c6173a9c69f5113db2be85be51612a2bb2337188726c4891c45
[INFO] running `"docker" "start" "-a" "14dab16a68735c6173a9c69f5113db2be85be51612a2bb2337188726c4891c45"`
[INFO] [stderr]     Checking rusty_shell v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:7:27
[INFO] [stderr]   |
[INFO] [stderr] 7 | const BUILT_IN_COMMANDS: &'static [&'static str] = &["cd", "exit"];
[INFO] [stderr]   |                          -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:7:37
[INFO] [stderr]   |
[INFO] [stderr] 7 | const BUILT_IN_COMMANDS: &'static [&'static str] = &["cd", "exit"];
[INFO] [stderr]   |                                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:7:27
[INFO] [stderr]   |
[INFO] [stderr] 7 | const BUILT_IN_COMMANDS: &'static [&'static str] = &["cd", "exit"];
[INFO] [stderr]   |                          -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:7:37
[INFO] [stderr]   |
[INFO] [stderr] 7 | const BUILT_IN_COMMANDS: &'static [&'static str] = &["cd", "exit"];
[INFO] [stderr]   |                                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: variable `exit_code` is assigned to, but never used
[INFO] [stderr]   --> src/main.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let mut exit_code;
[INFO] [stderr]    |             ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_exit_code` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `exit_code` is never read
[INFO] [stderr]   --> src/main.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         exit_code = rsh_run(&args)
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     stdout().flush().ok().expect("Could not flush stdout");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:56:21
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn rsh_cd(args: &Vec<&str>) -> i32 {
[INFO] [stderr]    |                     ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:80:22
[INFO] [stderr]    |
[INFO] [stderr] 80 | pub fn rsh_run(args: &Vec<&str>) -> i32 {
[INFO] [stderr]    |                      ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:81:8
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if args.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: variable `exit_code` is assigned to, but never used
[INFO] [stderr]   --> src/main.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let mut exit_code;
[INFO] [stderr]    |             ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr]    = note: consider using `_exit_code` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `exit_code` is never read
[INFO] [stderr]   --> src/main.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         exit_code = rsh_run(&args)
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     stdout().flush().ok().expect("Could not flush stdout");
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:56:21
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn rsh_cd(args: &Vec<&str>) -> i32 {
[INFO] [stderr]    |                     ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:80:22
[INFO] [stderr]    |
[INFO] [stderr] 80 | pub fn rsh_run(args: &Vec<&str>) -> i32 {
[INFO] [stderr]    |                      ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:81:8
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if args.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.58s
[INFO] running `"docker" "inspect" "14dab16a68735c6173a9c69f5113db2be85be51612a2bb2337188726c4891c45"`
[INFO] running `"docker" "rm" "-f" "14dab16a68735c6173a9c69f5113db2be85be51612a2bb2337188726c4891c45"`
[INFO] [stdout] 14dab16a68735c6173a9c69f5113db2be85be51612a2bb2337188726c4891c45