[INFO] updating cached repository vitiral/dir-obj-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vitiral/dir-obj-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vitiral/dir-obj-rs" "work/ex/clippy-test-run/sources/stable/gh/vitiral/dir-obj-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vitiral/dir-obj-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vitiral/dir-obj-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitiral/dir-obj-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitiral/dir-obj-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] baf2e91a9e5ba91c5a88020deaaa64145d982d01 [INFO] sha for GitHub repo vitiral/dir-obj-rs: baf2e91a9e5ba91c5a88020deaaa64145d982d01 [INFO] validating manifest of vitiral/dir-obj-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vitiral/dir-obj-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vitiral/dir-obj-rs [INFO] finished frobbing vitiral/dir-obj-rs [INFO] frobbed toml for vitiral/dir-obj-rs written to work/ex/clippy-test-run/sources/stable/gh/vitiral/dir-obj-rs/Cargo.toml [INFO] started frobbing vitiral/dir-obj-rs [INFO] finished frobbing vitiral/dir-obj-rs [INFO] frobbed toml for vitiral/dir-obj-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitiral/dir-obj-rs/Cargo.toml [INFO] crate vitiral/dir-obj-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vitiral/dir-obj-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitiral/dir-obj-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cbccf379376d7c72eea12f2f36059be03305c059c97df5e747edd016696b5208 [INFO] running `"docker" "start" "-a" "cbccf379376d7c72eea12f2f36059be03305c059c97df5e747edd016696b5208"` [INFO] [stderr] Checking dir-obj v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Dir` [INFO] [stderr] --> src/lib.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn new() -> Dir { [INFO] [stderr] 88 | | Dir { [INFO] [stderr] 89 | | items: HashMap::new(), [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:155:37 [INFO] [stderr] | [INFO] [stderr] 155 | last_c.parse::().expect(&format!("last_c: {}, invalid name: {}", [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 156 | | last_c, name)); [INFO] [stderr] | |__________________________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("last_c: {}, invalid name: {}", last_c))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | / if let &Entry::Dir(ref d) = entry { [INFO] [stderr] 185 | | count += count_entries(d); [INFO] [stderr] 186 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 184 | if let Entry::Dir(ref d) = *entry { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Dir` [INFO] [stderr] --> src/lib.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | / pub fn new() -> Dir { [INFO] [stderr] 88 | | Dir { [INFO] [stderr] 89 | | items: HashMap::new(), [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "cbccf379376d7c72eea12f2f36059be03305c059c97df5e747edd016696b5208"` [INFO] running `"docker" "rm" "-f" "cbccf379376d7c72eea12f2f36059be03305c059c97df5e747edd016696b5208"` [INFO] [stdout] cbccf379376d7c72eea12f2f36059be03305c059c97df5e747edd016696b5208