[INFO] updating cached repository vishusandy/randproj
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/vishusandy/randproj
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/vishusandy/randproj" "work/ex/clippy-test-run/sources/stable/gh/vishusandy/randproj"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vishusandy/randproj'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/vishusandy/randproj" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/randproj"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/randproj'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e878582408f88ad5d99d2e831545482db30993d9
[INFO] sha for GitHub repo vishusandy/randproj: e878582408f88ad5d99d2e831545482db30993d9
[INFO] validating manifest of vishusandy/randproj on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vishusandy/randproj on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vishusandy/randproj
[INFO] finished frobbing vishusandy/randproj
[INFO] frobbed toml for vishusandy/randproj written to work/ex/clippy-test-run/sources/stable/gh/vishusandy/randproj/Cargo.toml
[INFO] started frobbing vishusandy/randproj
[INFO] finished frobbing vishusandy/randproj
[INFO] frobbed toml for vishusandy/randproj written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/randproj/Cargo.toml
[INFO] crate vishusandy/randproj has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vishusandy/randproj against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/randproj:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 40134eb4ac758927000ac6a4f99c2ffb26acdc9053407e53e49d3c101583d820
[INFO] running `"docker" "start" "-a" "40134eb4ac758927000ac6a4f99c2ffb26acdc9053407e53e49d3c101583d820"`
[INFO] [stderr]     Checking argparse v0.2.1
[INFO] [stderr]     Checking rand v0.3.15
[INFO] [stderr]     Checking randproj v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/genproj.rs:41:10
[INFO] [stderr]    |
[INFO] [stderr] 41 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 42 | |             if pcat == "" { //show all projects in all categories
[INFO] [stderr] 43 | |                 println!("Showing all projects in all categories");
[INFO] [stderr] 44 | |                 for c in 0..13 {
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             }
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 41 |         } else if pcat == "" { //show all projects in all categories
[INFO] [stderr] 42 |     println!("Showing all projects in all categories");
[INFO] [stderr] 43 |     for c in 0..13 {
[INFO] [stderr] 44 |         println!("Category: {}", cats[c]);
[INFO] [stderr] 45 |         for p in 0..projs[c].len() {
[INFO] [stderr] 46 |             println!("\t{}: {}", cats[c], projs[c][p]);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/genproj.rs:41:10
[INFO] [stderr]    |
[INFO] [stderr] 41 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 42 | |             if pcat == "" { //show all projects in all categories
[INFO] [stderr] 43 | |                 println!("Showing all projects in all categories");
[INFO] [stderr] 44 | |                 for c in 0..13 {
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             }
[INFO] [stderr] 60 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 41 |         } else if pcat == "" { //show all projects in all categories
[INFO] [stderr] 42 |     println!("Showing all projects in all categories");
[INFO] [stderr] 43 |     for c in 0..13 {
[INFO] [stderr] 44 |         println!("Category: {}", cats[c]);
[INFO] [stderr] 45 |         for p in 0..projs[c].len() {
[INFO] [stderr] 46 |             println!("\t{}: {}", cats[c], projs[c][p]);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `cats`.
[INFO] [stderr]   --> src/genproj.rs:24:12
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for i in 0..13 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for <item> in &cats {
[INFO] [stderr]    |             ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/genproj.rs:51:52
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 let idx = cats.iter().position(|&r| r == pcat).unwrap_or(rg.gen_range(0, 12));
[INFO] [stderr]    |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| rg.gen_range(0, 12))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `cats`
[INFO] [stderr]   --> src/genproj.rs:56:14
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 for i in 0..projs[idx].len() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 for (i, <item>) in cats.iter().enumerate().take(projs[idx].len()) {
[INFO] [stderr]    |                     ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/genproj.rs:80:53
[INFO] [stderr]    |
[INFO] [stderr] 80 |             let gcati = cats.iter().position(|&r| r == pcat).unwrap_or(rg.gen_range(0, 12));
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| rg.gen_range(0, 12))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `cats`.
[INFO] [stderr]   --> src/genproj.rs:24:12
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for i in 0..13 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for <item> in &cats {
[INFO] [stderr]    |             ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/genproj.rs:51:52
[INFO] [stderr]    |
[INFO] [stderr] 51 |                 let idx = cats.iter().position(|&r| r == pcat).unwrap_or(rg.gen_range(0, 12));
[INFO] [stderr]    |                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| rg.gen_range(0, 12))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `cats`
[INFO] [stderr]   --> src/genproj.rs:56:14
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 for i in 0..projs[idx].len() {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 for (i, <item>) in cats.iter().enumerate().take(projs[idx].len()) {
[INFO] [stderr]    |                     ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/genproj.rs:80:53
[INFO] [stderr]    |
[INFO] [stderr] 80 |             let gcati = cats.iter().position(|&r| r == pcat).unwrap_or(rg.gen_range(0, 12));
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| rg.gen_range(0, 12))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.20s
[INFO] running `"docker" "inspect" "40134eb4ac758927000ac6a4f99c2ffb26acdc9053407e53e49d3c101583d820"`
[INFO] running `"docker" "rm" "-f" "40134eb4ac758927000ac6a4f99c2ffb26acdc9053407e53e49d3c101583d820"`
[INFO] [stdout] 40134eb4ac758927000ac6a4f99c2ffb26acdc9053407e53e49d3c101583d820