[INFO] updating cached repository vishusandy/entropy2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vishusandy/entropy2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vishusandy/entropy2" "work/ex/clippy-test-run/sources/stable/gh/vishusandy/entropy2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vishusandy/entropy2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vishusandy/entropy2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/entropy2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/entropy2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3a591221cdd7c77f5954bf211dac55d1c4b9cc11 [INFO] sha for GitHub repo vishusandy/entropy2: 3a591221cdd7c77f5954bf211dac55d1c4b9cc11 [INFO] validating manifest of vishusandy/entropy2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vishusandy/entropy2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vishusandy/entropy2 [INFO] finished frobbing vishusandy/entropy2 [INFO] frobbed toml for vishusandy/entropy2 written to work/ex/clippy-test-run/sources/stable/gh/vishusandy/entropy2/Cargo.toml [INFO] started frobbing vishusandy/entropy2 [INFO] finished frobbing vishusandy/entropy2 [INFO] frobbed toml for vishusandy/entropy2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/entropy2/Cargo.toml [INFO] crate vishusandy/entropy2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vishusandy/entropy2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/entropy2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5863769116f37847d3af0db2c3d7b7905e139fb4cbb7c31acfa8cf4e40a3631 [INFO] running `"docker" "start" "-a" "f5863769116f37847d3af0db2c3d7b7905e139fb4cbb7c31acfa8cf4e40a3631"` [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking entropy2 v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `a` is used to index `args` [INFO] [stderr] --> src/main.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | for a in 1..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for (a, ) in args.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | histogram.get_mut(b.unwrap() as usize).map(|v| *v += 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = histogram.get_mut(b.unwrap() as usize) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `histogram`. [INFO] [stderr] --> src/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 28 | for in &histogram { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `a` is used to index `args` [INFO] [stderr] --> src/main.rs:14:12 [INFO] [stderr] | [INFO] [stderr] 14 | for a in 1..args.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 14 | for (a, ) in args.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | histogram.get_mut(b.unwrap() as usize).map(|v| *v += 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = histogram.get_mut(b.unwrap() as usize) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `histogram`. [INFO] [stderr] --> src/main.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 28 | for in &histogram { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.02s [INFO] running `"docker" "inspect" "f5863769116f37847d3af0db2c3d7b7905e139fb4cbb7c31acfa8cf4e40a3631"` [INFO] running `"docker" "rm" "-f" "f5863769116f37847d3af0db2c3d7b7905e139fb4cbb7c31acfa8cf4e40a3631"` [INFO] [stdout] f5863769116f37847d3af0db2c3d7b7905e139fb4cbb7c31acfa8cf4e40a3631