[INFO] updating cached repository vintersnow/edit_distance.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vintersnow/edit_distance.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vintersnow/edit_distance.rs" "work/ex/clippy-test-run/sources/stable/gh/vintersnow/edit_distance.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vintersnow/edit_distance.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vintersnow/edit_distance.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vintersnow/edit_distance.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vintersnow/edit_distance.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4a2914343119708430980c38346a214fdfe9d155 [INFO] sha for GitHub repo vintersnow/edit_distance.rs: 4a2914343119708430980c38346a214fdfe9d155 [INFO] validating manifest of vintersnow/edit_distance.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vintersnow/edit_distance.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vintersnow/edit_distance.rs [INFO] finished frobbing vintersnow/edit_distance.rs [INFO] frobbed toml for vintersnow/edit_distance.rs written to work/ex/clippy-test-run/sources/stable/gh/vintersnow/edit_distance.rs/Cargo.toml [INFO] started frobbing vintersnow/edit_distance.rs [INFO] finished frobbing vintersnow/edit_distance.rs [INFO] frobbed toml for vintersnow/edit_distance.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vintersnow/edit_distance.rs/Cargo.toml [INFO] crate vintersnow/edit_distance.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vintersnow/edit_distance.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vintersnow/edit_distance.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94273f98a0feaca63a107f753d21002254b389d2e58f9fe19b535d2ea8f5152e [INFO] running `"docker" "start" "-a" "94273f98a0feaca63a107f753d21002254b389d2e58f9fe19b535d2ea8f5152e"` [INFO] [stderr] Checking edit_distance v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | s1: s1, [INFO] [stderr] | ^^^^^^ help: replace it with: `s1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | s2: s2, [INFO] [stderr] | ^^^^^^ help: replace it with: `s2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | s1: s1, [INFO] [stderr] | ^^^^^^ help: replace it with: `s1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | s2: s2, [INFO] [stderr] | ^^^^^^ help: replace it with: `s2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return self.dist_mat[self.s1.len() - 1][self.s2.len() - 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.dist_mat[self.s1.len() - 1][self.s2.len() - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | self.dist_mat[i][0] = 1000000 as u32; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | self.dist_mat[0][i] = 1000000 as u32; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return self.dist_mat[self.s1.len() - 1][self.s2.len() - 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.dist_mat[self.s1.len() - 1][self.s2.len() - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:54:35 [INFO] [stderr] | [INFO] [stderr] 54 | self.dist_mat[i][0] = 1000000 as u32; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:58:35 [INFO] [stderr] | [INFO] [stderr] 58 | self.dist_mat[0][i] = 1000000 as u32; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:74:39 [INFO] [stderr] | [INFO] [stderr] 74 | self.dist_mat[i][j] = (*m).clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `(*m)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | 0 => j = j-1, [INFO] [stderr] | ^^^^^^^ help: replace it with: `j -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | 1 => i = i-1, [INFO] [stderr] | ^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | _ => {j=j-1; i=i-1} [INFO] [stderr] | ^^^^^ help: replace it with: `j -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:102:30 [INFO] [stderr] | [INFO] [stderr] 102 | _ => {j=j-1; i=i-1} [INFO] [stderr] | ^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:112:46 [INFO] [stderr] | [INFO] [stderr] 112 | 0 => {s2_idx+=1; ("+", (" ", self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 112 | 0 => {s2_idx+=1; ("+", (" ", &(*self.s2[s2_idx]).clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 112 | 0 => {s2_idx+=1; ("+", (" ", &str::clone(self.s2[s2_idx])))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:113:41 [INFO] [stderr] | [INFO] [stderr] 113 | 1 => {s1_idx+=1; ("-", (self.s1[s1_idx].clone(), " "))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 113 | 1 => {s1_idx+=1; ("-", (&(*self.s1[s1_idx]).clone(), " "))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 113 | 1 => {s1_idx+=1; ("-", (&str::clone(self.s1[s1_idx]), " "))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:114:52 [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (self.s1[s1_idx].clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (&(*self.s1[s1_idx]).clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (&str::clone(self.s1[s1_idx]), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:114:77 [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (self.s1[s1_idx].clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (self.s1[s1_idx].clone(), &(*self.s2[s2_idx]).clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (self.s1[s1_idx].clone(), &str::clone(self.s2[s2_idx])))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:115:52 [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (self.s1[s1_idx].clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (&(*self.s1[s1_idx]).clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (&str::clone(self.s1[s1_idx]), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:115:77 [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (self.s1[s1_idx].clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (self.s1[s1_idx].clone(), &(*self.s2[s2_idx]).clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (self.s1[s1_idx].clone(), &str::clone(self.s2[s2_idx])))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:176:8 [INFO] [stderr] | [INFO] [stderr] 176 | if v.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `edit_distance`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:74:39 [INFO] [stderr] | [INFO] [stderr] 74 | self.dist_mat[i][j] = (*m).clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `(*m)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | 0 => j = j-1, [INFO] [stderr] | ^^^^^^^ help: replace it with: `j -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | 1 => i = i-1, [INFO] [stderr] | ^^^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | _ => {j=j-1; i=i-1} [INFO] [stderr] | ^^^^^ help: replace it with: `j -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:102:30 [INFO] [stderr] | [INFO] [stderr] 102 | _ => {j=j-1; i=i-1} [INFO] [stderr] | ^^^^^ help: replace it with: `i -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:112:46 [INFO] [stderr] | [INFO] [stderr] 112 | 0 => {s2_idx+=1; ("+", (" ", self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 112 | 0 => {s2_idx+=1; ("+", (" ", &(*self.s2[s2_idx]).clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 112 | 0 => {s2_idx+=1; ("+", (" ", &str::clone(self.s2[s2_idx])))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:113:41 [INFO] [stderr] | [INFO] [stderr] 113 | 1 => {s1_idx+=1; ("-", (self.s1[s1_idx].clone(), " "))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 113 | 1 => {s1_idx+=1; ("-", (&(*self.s1[s1_idx]).clone(), " "))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 113 | 1 => {s1_idx+=1; ("-", (&str::clone(self.s1[s1_idx]), " "))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:114:52 [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (self.s1[s1_idx].clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (&(*self.s1[s1_idx]).clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (&str::clone(self.s1[s1_idx]), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:114:77 [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (self.s1[s1_idx].clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (self.s1[s1_idx].clone(), &(*self.s2[s2_idx]).clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 114 | 2 => {s1_idx+=1; s2_idx+=1; ("#", (self.s1[s1_idx].clone(), &str::clone(self.s2[s2_idx])))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:115:52 [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (self.s1[s1_idx].clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (&(*self.s1[s1_idx]).clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (&str::clone(self.s1[s1_idx]), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:115:77 [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (self.s1[s1_idx].clone(), self.s2[s2_idx].clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (self.s1[s1_idx].clone(), &(*self.s2[s2_idx]).clone()))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 115 | _ => {s1_idx+=1; s2_idx+=1; ("=", (self.s1[s1_idx].clone(), &str::clone(self.s2[s2_idx])))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:176:8 [INFO] [stderr] | [INFO] [stderr] 176 | if v.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `edit_distance`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "94273f98a0feaca63a107f753d21002254b389d2e58f9fe19b535d2ea8f5152e"` [INFO] running `"docker" "rm" "-f" "94273f98a0feaca63a107f753d21002254b389d2e58f9fe19b535d2ea8f5152e"` [INFO] [stdout] 94273f98a0feaca63a107f753d21002254b389d2e58f9fe19b535d2ea8f5152e