[INFO] updating cached repository vigneshsarma/sudoku.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vigneshsarma/sudoku.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vigneshsarma/sudoku.rs" "work/ex/clippy-test-run/sources/stable/gh/vigneshsarma/sudoku.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vigneshsarma/sudoku.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vigneshsarma/sudoku.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vigneshsarma/sudoku.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vigneshsarma/sudoku.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 23047de68c46fa90149140905b3471629cd000b7 [INFO] sha for GitHub repo vigneshsarma/sudoku.rs: 23047de68c46fa90149140905b3471629cd000b7 [INFO] validating manifest of vigneshsarma/sudoku.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vigneshsarma/sudoku.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vigneshsarma/sudoku.rs [INFO] finished frobbing vigneshsarma/sudoku.rs [INFO] frobbed toml for vigneshsarma/sudoku.rs written to work/ex/clippy-test-run/sources/stable/gh/vigneshsarma/sudoku.rs/Cargo.toml [INFO] started frobbing vigneshsarma/sudoku.rs [INFO] finished frobbing vigneshsarma/sudoku.rs [INFO] frobbed toml for vigneshsarma/sudoku.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vigneshsarma/sudoku.rs/Cargo.toml [INFO] crate vigneshsarma/sudoku.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vigneshsarma/sudoku.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vigneshsarma/sudoku.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b1df80d46951c7ecdb85c35a0506aa1c055c05e12aaf9361fe7f5665320c81b [INFO] running `"docker" "start" "-a" "7b1df80d46951c7ecdb85c35a0506aa1c055c05e12aaf9361fe7f5665320c81b"` [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | Axis{len: 0, i: i, present: [false; 9]} [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | write!(f, "Axis {{{} -> {}, {:?}}}\n", self.i, self.len, self.present) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | Axis{len: 0, i: i, present: [false; 9]} [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | write!(f, "Axis {{{} -> {}, {:?}}}\n", self.i, self.len, self.present) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:200:24 [INFO] [stderr] | [INFO] [stderr] 200 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 201 | | if possible.len() < 3 { [INFO] [stderr] 202 | | return (i, j, possible) [INFO] [stderr] 203 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 200 | } else if possible.len() < 3 { [INFO] [stderr] 201 | return (i, j, possible) [INFO] [stderr] 202 | } else { [INFO] [stderr] 203 | if possible.len() > 0 && ( [INFO] [stderr] 204 | min.len() == 0 || min.len() > possible.len()){ [INFO] [stderr] 205 | r = i; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:203:28 [INFO] [stderr] | [INFO] [stderr] 203 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 204 | | if possible.len() > 0 && ( [INFO] [stderr] 205 | | min.len() == 0 || min.len() > possible.len()){ [INFO] [stderr] 206 | | r = i; [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 203 | } else if possible.len() > 0 && ( [INFO] [stderr] 204 | min.len() == 0 || min.len() > possible.len()){ [INFO] [stderr] 205 | r = i; [INFO] [stderr] 206 | c = j; [INFO] [stderr] 207 | min = possible; [INFO] [stderr] 208 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:200:24 [INFO] [stderr] | [INFO] [stderr] 200 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 201 | | if possible.len() < 3 { [INFO] [stderr] 202 | | return (i, j, possible) [INFO] [stderr] 203 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 200 | } else if possible.len() < 3 { [INFO] [stderr] 201 | return (i, j, possible) [INFO] [stderr] 202 | } else { [INFO] [stderr] 203 | if possible.len() > 0 && ( [INFO] [stderr] 204 | min.len() == 0 || min.len() > possible.len()){ [INFO] [stderr] 205 | r = i; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:203:28 [INFO] [stderr] | [INFO] [stderr] 203 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 204 | | if possible.len() > 0 && ( [INFO] [stderr] 205 | | min.len() == 0 || min.len() > possible.len()){ [INFO] [stderr] 206 | | r = i; [INFO] [stderr] ... | [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 203 | } else if possible.len() > 0 && ( [INFO] [stderr] 204 | min.len() == 0 || min.len() > possible.len()){ [INFO] [stderr] 205 | r = i; [INFO] [stderr] 206 | c = j; [INFO] [stderr] 207 | min = possible; [INFO] [stderr] 208 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if self.present[(val-1) as usize] == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.present[(val-1) as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if self.present[(val-1) as usize] == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.present[(val-1) as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `recorder` [INFO] [stderr] --> src/main.rs:160:26 [INFO] [stderr] | [INFO] [stderr] 160 | for k in 0..9 { // iter over possible values [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 160 | for (k, ) in recorder.iter().enumerate() { // iter over possible values [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `recorder` [INFO] [stderr] --> src/main.rs:160:26 [INFO] [stderr] | [INFO] [stderr] 160 | for k in 0..9 { // iter over possible values [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 160 | for (k, ) in recorder.iter().enumerate() { // iter over possible values [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | let ref mut locations = recorder[k]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^--------------- help: try: `let locations = &mut recorder[k];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | let ref mut locations = recorder[k]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^--------------- help: try: `let locations = &mut recorder[k];` [INFO] [stderr] warning: the loop variable `k` is used to index `recorder` [INFO] [stderr] | [INFO] [stderr] --> src/main.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | for k in 0..9 { [INFO] [stderr] | ^^^^ [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `recorder` [INFO] [stderr] --> src/main.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | for k in 0..9 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 167 | for (k, ) in recorder.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | let ref locations = recorder[k]; [INFO] [stderr] | ----^^^^^^^^^^^^^--------------- help: try: `let locations = &recorder[k];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 167 | for (k, ) in recorder.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | let ref locations = recorder[k]; [INFO] [stderr] | ----^^^^^^^^^^^^^--------------- help: try: `let locations = &recorder[k];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:199:28 [INFO] [stderr] | [INFO] [stderr] 199 | panic!(format!("you have more options before calling me.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"you have more options before calling me.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:204:28 [INFO] [stderr] | [INFO] [stderr] 204 | if possible.len() > 0 && ( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!possible.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:205:29 [INFO] [stderr] | [INFO] [stderr] 205 | min.len() == 0 || min.len() > possible.len()){ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `min.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:199:28 [INFO] [stderr] | [INFO] [stderr] 199 | panic!(format!("you have more options before calling me.")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"you have more options before calling me.".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:204:28 [INFO] [stderr] | [INFO] [stderr] 204 | if possible.len() > 0 && ( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!possible.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:205:29 [INFO] [stderr] | [INFO] [stderr] 205 | min.len() == 0 || min.len() > possible.len()){ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `min.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:401:44 [INFO] [stderr] | [INFO] [stderr] 401 | let game_strs: Vec<&str> = s.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "7b1df80d46951c7ecdb85c35a0506aa1c055c05e12aaf9361fe7f5665320c81b"` [INFO] running `"docker" "rm" "-f" "7b1df80d46951c7ecdb85c35a0506aa1c055c05e12aaf9361fe7f5665320c81b"` [INFO] [stdout] 7b1df80d46951c7ecdb85c35a0506aa1c055c05e12aaf9361fe7f5665320c81b