[INFO] updating cached repository vbrandl/RustyAccessMachine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vbrandl/RustyAccessMachine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vbrandl/RustyAccessMachine" "work/ex/clippy-test-run/sources/stable/gh/vbrandl/RustyAccessMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vbrandl/RustyAccessMachine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vbrandl/RustyAccessMachine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vbrandl/RustyAccessMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vbrandl/RustyAccessMachine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b8e26357d2e36cdd7a443434f0bb3bcc2e6ebb66 [INFO] sha for GitHub repo vbrandl/RustyAccessMachine: b8e26357d2e36cdd7a443434f0bb3bcc2e6ebb66 [INFO] validating manifest of vbrandl/RustyAccessMachine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vbrandl/RustyAccessMachine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vbrandl/RustyAccessMachine [INFO] finished frobbing vbrandl/RustyAccessMachine [INFO] frobbed toml for vbrandl/RustyAccessMachine written to work/ex/clippy-test-run/sources/stable/gh/vbrandl/RustyAccessMachine/Cargo.toml [INFO] started frobbing vbrandl/RustyAccessMachine [INFO] finished frobbing vbrandl/RustyAccessMachine [INFO] frobbed toml for vbrandl/RustyAccessMachine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vbrandl/RustyAccessMachine/Cargo.toml [INFO] crate vbrandl/RustyAccessMachine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vbrandl/RustyAccessMachine against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vbrandl/RustyAccessMachine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80c7159e0c60a775292d9e2a7e23a53fa11699368b5a36c11be43a7a0964b70c [INFO] running `"docker" "start" "-a" "80c7159e0c60a775292d9e2a7e23a53fa11699368b5a36c11be43a7a0964b70c"` [INFO] [stderr] Checking rusty_access_machine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | Some(Instruction { operator: op, operand: operand }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `operand` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(_) => return s, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:85:38 [INFO] [stderr] | [INFO] [stderr] 85 | Some(Instruction { operator: op, operand: operand }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `operand` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:116:35 [INFO] [stderr] | [INFO] [stderr] 116 | Operator::HLT => exit(prog[pc].operand as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(prog[pc].operand)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | Ok(_) => return s, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:116:35 [INFO] [stderr] | [INFO] [stderr] 116 | Operator::HLT => exit(prog[pc].operand as i32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(prog[pc].operand)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "80c7159e0c60a775292d9e2a7e23a53fa11699368b5a36c11be43a7a0964b70c"` [INFO] running `"docker" "rm" "-f" "80c7159e0c60a775292d9e2a7e23a53fa11699368b5a36c11be43a7a0964b70c"` [INFO] [stdout] 80c7159e0c60a775292d9e2a7e23a53fa11699368b5a36c11be43a7a0964b70c