[INFO] updating cached repository vbarrielle/three_doors [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vbarrielle/three_doors [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vbarrielle/three_doors" "work/ex/clippy-test-run/sources/stable/gh/vbarrielle/three_doors"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vbarrielle/three_doors'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vbarrielle/three_doors" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vbarrielle/three_doors"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vbarrielle/three_doors'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a9fdbf1460022f56c57dec40c46a185c7981dcb1 [INFO] sha for GitHub repo vbarrielle/three_doors: a9fdbf1460022f56c57dec40c46a185c7981dcb1 [INFO] validating manifest of vbarrielle/three_doors on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vbarrielle/three_doors on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vbarrielle/three_doors [INFO] finished frobbing vbarrielle/three_doors [INFO] frobbed toml for vbarrielle/three_doors written to work/ex/clippy-test-run/sources/stable/gh/vbarrielle/three_doors/Cargo.toml [INFO] started frobbing vbarrielle/three_doors [INFO] finished frobbing vbarrielle/three_doors [INFO] frobbed toml for vbarrielle/three_doors written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vbarrielle/three_doors/Cargo.toml [INFO] crate vbarrielle/three_doors has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vbarrielle/three_doors against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vbarrielle/three_doors:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59941c4cad6fb1ea9c9acc6ded7f2cc33cb5d1a596cacc4bc8a62d75ef941016 [INFO] running `"docker" "start" "-a" "59941c4cad6fb1ea9c9acc6ded7f2cc33cb5d1a596cacc4bc8a62d75ef941016"` [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking three_doors v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_victorious(self, user_choice: DoorChoice) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | let nb_tries = if let Some(nb_tries_arg) = env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn is_victorious(self, user_choice: DoorChoice) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/main.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | let nb_tries = if let Some(nb_tries_arg) = env::args().skip(1).next() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.68s [INFO] running `"docker" "inspect" "59941c4cad6fb1ea9c9acc6ded7f2cc33cb5d1a596cacc4bc8a62d75ef941016"` [INFO] running `"docker" "rm" "-f" "59941c4cad6fb1ea9c9acc6ded7f2cc33cb5d1a596cacc4bc8a62d75ef941016"` [INFO] [stdout] 59941c4cad6fb1ea9c9acc6ded7f2cc33cb5d1a596cacc4bc8a62d75ef941016