[INFO] updating cached repository vasily-tokarev/activity-tracker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vasily-tokarev/activity-tracker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vasily-tokarev/activity-tracker" "work/ex/clippy-test-run/sources/stable/gh/vasily-tokarev/activity-tracker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vasily-tokarev/activity-tracker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vasily-tokarev/activity-tracker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vasily-tokarev/activity-tracker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vasily-tokarev/activity-tracker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 45f8533fbb8914a5117a9ce594a11605169fbbcb [INFO] sha for GitHub repo vasily-tokarev/activity-tracker: 45f8533fbb8914a5117a9ce594a11605169fbbcb [INFO] validating manifest of vasily-tokarev/activity-tracker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vasily-tokarev/activity-tracker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vasily-tokarev/activity-tracker [INFO] finished frobbing vasily-tokarev/activity-tracker [INFO] frobbed toml for vasily-tokarev/activity-tracker written to work/ex/clippy-test-run/sources/stable/gh/vasily-tokarev/activity-tracker/Cargo.toml [INFO] started frobbing vasily-tokarev/activity-tracker [INFO] finished frobbing vasily-tokarev/activity-tracker [INFO] frobbed toml for vasily-tokarev/activity-tracker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vasily-tokarev/activity-tracker/Cargo.toml [INFO] crate vasily-tokarev/activity-tracker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vasily-tokarev/activity-tracker against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vasily-tokarev/activity-tracker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5fe57d8c84dd6e762cf93a9efc70aa28b7d09f3c8e069d860194d042400d89da [INFO] running `"docker" "start" "-a" "5fe57d8c84dd6e762cf93a9efc70aa28b7d09f3c8e069d860194d042400d89da"` [INFO] [stderr] Checking activity-timer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | return (seconds_left / 60).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(seconds_left / 60).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | return seconds_left.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `seconds_left.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 14 | | if seconds_left > 60 { [INFO] [stderr] 15 | | return (seconds_left / 60).to_string(); [INFO] [stderr] 16 | | } else { [INFO] [stderr] 17 | | return seconds_left.to_string(); [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 13 | } else if seconds_left > 60 { [INFO] [stderr] 14 | return (seconds_left / 60).to_string(); [INFO] [stderr] 15 | } else { [INFO] [stderr] 16 | return seconds_left.to_string(); [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | return (seconds_left / 60).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(seconds_left / 60).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | return seconds_left.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `seconds_left.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 14 | | if seconds_left > 60 { [INFO] [stderr] 15 | | return (seconds_left / 60).to_string(); [INFO] [stderr] 16 | | } else { [INFO] [stderr] 17 | | return seconds_left.to_string(); [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 13 | } else if seconds_left > 60 { [INFO] [stderr] 14 | return (seconds_left / 60).to_string(); [INFO] [stderr] 15 | } else { [INFO] [stderr] 16 | return seconds_left.to_string(); [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | if paused == false { paused = true } else { paused = false } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!paused` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/main.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | if seconds_left == 0 || seconds_left < 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `seconds_left <= 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:66:24 [INFO] [stderr] | [INFO] [stderr] 66 | if paused == false { paused = true } else { paused = false } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!paused` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/main.rs:75:16 [INFO] [stderr] | [INFO] [stderr] 75 | if seconds_left == 0 || seconds_left < 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `seconds_left <= 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "5fe57d8c84dd6e762cf93a9efc70aa28b7d09f3c8e069d860194d042400d89da"` [INFO] running `"docker" "rm" "-f" "5fe57d8c84dd6e762cf93a9efc70aa28b7d09f3c8e069d860194d042400d89da"` [INFO] [stdout] 5fe57d8c84dd6e762cf93a9efc70aa28b7d09f3c8e069d860194d042400d89da