[INFO] updating cached repository varzac/rust_collections [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/varzac/rust_collections [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/varzac/rust_collections" "work/ex/clippy-test-run/sources/stable/gh/varzac/rust_collections"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/varzac/rust_collections'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/varzac/rust_collections" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varzac/rust_collections"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varzac/rust_collections'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] db1285199d9300d32cdd25281583753dc1de814d [INFO] sha for GitHub repo varzac/rust_collections: db1285199d9300d32cdd25281583753dc1de814d [INFO] validating manifest of varzac/rust_collections on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of varzac/rust_collections on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing varzac/rust_collections [INFO] finished frobbing varzac/rust_collections [INFO] frobbed toml for varzac/rust_collections written to work/ex/clippy-test-run/sources/stable/gh/varzac/rust_collections/Cargo.toml [INFO] started frobbing varzac/rust_collections [INFO] finished frobbing varzac/rust_collections [INFO] frobbed toml for varzac/rust_collections written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varzac/rust_collections/Cargo.toml [INFO] crate varzac/rust_collections has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting varzac/rust_collections against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varzac/rust_collections:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba654adf5b9d88aed3bdf0a8c0929539fcc842a5b98cfb2bda211826f1e324d9 [INFO] running `"docker" "start" "-a" "ba654adf5b9d88aed3bdf0a8c0929539fcc842a5b98cfb2bda211826f1e324d9"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/linked_list.rs` was erroneously implicitly accepted for binary `linked_list`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking linked_list v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `delete_val` [INFO] [stderr] --> src/linked_list.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | fn delete_val(&self, val: &T) -> Option>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `insert_val` [INFO] [stderr] --> src/linked_list.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn insert_val(&self, val: T) -> LinkedList { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `length` [INFO] [stderr] --> src/linked_list.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn length(&self) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `find` [INFO] [stderr] --> src/linked_list.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | fn find(&self, val: T) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/linked_list.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | / match get_val { [INFO] [stderr] 171 | | Some(_) => panic!("Index {} should be out of bounds!", 15), [INFO] [stderr] 172 | | None => () [INFO] [stderr] 173 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(_) = get_val { panic!("Index {} should be out of bounds!", 15) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/linked_list.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / match idx { [INFO] [stderr] 189 | | Some(_) => panic!("Should not find 15"), [INFO] [stderr] 190 | | None => () [INFO] [stderr] 191 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(_) = idx { panic!("Should not find 15") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/linked_list.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / match find_idx { [INFO] [stderr] 239 | | Some(_) => panic!("Should not find deleted value"), [INFO] [stderr] 240 | | None => () [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = find_idx { panic!("Should not find deleted value") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/linked_list.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | / match find_idx { [INFO] [stderr] 257 | | Some(_) => panic!("Should not find value, it was never in the list"), [INFO] [stderr] 258 | | None => () [INFO] [stderr] 259 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = find_idx { panic!("Should not find value, it was never in the list") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/linked_list.rs:270:5 [INFO] [stderr] | [INFO] [stderr] 270 | / match del_list { [INFO] [stderr] 271 | | Some(_) => { [INFO] [stderr] 272 | | panic!("The only element should have been deleted!") [INFO] [stderr] 273 | | }, [INFO] [stderr] 274 | | None => () [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 270 | if let Some(_) = del_list { [INFO] [stderr] 271 | panic!("The only element should have been deleted!") [INFO] [stderr] 272 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.60s [INFO] running `"docker" "inspect" "ba654adf5b9d88aed3bdf0a8c0929539fcc842a5b98cfb2bda211826f1e324d9"` [INFO] running `"docker" "rm" "-f" "ba654adf5b9d88aed3bdf0a8c0929539fcc842a5b98cfb2bda211826f1e324d9"` [INFO] [stdout] ba654adf5b9d88aed3bdf0a8c0929539fcc842a5b98cfb2bda211826f1e324d9