[INFO] updating cached repository valdron/aoc-2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/valdron/aoc-2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/valdron/aoc-2017" "work/ex/clippy-test-run/sources/stable/gh/valdron/aoc-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/valdron/aoc-2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/valdron/aoc-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valdron/aoc-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valdron/aoc-2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 37bb9e7a0fb25da35ce781efb7db594f665bd8b1 [INFO] sha for GitHub repo valdron/aoc-2017: 37bb9e7a0fb25da35ce781efb7db594f665bd8b1 [INFO] validating manifest of valdron/aoc-2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of valdron/aoc-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing valdron/aoc-2017 [INFO] finished frobbing valdron/aoc-2017 [INFO] frobbed toml for valdron/aoc-2017 written to work/ex/clippy-test-run/sources/stable/gh/valdron/aoc-2017/Cargo.toml [INFO] started frobbing valdron/aoc-2017 [INFO] finished frobbing valdron/aoc-2017 [INFO] frobbed toml for valdron/aoc-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valdron/aoc-2017/Cargo.toml [INFO] crate valdron/aoc-2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting valdron/aoc-2017 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valdron/aoc-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c2b9ea05c3bc795c7e130d7d4c19455e6d0e5a33d4f53bdd3ed00f01ac4412ee [INFO] running `"docker" "start" "-a" "c2b9ea05c3bc795c7e130d7d4c19455e6d0e5a33d4f53bdd3ed00f01ac4412ee"` [INFO] [stderr] Checking aoc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day1/mod.rs:23:41 [INFO] [stderr] | [INFO] [stderr] 23 | .map(|x| x.to_digit(10).ok_or(format!("Parse error: {}", x))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Parse error: {}", x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day3/mod.rs:5:47 [INFO] [stderr] | [INFO] [stderr] 5 | let (x, y) = circle.nth((x - 2) as usize).ok_or("IterError!".to_owned())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "IterError!".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day3/mod.rs:5:47 [INFO] [stderr] | [INFO] [stderr] 5 | let (x, y) = circle.nth((x - 2) as usize).ok_or("IterError!".to_owned())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "IterError!".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day6/mod.rs:8:76 [INFO] [stderr] | [INFO] [stderr] 8 | banks.into_bankredis_iter().find_duplicate().and_then(|(i,_)| Some(i)).ok_or("None".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "None".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day6/mod.rs:14:42 [INFO] [stderr] | [INFO] [stderr] 14 | let (_, dup) = iter.find_duplicate().ok_or("None".to_owned())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "None".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day6/mod.rs:15:49 [INFO] [stderr] | [INFO] [stderr] 15 | iter.position(|x| x == dup).map(|x| x + 1 ).ok_or("None".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "None".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day6/mod.rs:8:76 [INFO] [stderr] | [INFO] [stderr] 8 | banks.into_bankredis_iter().find_duplicate().and_then(|(i,_)| Some(i)).ok_or("None".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "None".into())` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day5/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | update: update, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `update` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day6/mod.rs:14:42 [INFO] [stderr] | [INFO] [stderr] 14 | let (_, dup) = iter.find_duplicate().ok_or("None".to_owned())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "None".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day6/mod.rs:15:49 [INFO] [stderr] | [INFO] [stderr] 15 | iter.position(|x| x == dup).map(|x| x + 1 ).ok_or("None".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "None".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day5/mod.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | update: update, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `update` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/day1/mod.rs:23:41 [INFO] [stderr] | [INFO] [stderr] 23 | .map(|x| x.to_digit(10).ok_or(format!("Parse error: {}", x))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Parse error: {}", x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.65s [INFO] running `"docker" "inspect" "c2b9ea05c3bc795c7e130d7d4c19455e6d0e5a33d4f53bdd3ed00f01ac4412ee"` [INFO] running `"docker" "rm" "-f" "c2b9ea05c3bc795c7e130d7d4c19455e6d0e5a33d4f53bdd3ed00f01ac4412ee"` [INFO] [stdout] c2b9ea05c3bc795c7e130d7d4c19455e6d0e5a33d4f53bdd3ed00f01ac4412ee