[INFO] updating cached repository vaithak/scp-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/vaithak/scp-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/vaithak/scp-rust" "work/ex/clippy-test-run/sources/stable/gh/vaithak/scp-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vaithak/scp-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/vaithak/scp-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vaithak/scp-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vaithak/scp-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 47cf0dc49873a5a66399ae4fdb9cde2187dd91bf
[INFO] sha for GitHub repo vaithak/scp-rust: 47cf0dc49873a5a66399ae4fdb9cde2187dd91bf
[INFO] validating manifest of vaithak/scp-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vaithak/scp-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vaithak/scp-rust
[INFO] finished frobbing vaithak/scp-rust
[INFO] frobbed toml for vaithak/scp-rust written to work/ex/clippy-test-run/sources/stable/gh/vaithak/scp-rust/Cargo.toml
[INFO] started frobbing vaithak/scp-rust
[INFO] finished frobbing vaithak/scp-rust
[INFO] frobbed toml for vaithak/scp-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vaithak/scp-rust/Cargo.toml
[INFO] crate vaithak/scp-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vaithak/scp-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vaithak/scp-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9f2053a50f0b5404b639b0a2408f42221a4ae580fad97a2198efd903e7342e84
[INFO] running `"docker" "start" "-a" "9f2053a50f0b5404b639b0a2408f42221a4ae580fad97a2198efd903e7342e84"`
[INFO] [stderr]     Checking same-file v1.0.4
[INFO] [stderr]     Checking walkdir v2.2.6
[INFO] [stderr]     Checking scp v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `dest_path`
[INFO] [stderr]  --> src/main.rs:9:40
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn recursive_copy(source_path: String, dest_path: String) {
[INFO] [stderr]   |                                        ^^^^^^^^^ help: consider using `_dest_path` instead
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fs::copy(source_path, dest_path);  // Copy foo.txt to bar.txt
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:23:26
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn check_type(file_type: &String) -> i32{
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]   --> src/main.rs:57:43
[INFO] [stderr]    |
[INFO] [stderr] 57 |         let index = args.iter().position(|&ref x| x == "-r");
[INFO] [stderr]    |                                           ^^^^^^ help: try removing the `&ref` part and just keep: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_borrowed_reference)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dest_path`
[INFO] [stderr]  --> src/main.rs:9:40
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn recursive_copy(source_path: String, dest_path: String) {
[INFO] [stderr]   |                                        ^^^^^^^^^ help: consider using `_dest_path` instead
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     fs::copy(source_path, dest_path);  // Copy foo.txt to bar.txt
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:23:26
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn check_type(file_type: &String) -> i32{
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this pattern takes a reference on something that is being de-referenced
[INFO] [stderr]   --> src/main.rs:57:43
[INFO] [stderr]    |
[INFO] [stderr] 57 |         let index = args.iter().position(|&ref x| x == "-r");
[INFO] [stderr]    |                                           ^^^^^^ help: try removing the `&ref` part and just keep: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_borrowed_reference)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.55s
[INFO] running `"docker" "inspect" "9f2053a50f0b5404b639b0a2408f42221a4ae580fad97a2198efd903e7342e84"`
[INFO] running `"docker" "rm" "-f" "9f2053a50f0b5404b639b0a2408f42221a4ae580fad97a2198efd903e7342e84"`
[INFO] [stdout] 9f2053a50f0b5404b639b0a2408f42221a4ae580fad97a2198efd903e7342e84