[INFO] updating cached repository uwu-bot/Minigrep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/uwu-bot/Minigrep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/uwu-bot/Minigrep" "work/ex/clippy-test-run/sources/stable/gh/uwu-bot/Minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/uwu-bot/Minigrep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/uwu-bot/Minigrep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uwu-bot/Minigrep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uwu-bot/Minigrep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1900dfc07f490e377a7430b6062e78b177982072 [INFO] sha for GitHub repo uwu-bot/Minigrep: 1900dfc07f490e377a7430b6062e78b177982072 [INFO] validating manifest of uwu-bot/Minigrep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uwu-bot/Minigrep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uwu-bot/Minigrep [INFO] finished frobbing uwu-bot/Minigrep [INFO] frobbed toml for uwu-bot/Minigrep written to work/ex/clippy-test-run/sources/stable/gh/uwu-bot/Minigrep/Cargo.toml [INFO] started frobbing uwu-bot/Minigrep [INFO] finished frobbing uwu-bot/Minigrep [INFO] frobbed toml for uwu-bot/Minigrep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uwu-bot/Minigrep/Cargo.toml [INFO] crate uwu-bot/Minigrep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uwu-bot/Minigrep against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uwu-bot/Minigrep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c5f96f9bf28c283a91db8f2fed45ee2e3cafd69f7da168001763f68402ed2947 [INFO] running `"docker" "start" "-a" "c5f96f9bf28c283a91db8f2fed45ee2e3cafd69f7da168001763f68402ed2947"` [INFO] [stderr] Checking minigrep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / let mut case_sensitive = true; [INFO] [stderr] 19 | | if args.contains(&String::from("-ci")) { [INFO] [stderr] 20 | | case_sensitive = false; [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let case_sensitive = if args.contains(&String::from("-ci")) { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / let mut case_sensitive = true; [INFO] [stderr] 19 | | if args.contains(&String::from("-ci")) { [INFO] [stderr] 20 | | case_sensitive = false; [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let case_sensitive = if args.contains(&String::from("-ci")) { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.05s [INFO] running `"docker" "inspect" "c5f96f9bf28c283a91db8f2fed45ee2e3cafd69f7da168001763f68402ed2947"` [INFO] running `"docker" "rm" "-f" "c5f96f9bf28c283a91db8f2fed45ee2e3cafd69f7da168001763f68402ed2947"` [INFO] [stdout] c5f96f9bf28c283a91db8f2fed45ee2e3cafd69f7da168001763f68402ed2947