[INFO] updating cached repository utrescu/Rust-Pinchazo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/utrescu/Rust-Pinchazo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/utrescu/Rust-Pinchazo" "work/ex/clippy-test-run/sources/stable/gh/utrescu/Rust-Pinchazo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/utrescu/Rust-Pinchazo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/utrescu/Rust-Pinchazo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utrescu/Rust-Pinchazo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utrescu/Rust-Pinchazo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff8fd2e828ea47aeebb6914c10849d5a1e694036 [INFO] sha for GitHub repo utrescu/Rust-Pinchazo: ff8fd2e828ea47aeebb6914c10849d5a1e694036 [INFO] validating manifest of utrescu/Rust-Pinchazo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of utrescu/Rust-Pinchazo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing utrescu/Rust-Pinchazo [INFO] finished frobbing utrescu/Rust-Pinchazo [INFO] frobbed toml for utrescu/Rust-Pinchazo written to work/ex/clippy-test-run/sources/stable/gh/utrescu/Rust-Pinchazo/Cargo.toml [INFO] started frobbing utrescu/Rust-Pinchazo [INFO] finished frobbing utrescu/Rust-Pinchazo [INFO] frobbed toml for utrescu/Rust-Pinchazo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utrescu/Rust-Pinchazo/Cargo.toml [INFO] crate utrescu/Rust-Pinchazo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting utrescu/Rust-Pinchazo against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utrescu/Rust-Pinchazo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6bb67b465361896a8e845d0362ac8133ced4eec60f688915367b11e576eb2016 [INFO] running `"docker" "start" "-a" "6bb67b465361896a8e845d0362ac8133ced4eec60f688915367b11e576eb2016"` [INFO] [stderr] Checking rebenton v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_) => panic!("Unable to read file {:?}", filename), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the variable `countlines` is used as a loop counter. Consider using `for (countlines, item) in buffer.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | for line in buffer.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | Err(_) => panic!("Error reading line {}", countlines), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:40:15 [INFO] [stderr] | [INFO] [stderr] 40 | fn turn(roda: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | let right: i32 = match numeros[0] > numeros[1] { [INFO] [stderr] | ______________________^ [INFO] [stderr] 48 | | true => 360 - numeros[0] + numeros[1], [INFO] [stderr] 49 | | false => (numeros[1] - numeros[0]) % 360, [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if numeros[0] > numeros[1] { 360 - numeros[0] + numeros[1] } else { (numeros[1] - numeros[0]) % 360 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | Err(_) => panic!("Unable to read file {:?}", filename), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the variable `countlines` is used as a loop counter. Consider using `for (countlines, item) in buffer.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | for line in buffer.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | Err(_) => panic!("Error reading line {}", countlines), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:40:15 [INFO] [stderr] | [INFO] [stderr] 40 | fn turn(roda: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | let right: i32 = match numeros[0] > numeros[1] { [INFO] [stderr] | ______________________^ [INFO] [stderr] 48 | | true => 360 - numeros[0] + numeros[1], [INFO] [stderr] 49 | | false => (numeros[1] - numeros[0]) % 360, [INFO] [stderr] 50 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if numeros[0] > numeros[1] { 360 - numeros[0] + numeros[1] } else { (numeros[1] - numeros[0]) % 360 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.79s [INFO] running `"docker" "inspect" "6bb67b465361896a8e845d0362ac8133ced4eec60f688915367b11e576eb2016"` [INFO] running `"docker" "rm" "-f" "6bb67b465361896a8e845d0362ac8133ced4eec60f688915367b11e576eb2016"` [INFO] [stdout] 6bb67b465361896a8e845d0362ac8133ced4eec60f688915367b11e576eb2016