[INFO] updating cached repository utam0k/r8cc
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/utam0k/r8cc
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/utam0k/r8cc" "work/ex/clippy-test-run/sources/stable/gh/utam0k/r8cc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/utam0k/r8cc'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/utam0k/r8cc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utam0k/r8cc"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utam0k/r8cc'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 60d03075da9d0a8f73d50f99b70cd2de706f7ca6
[INFO] sha for GitHub repo utam0k/r8cc: 60d03075da9d0a8f73d50f99b70cd2de706f7ca6
[INFO] validating manifest of utam0k/r8cc on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of utam0k/r8cc on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing utam0k/r8cc
[INFO] finished frobbing utam0k/r8cc
[INFO] frobbed toml for utam0k/r8cc written to work/ex/clippy-test-run/sources/stable/gh/utam0k/r8cc/Cargo.toml
[INFO] started frobbing utam0k/r8cc
[INFO] finished frobbing utam0k/r8cc
[INFO] frobbed toml for utam0k/r8cc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utam0k/r8cc/Cargo.toml
[INFO] crate utam0k/r8cc has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting utam0k/r8cc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utam0k/r8cc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a78d4ec2707a44610d9ef63503f893fde148b89cbdcec5a1c2f2af26479220f5
[INFO] running `"docker" "start" "-a" "a78d4ec2707a44610d9ef63503f893fde148b89cbdcec5a1c2f2af26479220f5"`
[INFO] [stderr]     Checking lazy_static v1.0.1
[INFO] [stderr]     Checking r8cc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/stream.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             pos: pos,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `pos`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             ctype: ctype,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `ctype`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             fname: fname,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `fname`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:183:16
[INFO] [stderr]     |
[INFO] [stderr] 183 |         Self { kind: kind }
[INFO] [stderr]     |                ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/lib.rs:639:5
[INFO] [stderr]     |
[INFO] [stderr] 639 |     print!("\t.data\n");
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/lib.rs:642:9
[INFO] [stderr]     |
[INFO] [stderr] 642 |         print!(".string \"{}\"\n", quote(&p));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/stream.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             pos: pos,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `pos`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:59:13
[INFO] [stderr]    |
[INFO] [stderr] 59 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |             ctype: ctype,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `ctype`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             fname: fname,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `fname`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |             args: args,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `args`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:183:16
[INFO] [stderr]     |
[INFO] [stderr] 183 |         Self { kind: kind }
[INFO] [stderr]     |                ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/lib.rs:639:5
[INFO] [stderr]     |
[INFO] [stderr] 639 |     print!("\t.data\n");
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]    --> src/lib.rs:642:9
[INFO] [stderr]     |
[INFO] [stderr] 642 |         print!(".string \"{}\"\n", quote(&p));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `context::Context`
[INFO] [stderr]   --> src/context.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     pub fn new() -> Self {
[INFO] [stderr] 14 | |         Self {
[INFO] [stderr] 15 | |             vars: LinkedList::new(),
[INFO] [stderr] 16 | |             strings: LinkedList::new(),
[INFO] [stderr] 17 | |             sid: 0,
[INFO] [stderr] 18 | |         }
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/lex.rs:36:16
[INFO] [stderr]    |
[INFO] [stderr] 36 |             if !UNGOTTEN.is_none() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: try: `UNGOTTEN.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lex.rs:149:55
[INFO] [stderr]     |
[INFO] [stderr] 149 |             'a'...'z' | 'A'...'Z' | '_' => read_ident(c.clone()),
[INFO] [stderr]     |                                                       ^^^^^^^^^ help: try removing the `clone` call: `c`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lex.rs:151:35
[INFO] [stderr]     |
[INFO] [stderr] 151 |                 Token::TtypePunct(c.clone())
[INFO] [stderr]     |                                   ^^^^^^^^^ help: try removing the `clone` call: `c`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/lex.rs:172:12
[INFO] [stderr]     |
[INFO] [stderr] 172 |         if !UNGOTTEN.is_none() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: try: `UNGOTTEN.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/stream.rs:58:25
[INFO] [stderr]    |
[INFO] [stderr] 58 |             return Some(c.clone());
[INFO] [stderr]    |                         ^^^^^^^^^ help: try dereferencing it: `*c`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:66:19
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn find_var(name: &String) -> Option<Var> {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:167:44
[INFO] [stderr]     |
[INFO] [stderr] 167 |               AstKind::Literal(ref ctype) => match ctype {
[INFO] [stderr]     |  ____________________________________________^
[INFO] [stderr] 168 | |                 Ctype::Array(c_chars, _) => {
[INFO] [stderr] 169 | |                     let mut s = String::new();
[INFO] [stderr] 170 | |                     for c_char in c_chars {
[INFO] [stderr] ...   |
[INFO] [stderr] 178 | |                 _ => (),
[INFO] [stderr] 179 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 167 |             AstKind::Literal(ref ctype) => if let Ctype::Array(c_chars, _) = ctype {
[INFO] [stderr] 168 |     let mut s = String::new();
[INFO] [stderr] 169 |     for c_char in c_chars {
[INFO] [stderr] 170 |         match c_char {
[INFO] [stderr] 171 |             Ctype::Char(c) => s.push(c.clone()),
[INFO] [stderr] 172 |             _ => unreachable!(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `REGS`.
[INFO] [stderr]    --> src/lib.rs:234:26
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 for i in 1..args_len {
[INFO] [stderr]     |                          ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 for <item> in REGS.iter().take(args_len).skip(1) {
[INFO] [stderr]     |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:253:17
[INFO] [stderr]     |
[INFO] [stderr] 253 | /                 match operand.kind {
[INFO] [stderr] 254 | |                     AstKind::Var(ref var) => print!("lea -{}(%rbp), %rax\n\t", var.vpos * 8),
[INFO] [stderr] 255 | |                     _ => (),
[INFO] [stderr] 256 | |                 }
[INFO] [stderr]     | |_________________^ help: try this: `if let AstKind::Var(ref var) = operand.kind { print!("lea -{}(%rbp), %rax\n\t", var.vpos * 8) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/lib.rs:281:34
[INFO] [stderr]     |
[INFO] [stderr] 281 |     fn emit_assign(&self, value: &Box<Self>) {
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: try: `&Self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:420:5
[INFO] [stderr]     |
[INFO] [stderr] 420 | /     let types;
[INFO] [stderr] 421 | |     if a_type > b_type {
[INFO] [stderr] 422 | |         types = (b_type, a_type);
[INFO] [stderr] 423 | |     } else {
[INFO] [stderr] 424 | |         types = (a_type, b_type);
[INFO] [stderr] 425 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let types = if a_type > b_type { (b_type, a_type) } else { (a_type, b_type) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:438:30
[INFO] [stderr]     |
[INFO] [stderr] 438 |         Int(a) => return Int(a.clone()),
[INFO] [stderr]     |                              ^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:439:31
[INFO] [stderr]     |
[INFO] [stderr] 439 |         Char(a) => return Int(a.clone() as i32),
[INFO] [stderr]     |                               ^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `context::Context`
[INFO] [stderr]   --> src/context.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     pub fn new() -> Self {
[INFO] [stderr] 14 | |         Self {
[INFO] [stderr] 15 | |             vars: LinkedList::new(),
[INFO] [stderr] 16 | |             strings: LinkedList::new(),
[INFO] [stderr] 17 | |             sid: 0,
[INFO] [stderr] 18 | |         }
[INFO] [stderr] 19 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]   --> src/lex.rs:36:16
[INFO] [stderr]    |
[INFO] [stderr] 36 |             if !UNGOTTEN.is_none() {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: try: `UNGOTTEN.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lex.rs:149:55
[INFO] [stderr]     |
[INFO] [stderr] 149 |             'a'...'z' | 'A'...'Z' | '_' => read_ident(c.clone()),
[INFO] [stderr]     |                                                       ^^^^^^^^^ help: try removing the `clone` call: `c`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lex.rs:151:35
[INFO] [stderr]     |
[INFO] [stderr] 151 |                 Token::TtypePunct(c.clone())
[INFO] [stderr]     |                                   ^^^^^^^^^ help: try removing the `clone` call: `c`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/lex.rs:172:12
[INFO] [stderr]     |
[INFO] [stderr] 172 |         if !UNGOTTEN.is_none() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: try: `UNGOTTEN.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:622:13
[INFO] [stderr]     |
[INFO] [stderr] 622 | fn quote(q: &String) -> String {
[INFO] [stderr]     |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/stream.rs:58:25
[INFO] [stderr]    |
[INFO] [stderr] 58 |             return Some(c.clone());
[INFO] [stderr]    |                         ^^^^^^^^^ help: try dereferencing it: `*c`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:66:19
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn find_var(name: &String) -> Option<Var> {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:167:44
[INFO] [stderr]     |
[INFO] [stderr] 167 |               AstKind::Literal(ref ctype) => match ctype {
[INFO] [stderr]     |  ____________________________________________^
[INFO] [stderr] 168 | |                 Ctype::Array(c_chars, _) => {
[INFO] [stderr] 169 | |                     let mut s = String::new();
[INFO] [stderr] 170 | |                     for c_char in c_chars {
[INFO] [stderr] ...   |
[INFO] [stderr] 178 | |                 _ => (),
[INFO] [stderr] 179 | |             },
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 167 |             AstKind::Literal(ref ctype) => if let Ctype::Array(c_chars, _) = ctype {
[INFO] [stderr] 168 |     let mut s = String::new();
[INFO] [stderr] 169 |     for c_char in c_chars {
[INFO] [stderr] 170 |         match c_char {
[INFO] [stderr] 171 |             Ctype::Char(c) => s.push(c.clone()),
[INFO] [stderr] 172 |             _ => unreachable!(),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `REGS`.
[INFO] [stderr]    --> src/lib.rs:234:26
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 for i in 1..args_len {
[INFO] [stderr]     |                          ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 234 |                 for <item> in REGS.iter().take(args_len).skip(1) {
[INFO] [stderr]     |                     ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:253:17
[INFO] [stderr]     |
[INFO] [stderr] 253 | /                 match operand.kind {
[INFO] [stderr] 254 | |                     AstKind::Var(ref var) => print!("lea -{}(%rbp), %rax\n\t", var.vpos * 8),
[INFO] [stderr] 255 | |                     _ => (),
[INFO] [stderr] 256 | |                 }
[INFO] [stderr]     | |_________________^ help: try this: `if let AstKind::Var(ref var) = operand.kind { print!("lea -{}(%rbp), %rax\n\t", var.vpos * 8) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/lib.rs:281:34
[INFO] [stderr]     |
[INFO] [stderr] 281 |     fn emit_assign(&self, value: &Box<Self>) {
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: try: `&Self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:420:5
[INFO] [stderr]     |
[INFO] [stderr] 420 | /     let types;
[INFO] [stderr] 421 | |     if a_type > b_type {
[INFO] [stderr] 422 | |         types = (b_type, a_type);
[INFO] [stderr] 423 | |     } else {
[INFO] [stderr] 424 | |         types = (a_type, b_type);
[INFO] [stderr] 425 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let types = if a_type > b_type { (b_type, a_type) } else { (a_type, b_type) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:438:30
[INFO] [stderr]     |
[INFO] [stderr] 438 |         Int(a) => return Int(a.clone()),
[INFO] [stderr]     |                              ^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/lib.rs:439:31
[INFO] [stderr]     |
[INFO] [stderr] 439 |         Char(a) => return Int(a.clone() as i32),
[INFO] [stderr]     |                               ^^^^^^^^^ help: try dereferencing it: `*a`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:622:13
[INFO] [stderr]     |
[INFO] [stderr] 622 | fn quote(q: &String) -> String {
[INFO] [stderr]     |             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 |         print!(".global mymain\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         print!("ret\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 |         print!(".global mymain\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         print!("ret\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/main.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     loop {
[INFO] [stderr] 10 | |         if let Some(t) = r8cc::read_decl_or_stmt() {
[INFO] [stderr] 11 | |             exprs.push(t);
[INFO] [stderr] 12 | |         } else {
[INFO] [stderr] 13 | |             break;
[INFO] [stderr] 14 | |         }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(t) = r8cc::read_decl_or_stmt() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/main.rs:9:5
[INFO] [stderr]    |
[INFO] [stderr] 9  | /     loop {
[INFO] [stderr] 10 | |         if let Some(t) = r8cc::read_decl_or_stmt() {
[INFO] [stderr] 11 | |             exprs.push(t);
[INFO] [stderr] 12 | |         } else {
[INFO] [stderr] 13 | |             break;
[INFO] [stderr] 14 | |         }
[INFO] [stderr] 15 | |     }
[INFO] [stderr]    | |_____^ help: try: `while let Some(t) = r8cc::read_decl_or_stmt() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.47s
[INFO] running `"docker" "inspect" "a78d4ec2707a44610d9ef63503f893fde148b89cbdcec5a1c2f2af26479220f5"`
[INFO] running `"docker" "rm" "-f" "a78d4ec2707a44610d9ef63503f893fde148b89cbdcec5a1c2f2af26479220f5"`
[INFO] [stdout] a78d4ec2707a44610d9ef63503f893fde148b89cbdcec5a1c2f2af26479220f5