[INFO] updating cached repository ustulation/ffi-trait-poc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ustulation/ffi-trait-poc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ustulation/ffi-trait-poc" "work/ex/clippy-test-run/sources/stable/gh/ustulation/ffi-trait-poc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ustulation/ffi-trait-poc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ustulation/ffi-trait-poc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ustulation/ffi-trait-poc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ustulation/ffi-trait-poc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7d131d9f948fbc7162c6938698dff20043949199 [INFO] sha for GitHub repo ustulation/ffi-trait-poc: 7d131d9f948fbc7162c6938698dff20043949199 [INFO] validating manifest of ustulation/ffi-trait-poc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ustulation/ffi-trait-poc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ustulation/ffi-trait-poc [INFO] finished frobbing ustulation/ffi-trait-poc [INFO] frobbed toml for ustulation/ffi-trait-poc written to work/ex/clippy-test-run/sources/stable/gh/ustulation/ffi-trait-poc/Cargo.toml [INFO] started frobbing ustulation/ffi-trait-poc [INFO] finished frobbing ustulation/ffi-trait-poc [INFO] frobbed toml for ustulation/ffi-trait-poc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ustulation/ffi-trait-poc/Cargo.toml [INFO] crate ustulation/ffi-trait-poc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ustulation/ffi-trait-poc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ustulation/ffi-trait-poc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98a9b7304186b3118302fd14643651aee5cb8ae42175fd4d3db87a1e5eb59e41 [INFO] running `"docker" "start" "-a" "98a9b7304186b3118302fd14643651aee5cb8ae42175fd4d3db87a1e5eb59e41"` [INFO] [stderr] Checking ffi-trait-poc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | b_len: b_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | b_cap: b_cap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | c_len: c_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `c_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | c_cap: c_cap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `c_cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | b_len: b_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | b_cap: b_cap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `b_cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | c_len: c_len, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `c_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | c_cap: c_cap, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `c_cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | Ok((CString::new(self)?.into_raw())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | Ok((CString::new(self)?.into_raw())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | Ok((CString::new(self)?.into_raw())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/main.rs:56:12 [INFO] [stderr] | [INFO] [stderr] 56 | Ok((CString::new(self)?.into_raw())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | Ok(unsafe { CString::from_raw(*c) }.into_string()?) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | Ok(unsafe { CStr::from_ptr(*c) }.to_str()?.to_owned()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:67:52 [INFO] [stderr] | [INFO] [stderr] 67 | let v_ffi = unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:67:60 [INFO] [stderr] | [INFO] [stderr] 67 | let v_ffi = unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:67:68 [INFO] [stderr] | [INFO] [stderr] 67 | let v_ffi = unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | Ok(unsafe { CString::from_raw(*c) }.into_string()?) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:75:63 [INFO] [stderr] | [INFO] [stderr] 75 | let slice_ffi = unsafe { std::slice::from_raw_parts((*c).0, (*c).1) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:75:71 [INFO] [stderr] | [INFO] [stderr] 75 | let slice_ffi = unsafe { std::slice::from_raw_parts((*c).0, (*c).1) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:100:43 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }) [INFO] [stderr] | ^ [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:53:37 [INFO] [stderr] | [INFO] [stderr] 53 | Ok(unsafe { CStr::from_ptr(*c) }.to_str()?.to_owned()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:100:59 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:67:52 [INFO] [stderr] | [INFO] [stderr] 67 | let v_ffi = unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:67:60 [INFO] [stderr] | [INFO] [stderr] 67 | let v_ffi = unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:67:68 [INFO] [stderr] | [INFO] [stderr] 67 | let v_ffi = unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:75:63 [INFO] [stderr] | [INFO] [stderr] 75 | let slice_ffi = unsafe { std::slice::from_raw_parts((*c).0, (*c).1) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:75:71 [INFO] [stderr] | [INFO] [stderr] 75 | let slice_ffi = unsafe { std::slice::from_raw_parts((*c).0, (*c).1) }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:103:50 [INFO] [stderr] | [INFO] [stderr] 103 | Ok(unsafe { std::slice::from_raw_parts((*c).0, (*c).1) }.to_vec()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:103:58 [INFO] [stderr] | [INFO] [stderr] 103 | Ok(unsafe { std::slice::from_raw_parts((*c).0, (*c).1) }.to_vec()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:100:43 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:100:59 [INFO] [stderr] | [INFO] [stderr] 100 | Ok(unsafe { Vec::from_raw_parts((*c).0, (*c).1, (*c).2) }) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:103:50 [INFO] [stderr] | [INFO] [stderr] 103 | Ok(unsafe { std::slice::from_raw_parts((*c).0, (*c).1) }.to_vec()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/main.rs:103:58 [INFO] [stderr] | [INFO] [stderr] 103 | Ok(unsafe { std::slice::from_raw_parts((*c).0, (*c).1) }.to_vec()) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 12 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ffi-trait-poc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 12 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ffi-trait-poc`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "98a9b7304186b3118302fd14643651aee5cb8ae42175fd4d3db87a1e5eb59e41"` [INFO] running `"docker" "rm" "-f" "98a9b7304186b3118302fd14643651aee5cb8ae42175fd4d3db87a1e5eb59e41"` [INFO] [stdout] 98a9b7304186b3118302fd14643651aee5cb8ae42175fd4d3db87a1e5eb59e41