[INFO] updating cached repository upsuper/sort-compare [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/upsuper/sort-compare [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/upsuper/sort-compare" "work/ex/clippy-test-run/sources/stable/gh/upsuper/sort-compare"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/upsuper/sort-compare'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/upsuper/sort-compare" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/sort-compare"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/sort-compare'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] eac0521f7043d01649532a0054e51f2071708c85 [INFO] sha for GitHub repo upsuper/sort-compare: eac0521f7043d01649532a0054e51f2071708c85 [INFO] validating manifest of upsuper/sort-compare on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of upsuper/sort-compare on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing upsuper/sort-compare [INFO] finished frobbing upsuper/sort-compare [INFO] frobbed toml for upsuper/sort-compare written to work/ex/clippy-test-run/sources/stable/gh/upsuper/sort-compare/Cargo.toml [INFO] started frobbing upsuper/sort-compare [INFO] finished frobbing upsuper/sort-compare [INFO] frobbed toml for upsuper/sort-compare written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/sort-compare/Cargo.toml [INFO] crate upsuper/sort-compare has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting upsuper/sort-compare against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/sort-compare:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07f873f92d3eefbaaa5b61ef7fc1fe1e4f6ccae2895982023fd5dcf41ad49507 [INFO] running `"docker" "start" "-a" "07f873f92d3eefbaaa5b61ef7fc1fe1e4f6ccae2895982023fd5dcf41ad49507"` [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking sort-compare v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_sort.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return fill_vacancy(heap, max_child, compare); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fill_vacancy(heap, max_child, compare)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_sort.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return fill_vacancy(heap, max_child, compare); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fill_vacancy(heap, max_child, compare)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "07f873f92d3eefbaaa5b61ef7fc1fe1e4f6ccae2895982023fd5dcf41ad49507"` [INFO] running `"docker" "rm" "-f" "07f873f92d3eefbaaa5b61ef7fc1fe1e4f6ccae2895982023fd5dcf41ad49507"` [INFO] [stdout] 07f873f92d3eefbaaa5b61ef7fc1fe1e4f6ccae2895982023fd5dcf41ad49507