[INFO] updating cached repository upsd/rusty-maths [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/upsd/rusty-maths [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/upsd/rusty-maths" "work/ex/clippy-test-run/sources/stable/gh/upsd/rusty-maths"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/upsd/rusty-maths'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/upsd/rusty-maths" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsd/rusty-maths"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsd/rusty-maths'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d8afe19cad6d7cf3c28e28b05d5e3deef93fd3f0 [INFO] sha for GitHub repo upsd/rusty-maths: d8afe19cad6d7cf3c28e28b05d5e3deef93fd3f0 [INFO] validating manifest of upsd/rusty-maths on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of upsd/rusty-maths on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing upsd/rusty-maths [INFO] finished frobbing upsd/rusty-maths [INFO] frobbed toml for upsd/rusty-maths written to work/ex/clippy-test-run/sources/stable/gh/upsd/rusty-maths/Cargo.toml [INFO] started frobbing upsd/rusty-maths [INFO] finished frobbing upsd/rusty-maths [INFO] frobbed toml for upsd/rusty-maths written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsd/rusty-maths/Cargo.toml [INFO] crate upsd/rusty-maths has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting upsd/rusty-maths against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsd/rusty-maths:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69ac6ada2e943601c1a74e4cd391f6c6137d44c4dba8a6cd3a4e9b9ce5caf3ea [INFO] running `"docker" "start" "-a" "69ac6ada2e943601c1a74e4cd391f6c6137d44c4dba8a6cd3a4e9b9ce5caf3ea"` [INFO] [stderr] Checking rusty_maths v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty_maths.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return x + y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x + y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty_maths.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return x * y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x * y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty_maths.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return x - y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x - y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty_maths.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return x / y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x / y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty_maths.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return x + y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x + y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty_maths.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return x * y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x * y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty_maths.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return x - y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x - y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rusty_maths.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return x / y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `x / y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | let added = rusty_maths::add(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:5:48 [INFO] [stderr] | [INFO] [stderr] 5 | let added = rusty_maths::add(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x+1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:6:48 [INFO] [stderr] | [INFO] [stderr] 6 | let subtracted = rusty_maths::subtract(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:6:58 [INFO] [stderr] | [INFO] [stderr] 6 | let subtracted = rusty_maths::subtract(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x+1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:7:48 [INFO] [stderr] | [INFO] [stderr] 7 | let multiplied = rusty_maths::multiply(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:7:58 [INFO] [stderr] | [INFO] [stderr] 7 | let multiplied = rusty_maths::multiply(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x+1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:8:43 [INFO] [stderr] | [INFO] [stderr] 8 | let divided = rusty_maths::divide(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:8:53 [INFO] [stderr] | [INFO] [stderr] 8 | let divided = rusty_maths::divide(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x+1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rusty_maths.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | assert_eq!(4.0, add(2.0, 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rusty_maths.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | assert_eq!(4.0, add(2.0, 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rusty_maths.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | assert_eq!(8.0, multiply(4.0, 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rusty_maths.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | assert_eq!(8.0, multiply(4.0, 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rusty_maths.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(8.0, subtract(10.0, 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rusty_maths.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | assert_eq!(8.0, subtract(10.0, 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/rusty_maths.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(50.0, divide(100.0, 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/rusty_maths.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | assert_eq!(50.0, divide(100.0, 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:5:38 [INFO] [stderr] | [INFO] [stderr] 5 | let added = rusty_maths::add(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:5:48 [INFO] [stderr] | [INFO] [stderr] 5 | let added = rusty_maths::add(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x+1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:6:48 [INFO] [stderr] | [INFO] [stderr] 6 | let subtracted = rusty_maths::subtract(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:6:58 [INFO] [stderr] | [INFO] [stderr] 6 | let subtracted = rusty_maths::subtract(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x+1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:7:48 [INFO] [stderr] | [INFO] [stderr] 7 | let multiplied = rusty_maths::multiply(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:7:58 [INFO] [stderr] | [INFO] [stderr] 7 | let multiplied = rusty_maths::multiply(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x+1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:8:43 [INFO] [stderr] | [INFO] [stderr] 8 | let divided = rusty_maths::divide(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:8:53 [INFO] [stderr] | [INFO] [stderr] 8 | let divided = rusty_maths::divide(x as f64, (x+1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x+1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_maths`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "69ac6ada2e943601c1a74e4cd391f6c6137d44c4dba8a6cd3a4e9b9ce5caf3ea"` [INFO] running `"docker" "rm" "-f" "69ac6ada2e943601c1a74e4cd391f6c6137d44c4dba8a6cd3a4e9b9ce5caf3ea"` [INFO] [stdout] 69ac6ada2e943601c1a74e4cd391f6c6137d44c4dba8a6cd3a4e9b9ce5caf3ea