[INFO] updating cached repository uhyo/rust-othello
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/uhyo/rust-othello
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/uhyo/rust-othello" "work/ex/clippy-test-run/sources/stable/gh/uhyo/rust-othello"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/uhyo/rust-othello'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/uhyo/rust-othello" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uhyo/rust-othello"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uhyo/rust-othello'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5fab77ccf254f79e53435fe45edb3ec4a09cc228
[INFO] sha for GitHub repo uhyo/rust-othello: 5fab77ccf254f79e53435fe45edb3ec4a09cc228
[INFO] validating manifest of uhyo/rust-othello on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of uhyo/rust-othello on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing uhyo/rust-othello
[INFO] finished frobbing uhyo/rust-othello
[INFO] frobbed toml for uhyo/rust-othello written to work/ex/clippy-test-run/sources/stable/gh/uhyo/rust-othello/Cargo.toml
[INFO] started frobbing uhyo/rust-othello
[INFO] finished frobbing uhyo/rust-othello
[INFO] frobbed toml for uhyo/rust-othello written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uhyo/rust-othello/Cargo.toml
[INFO] crate uhyo/rust-othello has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting uhyo/rust-othello against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uhyo/rust-othello:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 619b612dc519383b93935cee23f28f1732f91b6536523b77363426f58dd6d1bc
[INFO] running `"docker" "start" "-a" "619b612dc519383b93935cee23f28f1732f91b6536523b77363426f58dd6d1bc"`
[INFO] [stderr]     Checking lazy_static v0.2.8
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking thread_local v0.3.4
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr]     Checking env_logger v0.4.3
[INFO] [stderr]     Checking pretty_env_logger v0.1.1
[INFO] [stderr]     Checking othello v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/client.rs:220:13
[INFO] [stderr]     |
[INFO] [stderr] 220 |             return res;
[INFO] [stderr]     |             ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/board.rs:145:9
[INFO] [stderr]     |
[INFO] [stderr] 145 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/strategy.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return Move::Pass;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Move::Pass`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/strategy.rs:111:5
[INFO] [stderr]     |
[INFO] [stderr] 111 |     return false;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/client.rs:220:13
[INFO] [stderr]     |
[INFO] [stderr] 220 |             return res;
[INFO] [stderr]     |             ^^^^^^^^^^^ help: remove `return` as shown: `res`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/board.rs:145:9
[INFO] [stderr]     |
[INFO] [stderr] 145 |         return result;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/strategy.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         return Move::Pass;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Move::Pass`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/strategy.rs:111:5
[INFO] [stderr]     |
[INFO] [stderr] 111 |     return false;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options.rs:27:37
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let host = args.opt_str("host").unwrap_or(String::from("localhost"));
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("localhost"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options.rs:28:37
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let name = args.opt_str("name").unwrap_or(String::from("client"));
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("client"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options.rs:27:37
[INFO] [stderr]    |
[INFO] [stderr] 27 |     let host = args.opt_str("host").unwrap_or(String::from("localhost"));
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("localhost"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/options.rs:28:37
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let name = args.opt_str("name").unwrap_or(String::from("client"));
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("client"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/board.rs:71:34
[INFO] [stderr]    |
[INFO] [stderr] 71 |                     let mut cx = x as i32;
[INFO] [stderr]    |                                  ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/board.rs:72:34
[INFO] [stderr]    |
[INFO] [stderr] 72 |                     let mut cy = y as i32;
[INFO] [stderr]    |                                  ^^^^^^^^ help: try: `i32::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/board.rs:94:38
[INFO] [stderr]    |
[INFO] [stderr] 94 |                                 cx = x as i32;
[INFO] [stderr]    |                                      ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/board.rs:95:38
[INFO] [stderr]    |
[INFO] [stderr] 95 |                                 cy = y as i32;
[INFO] [stderr]    |                                      ^^^^^^^^ help: try: `i32::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `board::VecBoard`
[INFO] [stderr]    --> src/board.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     pub fn new() -> Self{
[INFO] [stderr] 157 | |         let mut board = Vec::new();
[INFO] [stderr] 158 | |         for i in 0 .. 64 {
[INFO] [stderr] 159 | |             if i == 27 || i == 36 {
[INFO] [stderr] ...   |
[INFO] [stderr] 171 | |         }
[INFO] [stderr] 172 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 155 | impl Default for board::VecBoard {
[INFO] [stderr] 156 |     fn default() -> Self {
[INFO] [stderr] 157 |         Self::new()
[INFO] [stderr] 158 |     }
[INFO] [stderr] 159 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `points` manually
[INFO] [stderr]   --> src/strategy.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 | /             let tmp = points[i];
[INFO] [stderr] 31 | |             points[i] = points[j];
[INFO] [stderr] 32 | |             points[j] = tmp;
[INFO] [stderr]    | |___________________________^ help: try: `points.swap(i, j)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/strategy.rs:45:35
[INFO] [stderr]    |
[INFO] [stderr] 45 |         while let Some(&(x, y)) = points.next() {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^ help: try: `for &(x, y) in points { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/board.rs:71:34
[INFO] [stderr]    |
[INFO] [stderr] 71 |                     let mut cx = x as i32;
[INFO] [stderr]    |                                  ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/board.rs:72:34
[INFO] [stderr]    |
[INFO] [stderr] 72 |                     let mut cy = y as i32;
[INFO] [stderr]    |                                  ^^^^^^^^ help: try: `i32::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/board.rs:94:38
[INFO] [stderr]    |
[INFO] [stderr] 94 |                                 cx = x as i32;
[INFO] [stderr]    |                                      ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/board.rs:95:38
[INFO] [stderr]    |
[INFO] [stderr] 95 |                                 cy = y as i32;
[INFO] [stderr]    |                                      ^^^^^^^^ help: try: `i32::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/strategy.rs:84:22
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let mut cx = x as i32;
[INFO] [stderr]    |                      ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/strategy.rs:85:22
[INFO] [stderr]    |
[INFO] [stderr] 85 |         let mut cy = y as i32;
[INFO] [stderr]    |                      ^^^^^^^^ help: try: `i32::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `board::VecBoard`
[INFO] [stderr]    --> src/board.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     pub fn new() -> Self{
[INFO] [stderr] 157 | |         let mut board = Vec::new();
[INFO] [stderr] 158 | |         for i in 0 .. 64 {
[INFO] [stderr] 159 | |             if i == 27 || i == 36 {
[INFO] [stderr] ...   |
[INFO] [stderr] 171 | |         }
[INFO] [stderr] 172 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 155 | impl Default for board::VecBoard {
[INFO] [stderr] 156 |     fn default() -> Self {
[INFO] [stderr] 157 |         Self::new()
[INFO] [stderr] 158 |     }
[INFO] [stderr] 159 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `points` manually
[INFO] [stderr]   --> src/strategy.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 | /             let tmp = points[i];
[INFO] [stderr] 31 | |             points[i] = points[j];
[INFO] [stderr] 32 | |             points[j] = tmp;
[INFO] [stderr]    | |___________________________^ help: try: `points.swap(i, j)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/strategy.rs:45:35
[INFO] [stderr]    |
[INFO] [stderr] 45 |         while let Some(&(x, y)) = points.next() {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^ help: try: `for &(x, y) in points { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/strategy.rs:84:22
[INFO] [stderr]    |
[INFO] [stderr] 84 |         let mut cx = x as i32;
[INFO] [stderr]    |                      ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/strategy.rs:85:22
[INFO] [stderr]    |
[INFO] [stderr] 85 |         let mut cy = y as i32;
[INFO] [stderr]    |                      ^^^^^^^^ help: try: `i32::from(y)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.15s
[INFO] running `"docker" "inspect" "619b612dc519383b93935cee23f28f1732f91b6536523b77363426f58dd6d1bc"`
[INFO] running `"docker" "rm" "-f" "619b612dc519383b93935cee23f28f1732f91b6536523b77363426f58dd6d1bc"`
[INFO] [stdout] 619b612dc519383b93935cee23f28f1732f91b6536523b77363426f58dd6d1bc