[INFO] updating cached repository ueokande/xcap [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ueokande/xcap [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ueokande/xcap" "work/ex/clippy-test-run/sources/stable/gh/ueokande/xcap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ueokande/xcap'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ueokande/xcap" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ueokande/xcap"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ueokande/xcap'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ff287e93cb0f7391ec94d4ebb202659610ed88f2 [INFO] sha for GitHub repo ueokande/xcap: ff287e93cb0f7391ec94d4ebb202659610ed88f2 [INFO] validating manifest of ueokande/xcap on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ueokande/xcap on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ueokande/xcap [INFO] finished frobbing ueokande/xcap [INFO] frobbed toml for ueokande/xcap written to work/ex/clippy-test-run/sources/stable/gh/ueokande/xcap/Cargo.toml [INFO] started frobbing ueokande/xcap [INFO] finished frobbing ueokande/xcap [INFO] frobbed toml for ueokande/xcap written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ueokande/xcap/Cargo.toml [INFO] crate ueokande/xcap has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ueokande/xcap against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ueokande/xcap:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4ba2950a3b77c8f8dd29938d45f35adaaa3b3efacba61f4e6fb1fd4178b9176b [INFO] running `"docker" "start" "-a" "4ba2950a3b77c8f8dd29938d45f35adaaa3b3efacba61f4e6fb1fd4178b9176b"` [INFO] [stderr] Checking xcap v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xwininfo.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | const FIELD_X: &'static str = "Absolute upper-left X:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xwininfo.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | const FIELD_X: &'static str = "Absolute upper-left X:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xwininfo.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | const FIELD_Y: &'static str = "Absolute upper-left Y:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xwininfo.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | const FIELD_WIDTH: &'static str = "Width:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xwininfo.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | const FIELD_HEIGHT: &'static str = "Height:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xwininfo.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / return Ok(WindowInfo { [INFO] [stderr] 93 | | x: x.unwrap(), [INFO] [stderr] 94 | | y: y.unwrap(), [INFO] [stderr] 95 | | width: w.unwrap(), [INFO] [stderr] 96 | | height: h.unwrap(), [INFO] [stderr] 97 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 92 | Ok(WindowInfo { [INFO] [stderr] 93 | x: x.unwrap(), [INFO] [stderr] 94 | y: y.unwrap(), [INFO] [stderr] 95 | width: w.unwrap(), [INFO] [stderr] 96 | height: h.unwrap(), [INFO] [stderr] 97 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xwininfo.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | const FIELD_Y: &'static str = "Absolute upper-left Y:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xwininfo.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | const FIELD_WIDTH: &'static str = "Width:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/xwininfo.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | const FIELD_HEIGHT: &'static str = "Height:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xwininfo.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / return Ok(WindowInfo { [INFO] [stderr] 93 | | x: x.unwrap(), [INFO] [stderr] 94 | | y: y.unwrap(), [INFO] [stderr] 95 | | width: w.unwrap(), [INFO] [stderr] 96 | | height: h.unwrap(), [INFO] [stderr] 97 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 92 | Ok(WindowInfo { [INFO] [stderr] 93 | x: x.unwrap(), [INFO] [stderr] 94 | y: y.unwrap(), [INFO] [stderr] 95 | width: w.unwrap(), [INFO] [stderr] 96 | height: h.unwrap(), [INFO] [stderr] 97 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/xwininfo.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | for line in source.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/xwininfo.rs:55:30 [INFO] [stderr] | [INFO] [stderr] 55 | for line in source.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `"docker" "inspect" "4ba2950a3b77c8f8dd29938d45f35adaaa3b3efacba61f4e6fb1fd4178b9176b"` [INFO] running `"docker" "rm" "-f" "4ba2950a3b77c8f8dd29938d45f35adaaa3b3efacba61f4e6fb1fd4178b9176b"` [INFO] [stdout] 4ba2950a3b77c8f8dd29938d45f35adaaa3b3efacba61f4e6fb1fd4178b9176b