[INFO] updating cached repository udtrokia/exc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/udtrokia/exc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/udtrokia/exc" "work/ex/clippy-test-run/sources/stable/gh/udtrokia/exc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/udtrokia/exc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/udtrokia/exc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udtrokia/exc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udtrokia/exc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a35462f362ef2ac8e590b1fd4280f630a20d3f3e [INFO] sha for GitHub repo udtrokia/exc: a35462f362ef2ac8e590b1fd4280f630a20d3f3e [INFO] validating manifest of udtrokia/exc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of udtrokia/exc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing udtrokia/exc [INFO] finished frobbing udtrokia/exc [INFO] frobbed toml for udtrokia/exc written to work/ex/clippy-test-run/sources/stable/gh/udtrokia/exc/Cargo.toml [INFO] started frobbing udtrokia/exc [INFO] finished frobbing udtrokia/exc [INFO] frobbed toml for udtrokia/exc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udtrokia/exc/Cargo.toml [INFO] crate udtrokia/exc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting udtrokia/exc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udtrokia/exc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 93805ac9a9eb4384ea1cfe326bd81f67a41468a1e4c33d42f370670fb5cdbb6d [INFO] running `"docker" "start" "-a" "93805ac9a9eb4384ea1cfe326bd81f67a41468a1e4c33d42f370670fb5cdbb6d"` [INFO] [stderr] Checking futures v0.1.23 [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking bytes v0.4.8 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking tokio-executor v0.1.2 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking tokio-timer v0.2.4 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking exc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/shared.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / return Shared { [INFO] [stderr] 17 | | peers: HashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Shared { [INFO] [stderr] 17 | peers: HashMap::new(), [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/shared.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / return Shared { [INFO] [stderr] 17 | | peers: HashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 16 | Shared { [INFO] [stderr] 17 | peers: HashMap::new(), [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `shared::Shared` [INFO] [stderr] --> src/shared.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | return Shared { [INFO] [stderr] 17 | | peers: HashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `shared::Shared` [INFO] [stderr] --> src/shared.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | return Shared { [INFO] [stderr] 17 | | peers: HashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.16s [INFO] running `"docker" "inspect" "93805ac9a9eb4384ea1cfe326bd81f67a41468a1e4c33d42f370670fb5cdbb6d"` [INFO] running `"docker" "rm" "-f" "93805ac9a9eb4384ea1cfe326bd81f67a41468a1e4c33d42f370670fb5cdbb6d"` [INFO] [stdout] 93805ac9a9eb4384ea1cfe326bd81f67a41468a1e4c33d42f370670fb5cdbb6d