[INFO] updating cached repository u238/traits_exercise [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/u238/traits_exercise [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/u238/traits_exercise" "work/ex/clippy-test-run/sources/stable/gh/u238/traits_exercise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/u238/traits_exercise'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/u238/traits_exercise" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/u238/traits_exercise"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/u238/traits_exercise'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b4d2ec668ba73d8123a0538c766117dbe9238423 [INFO] sha for GitHub repo u238/traits_exercise: b4d2ec668ba73d8123a0538c766117dbe9238423 [INFO] validating manifest of u238/traits_exercise on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of u238/traits_exercise on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing u238/traits_exercise [INFO] finished frobbing u238/traits_exercise [INFO] frobbed toml for u238/traits_exercise written to work/ex/clippy-test-run/sources/stable/gh/u238/traits_exercise/Cargo.toml [INFO] started frobbing u238/traits_exercise [INFO] finished frobbing u238/traits_exercise [INFO] frobbed toml for u238/traits_exercise written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/u238/traits_exercise/Cargo.toml [INFO] crate u238/traits_exercise has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting u238/traits_exercise against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/u238/traits_exercise:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a49432344358db22174ea86f3262c4fcf65ee47c017d243affd7172c96764ee [INFO] running `"docker" "start" "-a" "3a49432344358db22174ea86f3262c4fcf65ee47c017d243affd7172c96764ee"` [INFO] [stderr] Checking traits_exercise v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | for _ in 0..1000000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | for _ in 0..1000000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/main.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | children: Box> [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Some(ref node) => { 1 + node.tail.length() } [INFO] [stderr] 37 | | &None => 0 [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Some(ref node) => { 1 + node.tail.length() } [INFO] [stderr] 37 | None => 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | a = a + 6; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `a += 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &Some(ref node) => { [INFO] [stderr] 88 | | [INFO] [stderr] 89 | | let mut buf = String::new(); [INFO] [stderr] ... | [INFO] [stderr] 94 | | &None => "()".to_owned() [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | Some(ref node) => { [INFO] [stderr] 88 | [INFO] [stderr] 89 | let mut buf = String::new(); [INFO] [stderr] 90 | buf += &format!("[ {}, {} ]", node.val, node.tail.to_string()); [INFO] [stderr] 91 | buf [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match self { [INFO] [stderr] 102 | | &Some(ref node) => { [INFO] [stderr] 103 | | let mut buf = String::new(); [INFO] [stderr] 104 | | buf += &format!("[ {}, ", node.val); [INFO] [stderr] ... | [INFO] [stderr] 118 | | &None => "()".to_owned() [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *self { [INFO] [stderr] 102 | Some(ref node) => { [INFO] [stderr] 103 | let mut buf = String::new(); [INFO] [stderr] 104 | buf += &format!("[ {}, ", node.val); [INFO] [stderr] 105 | for c in node.children.iter() { [INFO] [stderr] 106 | match c { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | / match c { [INFO] [stderr] 107 | | &Some(ref _node) => { [INFO] [stderr] 108 | | //let mut buf = String::new(); [INFO] [stderr] 109 | | // buf += node.to_string() [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 106 | match *c { [INFO] [stderr] 107 | Some(ref _node) => { [INFO] [stderr] 108 | //let mut buf = String::new(); [INFO] [stderr] 109 | // buf += node.to_string() [INFO] [stderr] 110 | } [INFO] [stderr] 111 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | for _ in 0..1000000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | for _ in 0..1000000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/main.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | children: Box> [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self { [INFO] [stderr] 36 | | &Some(ref node) => { 1 + node.tail.length() } [INFO] [stderr] 37 | | &None => 0 [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 35 | match *self { [INFO] [stderr] 36 | Some(ref node) => { 1 + node.tail.length() } [INFO] [stderr] 37 | None => 0 [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | a = a + 6; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `a += 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &Some(ref node) => { [INFO] [stderr] 88 | | [INFO] [stderr] 89 | | let mut buf = String::new(); [INFO] [stderr] ... | [INFO] [stderr] 94 | | &None => "()".to_owned() [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | Some(ref node) => { [INFO] [stderr] 88 | [INFO] [stderr] 89 | let mut buf = String::new(); [INFO] [stderr] 90 | buf += &format!("[ {}, {} ]", node.val, node.tail.to_string()); [INFO] [stderr] 91 | buf [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | / match self { [INFO] [stderr] 102 | | &Some(ref node) => { [INFO] [stderr] 103 | | let mut buf = String::new(); [INFO] [stderr] 104 | | buf += &format!("[ {}, ", node.val); [INFO] [stderr] ... | [INFO] [stderr] 118 | | &None => "()".to_owned() [INFO] [stderr] 119 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 101 | match *self { [INFO] [stderr] 102 | Some(ref node) => { [INFO] [stderr] 103 | let mut buf = String::new(); [INFO] [stderr] 104 | buf += &format!("[ {}, ", node.val); [INFO] [stderr] 105 | for c in node.children.iter() { [INFO] [stderr] 106 | match c { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | / match c { [INFO] [stderr] 107 | | &Some(ref _node) => { [INFO] [stderr] 108 | | //let mut buf = String::new(); [INFO] [stderr] 109 | | // buf += node.to_string() [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 106 | match *c { [INFO] [stderr] 107 | Some(ref _node) => { [INFO] [stderr] 108 | //let mut buf = String::new(); [INFO] [stderr] 109 | // buf += node.to_string() [INFO] [stderr] 110 | } [INFO] [stderr] 111 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "3a49432344358db22174ea86f3262c4fcf65ee47c017d243affd7172c96764ee"` [INFO] running `"docker" "rm" "-f" "3a49432344358db22174ea86f3262c4fcf65ee47c017d243affd7172c96764ee"` [INFO] [stdout] 3a49432344358db22174ea86f3262c4fcf65ee47c017d243affd7172c96764ee