[INFO] updating cached repository tylerreisinger/rust-raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tylerreisinger/rust-raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tylerreisinger/rust-raytracer" "work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/rust-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/rust-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tylerreisinger/rust-raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/rust-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/rust-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 38bcf36c8789f646e77183c4b471e951ebcdb99f [INFO] sha for GitHub repo tylerreisinger/rust-raytracer: 38bcf36c8789f646e77183c4b471e951ebcdb99f [INFO] validating manifest of tylerreisinger/rust-raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tylerreisinger/rust-raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tylerreisinger/rust-raytracer [INFO] finished frobbing tylerreisinger/rust-raytracer [INFO] frobbed toml for tylerreisinger/rust-raytracer written to work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/rust-raytracer/Cargo.toml [INFO] started frobbing tylerreisinger/rust-raytracer [INFO] finished frobbing tylerreisinger/rust-raytracer [INFO] frobbed toml for tylerreisinger/rust-raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/rust-raytracer/Cargo.toml [INFO] crate tylerreisinger/rust-raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tylerreisinger/rust-raytracer against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/rust-raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 71c5a3d5928980594d428d691d67354dfc0ce76f0e4540b2406641634f768d0f [INFO] running `"docker" "start" "-a" "71c5a3d5928980594d428d691d67354dfc0ce76f0e4540b2406641634f768d0f"` [INFO] [stderr] Checking adler32 v1.0.0 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking inflate v0.1.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking scoped_threadpool v0.1.7 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking num_cpus v1.3.0 [INFO] [stderr] Checking num-integer v0.1.32 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking num-complex v0.1.35 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking cgmath v0.12.0 [INFO] [stderr] Checking deflate v0.7.5 [INFO] [stderr] Checking gif v0.9.1 [INFO] [stderr] Checking num-iter v0.1.32 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | px_wide: px_wide, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `px_wide` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | px_high: px_high, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `px_high` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | screen: screen, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `screen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/sphere.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/sphere.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | px_wide: px_wide, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `px_wide` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | px_high: px_high, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `px_high` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | screen: screen, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `screen` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ray.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/sphere.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geom/sphere.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | camera: camera, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/geom/sphere.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | let b = 2.0 * ray.direction().dot((ray.origin() - self.origin())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/geom/sphere.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | let b = 2.0 * ray.direction().dot((ray.origin() - self.origin())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `geom::*` [INFO] [stderr] --> src/geom/sphere.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | use geom::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geom/sphere.rs:90:43 [INFO] [stderr] | [INFO] [stderr] 90 | assert_relative_eq!(Vector3::new(-1.627219318, 0.0, 15.272193184), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `1.627_219_318` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/geom/sphere.rs:90:61 [INFO] [stderr] | [INFO] [stderr] 90 | assert_relative_eq!(Vector3::new(-1.627219318, 0.0, 15.272193184), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `15.272_193_184` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/geom/sphere.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | let b = 2.0 * ray.direction().dot((ray.origin() - self.origin())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/geom/sphere.rs:34:43 [INFO] [stderr] | [INFO] [stderr] 34 | let b = 2.0 * ray.direction().dot((ray.origin() - self.origin())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `scene::Scene` [INFO] [stderr] --> src/scene.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Scene { [INFO] [stderr] 13 | | Scene { [INFO] [stderr] 14 | | geom: Vec::new(), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `scene::Scene` [INFO] [stderr] --> src/scene.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Scene { [INFO] [stderr] 13 | | Scene { [INFO] [stderr] 14 | | geom: Vec::new(), [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.21s [INFO] running `"docker" "inspect" "71c5a3d5928980594d428d691d67354dfc0ce76f0e4540b2406641634f768d0f"` [INFO] running `"docker" "rm" "-f" "71c5a3d5928980594d428d691d67354dfc0ce76f0e4540b2406641634f768d0f"` [INFO] [stdout] 71c5a3d5928980594d428d691d67354dfc0ce76f0e4540b2406641634f768d0f