[INFO] updating cached repository tylerreisinger/neural-network-deep-learning
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tylerreisinger/neural-network-deep-learning
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tylerreisinger/neural-network-deep-learning" "work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/neural-network-deep-learning"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/neural-network-deep-learning'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tylerreisinger/neural-network-deep-learning" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/neural-network-deep-learning"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/neural-network-deep-learning'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e9b993dc16ba212952631e2fa08a1b63ac1c99fb
[INFO] sha for GitHub repo tylerreisinger/neural-network-deep-learning: e9b993dc16ba212952631e2fa08a1b63ac1c99fb
[INFO] validating manifest of tylerreisinger/neural-network-deep-learning on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tylerreisinger/neural-network-deep-learning on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tylerreisinger/neural-network-deep-learning
[INFO] finished frobbing tylerreisinger/neural-network-deep-learning
[INFO] frobbed toml for tylerreisinger/neural-network-deep-learning written to work/ex/clippy-test-run/sources/stable/gh/tylerreisinger/neural-network-deep-learning/Cargo.toml
[INFO] started frobbing tylerreisinger/neural-network-deep-learning
[INFO] finished frobbing tylerreisinger/neural-network-deep-learning
[INFO] frobbed toml for tylerreisinger/neural-network-deep-learning written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/neural-network-deep-learning/Cargo.toml
[INFO] crate tylerreisinger/neural-network-deep-learning has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tylerreisinger/neural-network-deep-learning against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tylerreisinger/neural-network-deep-learning:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 05777c2a7cc5236a02c7cac9804cbd7c7e1e80dfb2f581c93611298de35b9e13
[INFO] running `"docker" "start" "-a" "05777c2a7cc5236a02c7cac9804cbd7c7e1e80dfb2f581c93611298de35b9e13"`
[INFO] [stderr]     Checking neural_net v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:159:17
[INFO] [stderr]     |
[INFO] [stderr] 159 |                 reader: reader,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:160:17
[INFO] [stderr]     |
[INFO] [stderr] 160 |                 header: header,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:173:17
[INFO] [stderr]     |
[INFO] [stderr] 173 |                 reader: reader,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:174:17
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 header: header,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:240:17
[INFO] [stderr]     |
[INFO] [stderr] 240 |                 elems: elems,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `elems`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/net/geom.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             num_neurons: num_neurons,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_neurons`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:159:17
[INFO] [stderr]     |
[INFO] [stderr] 159 |                 reader: reader,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:160:17
[INFO] [stderr]     |
[INFO] [stderr] 160 |                 header: header,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:173:17
[INFO] [stderr]     |
[INFO] [stderr] 173 |                 reader: reader,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:174:17
[INFO] [stderr]     |
[INFO] [stderr] 174 |                 header: header,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/mnist/idx.rs:240:17
[INFO] [stderr]     |
[INFO] [stderr] 240 |                 elems: elems,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `elems`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/net/geom.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             num_neurons: num_neurons,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_neurons`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/mnist/idx.rs:262:9
[INFO] [stderr]     |
[INFO] [stderr] 262 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/mnist/idx.rs:292:9
[INFO] [stderr]     |
[INFO] [stderr] 292 |         element
[INFO] [stderr]     |         ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/mnist/idx.rs:290:23
[INFO] [stderr]     |
[INFO] [stderr] 290 |         let element = T::read_element::<BigEndian, _>(&mut self.reader);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::*`
[INFO] [stderr]    --> src/mnist/idx.rs:402:9
[INFO] [stderr]     |
[INFO] [stderr] 402 |     use super::*;
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/mnist/idx.rs:262:9
[INFO] [stderr]     |
[INFO] [stderr] 262 |         return Ok(());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/mnist/idx.rs:292:9
[INFO] [stderr]     |
[INFO] [stderr] 292 |         element
[INFO] [stderr]     |         ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/mnist/idx.rs:290:23
[INFO] [stderr]     |
[INFO] [stderr] 290 |         let element = T::read_element::<BigEndian, _>(&mut self.reader);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `labels`
[INFO] [stderr]   --> src/main.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let labels = 
[INFO] [stderr]    |         ^^^^^^ help: consider using `_labels` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `images`
[INFO] [stderr]   --> src/main.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let images = 
[INFO] [stderr]    |         ^^^^^^ help: consider using `_images` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `labels`
[INFO] [stderr]   --> src/main.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let labels = 
[INFO] [stderr]    |         ^^^^^^ help: consider using `_labels` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `images`
[INFO] [stderr]   --> src/main.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let images = 
[INFO] [stderr]    |         ^^^^^^ help: consider using `_images` instead
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `dim_sizes`.
[INFO] [stderr]    --> src/mnist/idx.rs:307:18
[INFO] [stderr]     |
[INFO] [stderr] 307 |         for i in 0..dim_sizes.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 307 |         for <item> in &mut dim_sizes {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/mnist/idx.rs:356:12
[INFO] [stderr]     |
[INFO] [stderr] 356 |         if self.dimension_sizes.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.dimension_sizes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/net/geom.rs:12:26
[INFO] [stderr]    |
[INFO] [stderr] 12 |             layers.iter().fold(0, |sum, &x| sum + x);
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `dim_sizes`.
[INFO] [stderr]    --> src/mnist/idx.rs:307:18
[INFO] [stderr]     |
[INFO] [stderr] 307 |         for i in 0..dim_sizes.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 307 |         for <item> in &mut dim_sizes {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/mnist/idx.rs:356:12
[INFO] [stderr]     |
[INFO] [stderr] 356 |         if self.dimension_sizes.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.dimension_sizes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/net/geom.rs:12:26
[INFO] [stderr]    |
[INFO] [stderr] 12 |             layers.iter().fold(0, |sum, &x| sum + x);
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.89s
[INFO] running `"docker" "inspect" "05777c2a7cc5236a02c7cac9804cbd7c7e1e80dfb2f581c93611298de35b9e13"`
[INFO] running `"docker" "rm" "-f" "05777c2a7cc5236a02c7cac9804cbd7c7e1e80dfb2f581c93611298de35b9e13"`
[INFO] [stdout] 05777c2a7cc5236a02c7cac9804cbd7c7e1e80dfb2f581c93611298de35b9e13