[INFO] updating cached repository twking7/nes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/twking7/nes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/twking7/nes" "work/ex/clippy-test-run/sources/stable/gh/twking7/nes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/twking7/nes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/twking7/nes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twking7/nes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twking7/nes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 041a09ade125a25ce6f00747ced464a197b8a698 [INFO] sha for GitHub repo twking7/nes: 041a09ade125a25ce6f00747ced464a197b8a698 [INFO] validating manifest of twking7/nes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of twking7/nes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing twking7/nes [INFO] finished frobbing twking7/nes [INFO] frobbed toml for twking7/nes written to work/ex/clippy-test-run/sources/stable/gh/twking7/nes/Cargo.toml [INFO] started frobbing twking7/nes [INFO] finished frobbing twking7/nes [INFO] frobbed toml for twking7/nes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twking7/nes/Cargo.toml [INFO] crate twking7/nes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting twking7/nes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/twking7/nes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f919aef74e5ffbe4aa1f960dae59424c79f7dba5f207b561afaf0efc12ad7f2b [INFO] running `"docker" "start" "-a" "f919aef74e5ffbe4aa1f960dae59424c79f7dba5f207b561afaf0efc12ad7f2b"` [INFO] [stderr] Checking nes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:678:25 [INFO] [stderr] | [INFO] [stderr] 678 | cpu.set_s_and_z(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:810:22 [INFO] [stderr] | [INFO] [stderr] 810 | cpu.status = 0b11100011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:814:35 [INFO] [stderr] | [INFO] [stderr] 814 | assert_eq!(cpu.pop_one(), 0b11100011, "saved status"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:823:22 [INFO] [stderr] | [INFO] [stderr] 823 | cpu.status = 0b11110011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:827:35 [INFO] [stderr] | [INFO] [stderr] 827 | assert_eq!(cpu.pop_one(), 0b11100011, "saved status"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:837:22 [INFO] [stderr] | [INFO] [stderr] 837 | cpu.status = 0b00110100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:841:32 [INFO] [stderr] | [INFO] [stderr] 841 | assert_eq!(cpu.status, 0b00110100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:897:32 [INFO] [stderr] | [INFO] [stderr] 897 | let expecteds = vec![((0b11001100, 0b00110011), (0, false, true)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:897:44 [INFO] [stderr] | [INFO] [stderr] 897 | let expecteds = vec![((0b11001100, 0b00110011), (0, false, true)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:898:32 [INFO] [stderr] | [INFO] [stderr] 898 | ((0b11001100, 0b10110011), (128, true, false))]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:898:44 [INFO] [stderr] | [INFO] [stderr] 898 | ((0b11001100, 0b10110011), (128, true, false))]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1010:22 [INFO] [stderr] | [INFO] [stderr] 1010 | cpu.status = 0b11000011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1014:35 [INFO] [stderr] | [INFO] [stderr] 1014 | assert_eq!(cpu.pop_one(), 0b11010011, "saved status"); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1101_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1114:19 [INFO] [stderr] | [INFO] [stderr] 1114 | cpu.acc = 0b11001100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1115:17 [INFO] [stderr] | [INFO] [stderr] 1115 | cpu.eor(0b11000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1116:29 [INFO] [stderr] | [INFO] [stderr] 1116 | assert_eq!(cpu.acc, 0b00001100); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Absolute` [INFO] [stderr] --> src/cpu/opcodes.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Absolute, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AbsoluteX` [INFO] [stderr] --> src/cpu/opcodes.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | AbsoluteX, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AbsoluteY` [INFO] [stderr] --> src/cpu/opcodes.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | AbsoluteY, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Accumulator` [INFO] [stderr] --> src/cpu/opcodes.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Accumulator, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Immediate` [INFO] [stderr] --> src/cpu/opcodes.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Immediate, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Implied` [INFO] [stderr] --> src/cpu/opcodes.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Implied, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Indirect` [INFO] [stderr] --> src/cpu/opcodes.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Indirect, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `IndirectX` [INFO] [stderr] --> src/cpu/opcodes.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | IndirectX, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `IndirectY` [INFO] [stderr] --> src/cpu/opcodes.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | IndirectY, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Relative` [INFO] [stderr] --> src/cpu/opcodes.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Relative, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ZeroPage` [INFO] [stderr] --> src/cpu/opcodes.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | ZeroPage, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ZeroPageX` [INFO] [stderr] --> src/cpu/opcodes.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | ZeroPageX, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ZeroPageY` [INFO] [stderr] --> src/cpu/opcodes.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | ZeroPageY, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Name` [INFO] [stderr] --> src/cpu/opcodes.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | pub enum Name { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Opcode` [INFO] [stderr] --> src/cpu/opcodes.rs:93:1 [INFO] [stderr] | [INFO] [stderr] 93 | pub struct Opcode { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_by_code` [INFO] [stderr] --> src/cpu/opcodes.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn get_by_code(code: u8) -> Option<&'a Opcode> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `OPCODES` [INFO] [stderr] --> src/cpu/opcodes.rs:107:1 [INFO] [stderr] | [INFO] [stderr] 107 | / static OPCODES: [Opcode; 151] = [Opcode { [INFO] [stderr] 108 | | code: 0x00, [INFO] [stderr] 109 | | name: Name::BRK, [INFO] [stderr] 110 | | mode: Mode::Implied, [INFO] [stderr] ... | [INFO] [stderr] 1011 | | bytes: 3, [INFO] [stderr] 1012 | | }]; [INFO] [stderr] | |____________________________________^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `NMI_VECTOR` [INFO] [stderr] --> src/cpu/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const NMI_VECTOR: u16 = 0xFFFA; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RESET_VECTOR` [INFO] [stderr] --> src/cpu/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const RESET_VECTOR: u16 = 0xFFFC; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `IRQ_VECTOR` [INFO] [stderr] --> src/cpu/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const IRQ_VECTOR: u16 = 0xFFFE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MEMORY_SIZE` [INFO] [stderr] --> src/cpu/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const MEMORY_SIZE: usize = 65_536; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Accumulator` [INFO] [stderr] --> src/cpu/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Accumulator, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Value` [INFO] [stderr] --> src/cpu/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Value(u8), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Address` [INFO] [stderr] --> src/cpu/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Address(u16), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Status` [INFO] [stderr] --> src/cpu/mod.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | enum Status { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `CPU` [INFO] [stderr] --> src/cpu/mod.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | struct CPU { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cpu/mod.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/cpu/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | pub fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `irq` [INFO] [stderr] --> src/cpu/mod.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn irq(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `nmi` [INFO] [stderr] --> src/cpu/mod.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn nmi(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `load_ram` [INFO] [stderr] --> src/cpu/mod.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn load_ram(&mut self, mem: Vec, offset: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `execute` [INFO] [stderr] --> src/cpu/mod.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn execute(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tick` [INFO] [stderr] --> src/cpu/mod.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn tick(&mut self, opcode: &Opcode) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `adc` [INFO] [stderr] --> src/cpu/mod.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | fn adc(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `and` [INFO] [stderr] --> src/cpu/mod.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | fn and(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `asl` [INFO] [stderr] --> src/cpu/mod.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | fn asl(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bcc` [INFO] [stderr] --> src/cpu/mod.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | fn bcc(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bcs` [INFO] [stderr] --> src/cpu/mod.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | fn bcs(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `beq` [INFO] [stderr] --> src/cpu/mod.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | fn beq(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bit` [INFO] [stderr] --> src/cpu/mod.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | fn bit(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bmi` [INFO] [stderr] --> src/cpu/mod.rs:259:5 [INFO] [stderr] | [INFO] [stderr] 259 | fn bmi(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bne` [INFO] [stderr] --> src/cpu/mod.rs:265:5 [INFO] [stderr] | [INFO] [stderr] 265 | fn bne(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bpl` [INFO] [stderr] --> src/cpu/mod.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | fn bpl(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `brk` [INFO] [stderr] --> src/cpu/mod.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | fn brk(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bvc` [INFO] [stderr] --> src/cpu/mod.rs:290:5 [INFO] [stderr] | [INFO] [stderr] 290 | fn bvc(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `bvs` [INFO] [stderr] --> src/cpu/mod.rs:296:5 [INFO] [stderr] | [INFO] [stderr] 296 | fn bvs(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clc` [INFO] [stderr] --> src/cpu/mod.rs:302:5 [INFO] [stderr] | [INFO] [stderr] 302 | fn clc(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cld` [INFO] [stderr] --> src/cpu/mod.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | fn cld(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cli` [INFO] [stderr] --> src/cpu/mod.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | fn cli(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `clv` [INFO] [stderr] --> src/cpu/mod.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | fn clv(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cmp` [INFO] [stderr] --> src/cpu/mod.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | fn cmp(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cpx` [INFO] [stderr] --> src/cpu/mod.rs:324:5 [INFO] [stderr] | [INFO] [stderr] 324 | fn cpx(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cpy` [INFO] [stderr] --> src/cpu/mod.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | fn cpy(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dec` [INFO] [stderr] --> src/cpu/mod.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | fn dec(&mut self, addr: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dex` [INFO] [stderr] --> src/cpu/mod.rs:342:5 [INFO] [stderr] | [INFO] [stderr] 342 | fn dex(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dey` [INFO] [stderr] --> src/cpu/mod.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | fn dey(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `eor` [INFO] [stderr] --> src/cpu/mod.rs:354:5 [INFO] [stderr] | [INFO] [stderr] 354 | fn eor(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inc` [INFO] [stderr] --> src/cpu/mod.rs:360:5 [INFO] [stderr] | [INFO] [stderr] 360 | fn inc(&mut self, addr: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `inx` [INFO] [stderr] --> src/cpu/mod.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | fn inx(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `iny` [INFO] [stderr] --> src/cpu/mod.rs:372:5 [INFO] [stderr] | [INFO] [stderr] 372 | fn iny(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `jmp` [INFO] [stderr] --> src/cpu/mod.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | fn jmp(&mut self, addr: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `jsr` [INFO] [stderr] --> src/cpu/mod.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | fn jsr(&mut self, addr: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `lda` [INFO] [stderr] --> src/cpu/mod.rs:388:5 [INFO] [stderr] | [INFO] [stderr] 388 | fn lda(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ldx` [INFO] [stderr] --> src/cpu/mod.rs:393:5 [INFO] [stderr] | [INFO] [stderr] 393 | fn ldx(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ldy` [INFO] [stderr] --> src/cpu/mod.rs:398:5 [INFO] [stderr] | [INFO] [stderr] 398 | fn ldy(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `lsr` [INFO] [stderr] --> src/cpu/mod.rs:403:5 [INFO] [stderr] | [INFO] [stderr] 403 | fn lsr(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ora` [INFO] [stderr] --> src/cpu/mod.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | fn ora(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pha` [INFO] [stderr] --> src/cpu/mod.rs:417:5 [INFO] [stderr] | [INFO] [stderr] 417 | fn pha(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `php` [INFO] [stderr] --> src/cpu/mod.rs:422:5 [INFO] [stderr] | [INFO] [stderr] 422 | fn php(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pla` [INFO] [stderr] --> src/cpu/mod.rs:427:5 [INFO] [stderr] | [INFO] [stderr] 427 | fn pla(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `plp` [INFO] [stderr] --> src/cpu/mod.rs:434:5 [INFO] [stderr] | [INFO] [stderr] 434 | fn plp(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rol` [INFO] [stderr] --> src/cpu/mod.rs:438:5 [INFO] [stderr] | [INFO] [stderr] 438 | fn rol(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ror` [INFO] [stderr] --> src/cpu/mod.rs:449:5 [INFO] [stderr] | [INFO] [stderr] 449 | fn ror(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rti` [INFO] [stderr] --> src/cpu/mod.rs:460:5 [INFO] [stderr] | [INFO] [stderr] 460 | fn rti(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `rts` [INFO] [stderr] --> src/cpu/mod.rs:465:5 [INFO] [stderr] | [INFO] [stderr] 465 | fn rts(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1209:27 [INFO] [stderr] | [INFO] [stderr] 1209 | cpu.load_ram(vec![0b10000001], 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1211:37 [INFO] [stderr] | [INFO] [stderr] 1211 | assert_eq!(cpu.read_one(0), 0b01000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sbc` [INFO] [stderr] --> src/cpu/mod.rs:469:5 [INFO] [stderr] | [INFO] [stderr] 469 | fn sbc(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1220:19 [INFO] [stderr] | [INFO] [stderr] 1220 | cpu.acc = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1221:17 [INFO] [stderr] | [INFO] [stderr] 1221 | cpu.ora(0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1222:29 [INFO] [stderr] | [INFO] [stderr] 1222 | assert_eq!(cpu.acc, 0b11000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sec` [INFO] [stderr] --> src/cpu/mod.rs:477:5 [INFO] [stderr] | [INFO] [stderr] 477 | fn sec(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sed` [INFO] [stderr] --> src/cpu/mod.rs:481:5 [INFO] [stderr] | [INFO] [stderr] 481 | fn sed(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1239:22 [INFO] [stderr] | [INFO] [stderr] 1239 | cpu.status = 0b00100011; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0011` [INFO] [stderr] | [INFO] [stderr] warning: method is never used: `sei` [INFO] [stderr] --> src/cpu/mod.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | fn sei(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sta` [INFO] [stderr] --> src/cpu/mod.rs:489:5 [INFO] [stderr] | [INFO] [stderr] 489 | fn sta(&mut self, addr: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `stx` [INFO] [stderr] --> src/cpu/mod.rs:494:5 [INFO] [stderr] | [INFO] [stderr] 494 | fn stx(&mut self, addr: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `sty` [INFO] [stderr] --> src/cpu/mod.rs:499:5 [INFO] [stderr] | [INFO] [stderr] 499 | fn sty(&mut self, addr: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1242:36 [INFO] [stderr] | [INFO] [stderr] 1242 | assert_eq!(cpu.mem[0x1FF], 0b00110011); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tax` [INFO] [stderr] --> src/cpu/mod.rs:504:5 [INFO] [stderr] | [INFO] [stderr] 504 | fn tax(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tay` [INFO] [stderr] --> src/cpu/mod.rs:510:5 [INFO] [stderr] | [INFO] [stderr] 510 | fn tay(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1249:26 [INFO] [stderr] | [INFO] [stderr] 1249 | cpu.mem[0x1FF] = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tsx` [INFO] [stderr] --> src/cpu/mod.rs:516:5 [INFO] [stderr] | [INFO] [stderr] 516 | fn tsx(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1252:29 [INFO] [stderr] | [INFO] [stderr] 1252 | assert_eq!(cpu.acc, 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `txa` [INFO] [stderr] --> src/cpu/mod.rs:522:5 [INFO] [stderr] | [INFO] [stderr] 522 | fn txa(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `txs` [INFO] [stderr] --> src/cpu/mod.rs:528:5 [INFO] [stderr] | [INFO] [stderr] 528 | fn txs(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tya` [INFO] [stderr] --> src/cpu/mod.rs:532:5 [INFO] [stderr] | [INFO] [stderr] 532 | fn tya(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_operand` [INFO] [stderr] --> src/cpu/mod.rs:538:5 [INFO] [stderr] | [INFO] [stderr] 538 | fn set_operand(&mut self, operand: &Operand, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `operand_for_mode` [INFO] [stderr] --> src/cpu/mod.rs:548:5 [INFO] [stderr] | [INFO] [stderr] 548 | fn operand_for_mode(&self, mode: Mode) -> Operand { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `value_for_operand` [INFO] [stderr] --> src/cpu/mod.rs:571:5 [INFO] [stderr] | [INFO] [stderr] 571 | fn value_for_operand(&self, operand: &Operand) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `addr_for_operand` [INFO] [stderr] --> src/cpu/mod.rs:579:5 [INFO] [stderr] | [INFO] [stderr] 579 | fn addr_for_operand(&self, operand: &Operand) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_one` [INFO] [stderr] --> src/cpu/mod.rs:587:5 [INFO] [stderr] | [INFO] [stderr] 587 | fn read_one(&self, addr: u16) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `read_two` [INFO] [stderr] --> src/cpu/mod.rs:591:5 [INFO] [stderr] | [INFO] [stderr] 591 | fn read_two(&self, addr: u16) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write_one` [INFO] [stderr] --> src/cpu/mod.rs:597:5 [INFO] [stderr] | [INFO] [stderr] 597 | fn write_one(&mut self, addr: u16, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_status` [INFO] [stderr] --> src/cpu/mod.rs:601:5 [INFO] [stderr] | [INFO] [stderr] 601 | fn get_status(&self, s: Status) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_status` [INFO] [stderr] --> src/cpu/mod.rs:605:5 [INFO] [stderr] | [INFO] [stderr] 605 | fn set_status(&mut self, s: Status, val: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_s_and_z` [INFO] [stderr] --> src/cpu/mod.rs:612:5 [INFO] [stderr] | [INFO] [stderr] 612 | fn set_s_and_z(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `jump` [INFO] [stderr] --> src/cpu/mod.rs:617:5 [INFO] [stderr] | [INFO] [stderr] 617 | fn jump(&mut self, offset: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_two` [INFO] [stderr] --> src/cpu/mod.rs:625:5 [INFO] [stderr] | [INFO] [stderr] 625 | fn push_two(&mut self, val: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `push_one` [INFO] [stderr] --> src/cpu/mod.rs:630:5 [INFO] [stderr] | [INFO] [stderr] 630 | fn push_one(&mut self, val: u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pop_two` [INFO] [stderr] --> src/cpu/mod.rs:636:5 [INFO] [stderr] | [INFO] [stderr] 636 | fn pop_two(&mut self) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pop_one` [INFO] [stderr] --> src/cpu/mod.rs:642:5 [INFO] [stderr] | [INFO] [stderr] 642 | fn pop_one(&mut self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `debug` [INFO] [stderr] --> src/cpu/mod.rs:648:5 [INFO] [stderr] | [INFO] [stderr] 648 | fn debug(&self, opcode: &Opcode, operand: Operand, val: u8, addr: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1282:27 [INFO] [stderr] | [INFO] [stderr] 1282 | cpu.load_ram(vec![0b10000000], 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1284:37 [INFO] [stderr] | [INFO] [stderr] 1284 | assert_eq!(cpu.read_one(0), 0b00000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1296:29 [INFO] [stderr] | [INFO] [stderr] 1296 | assert_eq!(cpu.acc, 0b10000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/mod.rs:1322:32 [INFO] [stderr] | [INFO] [stderr] 1322 | assert_eq!(cpu.status, 0b00110011); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:128:20 [INFO] [stderr] | [INFO] [stderr] 128 | self.pc += opcode.bytes as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(opcode.bytes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:193:26 [INFO] [stderr] | [INFO] [stderr] 193 | let mut result = a as u16 + val as u16 + carry as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:193:37 [INFO] [stderr] | [INFO] [stderr] 193 | let mut result = a as u16 + val as u16 + carry as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:193:50 [INFO] [stderr] | [INFO] [stderr] 193 | let mut result = a as u16 + val as u16 + carry as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:226:32 [INFO] [stderr] | [INFO] [stderr] 226 | fn asl(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:319:22 [INFO] [stderr] | [INFO] [stderr] 319 | let result = self.acc as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i16::from(self.acc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:319:40 [INFO] [stderr] | [INFO] [stderr] 319 | let result = self.acc as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:325:22 [INFO] [stderr] | [INFO] [stderr] 325 | let result = self.x as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:325:38 [INFO] [stderr] | [INFO] [stderr] 325 | let result = self.x as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:331:22 [INFO] [stderr] | [INFO] [stderr] 331 | let result = self.y as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:331:38 [INFO] [stderr] | [INFO] [stderr] 331 | let result = self.y as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:337:22 [INFO] [stderr] | [INFO] [stderr] 337 | let result = self.read_one(addr) as i16 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.read_one(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:343:22 [INFO] [stderr] | [INFO] [stderr] 343 | let result = self.x as i16 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:349:22 [INFO] [stderr] | [INFO] [stderr] 349 | let result = self.y as i16 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:361:23 [INFO] [stderr] | [INFO] [stderr] 361 | let result = (self.read_one(addr) as u16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:367:18 [INFO] [stderr] | [INFO] [stderr] 367 | let x = (self.x as u16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:373:18 [INFO] [stderr] | [INFO] [stderr] 373 | let y = (self.y as u16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:403:32 [INFO] [stderr] | [INFO] [stderr] 403 | fn lsr(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:438:32 [INFO] [stderr] | [INFO] [stderr] 438 | fn rol(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:439:23 [INFO] [stderr] | [INFO] [stderr] 439 | let old_val = self.value_for_operand(operand) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.value_for_operand(operand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:449:32 [INFO] [stderr] | [INFO] [stderr] 449 | fn ror(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:450:27 [INFO] [stderr] | [INFO] [stderr] 450 | let mut old_val = self.value_for_operand(operand) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.value_for_operand(operand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:538:40 [INFO] [stderr] | [INFO] [stderr] 538 | fn set_operand(&mut self, operand: &Operand, val: u8) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:552:49 [INFO] [stderr] | [INFO] [stderr] 552 | Mode::AbsoluteX => Operand::Address(self.x as u16 + self.read_two(pc)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:553:49 [INFO] [stderr] | [INFO] [stderr] 553 | Mode::AbsoluteY => Operand::Address(self.y as u16 + self.read_two(pc)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:554:48 [INFO] [stderr] | [INFO] [stderr] 554 | Mode::ZeroPage => Operand::Address((self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:555:50 [INFO] [stderr] | [INFO] [stderr] 555 | Mode::ZeroPageX => Operand::Address((self.x as u16 + self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:555:66 [INFO] [stderr] | [INFO] [stderr] 555 | Mode::ZeroPageX => Operand::Address((self.x as u16 + self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:556:50 [INFO] [stderr] | [INFO] [stderr] 556 | Mode::ZeroPageY => Operand::Address((self.y as u16 + self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:556:66 [INFO] [stderr] | [INFO] [stderr] 556 | Mode::ZeroPageY => Operand::Address((self.y as u16 + self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:559:29 [INFO] [stderr] | [INFO] [stderr] 559 | let addr = (self.x as u16 + self.read_one(pc) as u16) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:559:45 [INFO] [stderr] | [INFO] [stderr] 559 | let addr = (self.x as u16 + self.read_one(pc) as u16) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:563:34 [INFO] [stderr] | [INFO] [stderr] 563 | Operand::Address(self.y as u16 + self.read_two(self.read_one(pc) as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:563:64 [INFO] [stderr] | [INFO] [stderr] 563 | Operand::Address(self.y as u16 + self.read_two(self.read_one(pc) as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:571:42 [INFO] [stderr] | [INFO] [stderr] 571 | fn value_for_operand(&self, operand: &Operand) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:579:41 [INFO] [stderr] | [INFO] [stderr] 579 | fn addr_for_operand(&self, operand: &Operand) -> u16 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:581:37 [INFO] [stderr] | [INFO] [stderr] 581 | Operand::Accumulator => self.acc as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.acc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:582:36 [INFO] [stderr] | [INFO] [stderr] 582 | Operand::Value(val) => val as u16, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:592:19 [INFO] [stderr] | [INFO] [stderr] 592 | let low = self.read_one(addr) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:593:20 [INFO] [stderr] | [INFO] [stderr] 593 | let high = self.read_one(addr + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cpu/mod.rs:606:9 [INFO] [stderr] | [INFO] [stderr] 606 | / match val { [INFO] [stderr] 607 | | true => self.status |= s as u8, [INFO] [stderr] 608 | | false => self.status &= !(s as u8), [INFO] [stderr] 609 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if val { self.status |= s as u8 } else { self.status &= !(s as u8) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:619:30 [INFO] [stderr] | [INFO] [stderr] 619 | self.pc -= 256 - offset as u16 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:621:24 [INFO] [stderr] | [INFO] [stderr] 621 | self.pc += offset as u16 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:631:20 [INFO] [stderr] | [INFO] [stderr] 631 | let addr = self.sp as u16 + 0x100; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(self.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:633:21 [INFO] [stderr] | [INFO] [stderr] 633 | self.sp = ((self.sp as i16 - 1) & 0xFF) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(self.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:637:19 [INFO] [stderr] | [INFO] [stderr] 637 | let low = self.pop_one() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_one())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:638:20 [INFO] [stderr] | [INFO] [stderr] 638 | let high = self.pop_one() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_one())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:643:21 [INFO] [stderr] | [INFO] [stderr] 643 | self.sp = ((self.sp as u16 + 1) & 0xFF) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(self.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:644:20 [INFO] [stderr] | [INFO] [stderr] 644 | let addr = self.sp as u16 + 0x100; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(self.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:128:20 [INFO] [stderr] | [INFO] [stderr] 128 | self.pc += opcode.bytes as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(opcode.bytes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:193:26 [INFO] [stderr] | [INFO] [stderr] 193 | let mut result = a as u16 + val as u16 + carry as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:193:37 [INFO] [stderr] | [INFO] [stderr] 193 | let mut result = a as u16 + val as u16 + carry as u16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:193:50 [INFO] [stderr] | [INFO] [stderr] 193 | let mut result = a as u16 + val as u16 + carry as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(carry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:226:32 [INFO] [stderr] | [INFO] [stderr] 226 | fn asl(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:319:22 [INFO] [stderr] | [INFO] [stderr] 319 | let result = self.acc as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i16::from(self.acc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:319:40 [INFO] [stderr] | [INFO] [stderr] 319 | let result = self.acc as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:325:22 [INFO] [stderr] | [INFO] [stderr] 325 | let result = self.x as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:325:38 [INFO] [stderr] | [INFO] [stderr] 325 | let result = self.x as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:331:22 [INFO] [stderr] | [INFO] [stderr] 331 | let result = self.y as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:331:38 [INFO] [stderr] | [INFO] [stderr] 331 | let result = self.y as i16 - val as i16; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:337:22 [INFO] [stderr] | [INFO] [stderr] 337 | let result = self.read_one(addr) as i16 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(self.read_one(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:343:22 [INFO] [stderr] | [INFO] [stderr] 343 | let result = self.x as i16 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:349:22 [INFO] [stderr] | [INFO] [stderr] 349 | let result = self.y as i16 - 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:361:23 [INFO] [stderr] | [INFO] [stderr] 361 | let result = (self.read_one(addr) as u16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:367:18 [INFO] [stderr] | [INFO] [stderr] 367 | let x = (self.x as u16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:373:18 [INFO] [stderr] | [INFO] [stderr] 373 | let y = (self.y as u16 + 1) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:403:32 [INFO] [stderr] | [INFO] [stderr] 403 | fn lsr(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:438:32 [INFO] [stderr] | [INFO] [stderr] 438 | fn rol(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:439:23 [INFO] [stderr] | [INFO] [stderr] 439 | let old_val = self.value_for_operand(operand) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.value_for_operand(operand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:449:32 [INFO] [stderr] | [INFO] [stderr] 449 | fn ror(&mut self, operand: &Operand) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:450:27 [INFO] [stderr] | [INFO] [stderr] 450 | let mut old_val = self.value_for_operand(operand) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.value_for_operand(operand))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:538:40 [INFO] [stderr] | [INFO] [stderr] 538 | fn set_operand(&mut self, operand: &Operand, val: u8) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:552:49 [INFO] [stderr] | [INFO] [stderr] 552 | Mode::AbsoluteX => Operand::Address(self.x as u16 + self.read_two(pc)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:553:49 [INFO] [stderr] | [INFO] [stderr] 553 | Mode::AbsoluteY => Operand::Address(self.y as u16 + self.read_two(pc)), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:554:48 [INFO] [stderr] | [INFO] [stderr] 554 | Mode::ZeroPage => Operand::Address((self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:555:50 [INFO] [stderr] | [INFO] [stderr] 555 | Mode::ZeroPageX => Operand::Address((self.x as u16 + self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:555:66 [INFO] [stderr] | [INFO] [stderr] 555 | Mode::ZeroPageX => Operand::Address((self.x as u16 + self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:556:50 [INFO] [stderr] | [INFO] [stderr] 556 | Mode::ZeroPageY => Operand::Address((self.y as u16 + self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:556:66 [INFO] [stderr] | [INFO] [stderr] 556 | Mode::ZeroPageY => Operand::Address((self.y as u16 + self.read_one(pc) as u16) & 0xFF), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:559:29 [INFO] [stderr] | [INFO] [stderr] 559 | let addr = (self.x as u16 + self.read_one(pc) as u16) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:559:45 [INFO] [stderr] | [INFO] [stderr] 559 | let addr = (self.x as u16 + self.read_one(pc) as u16) & 0xFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:563:34 [INFO] [stderr] | [INFO] [stderr] 563 | Operand::Address(self.y as u16 + self.read_two(self.read_one(pc) as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:563:64 [INFO] [stderr] | [INFO] [stderr] 563 | Operand::Address(self.y as u16 + self.read_two(self.read_one(pc) as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(pc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:571:42 [INFO] [stderr] | [INFO] [stderr] 571 | fn value_for_operand(&self, operand: &Operand) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/mod.rs:579:41 [INFO] [stderr] | [INFO] [stderr] 579 | fn addr_for_operand(&self, operand: &Operand) -> u16 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:581:37 [INFO] [stderr] | [INFO] [stderr] 581 | Operand::Accumulator => self.acc as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.acc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:582:36 [INFO] [stderr] | [INFO] [stderr] 582 | Operand::Value(val) => val as u16, [INFO] [stderr] | ^^^^^^^^^^ help: try: `u16::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:592:19 [INFO] [stderr] | [INFO] [stderr] 592 | let low = self.read_one(addr) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:593:20 [INFO] [stderr] | [INFO] [stderr] 593 | let high = self.read_one(addr + 1) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_one(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/cpu/mod.rs:606:9 [INFO] [stderr] | [INFO] [stderr] 606 | / match val { [INFO] [stderr] 607 | | true => self.status |= s as u8, [INFO] [stderr] 608 | | false => self.status &= !(s as u8), [INFO] [stderr] 609 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if val { self.status |= s as u8 } else { self.status &= !(s as u8) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:619:30 [INFO] [stderr] | [INFO] [stderr] 619 | self.pc -= 256 - offset as u16 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:621:24 [INFO] [stderr] | [INFO] [stderr] 621 | self.pc += offset as u16 [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:631:20 [INFO] [stderr] | [INFO] [stderr] 631 | let addr = self.sp as u16 + 0x100; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(self.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:633:21 [INFO] [stderr] | [INFO] [stderr] 633 | self.sp = ((self.sp as i16 - 1) & 0xFF) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i16::from(self.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:637:19 [INFO] [stderr] | [INFO] [stderr] 637 | let low = self.pop_one() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_one())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:638:20 [INFO] [stderr] | [INFO] [stderr] 638 | let high = self.pop_one() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.pop_one())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:643:21 [INFO] [stderr] | [INFO] [stderr] 643 | self.sp = ((self.sp as u16 + 1) & 0xFF) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(self.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/cpu/mod.rs:644:20 [INFO] [stderr] | [INFO] [stderr] 644 | let addr = self.sp as u16 + 0x100; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(self.sp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.28s [INFO] running `"docker" "inspect" "f919aef74e5ffbe4aa1f960dae59424c79f7dba5f207b561afaf0efc12ad7f2b"` [INFO] running `"docker" "rm" "-f" "f919aef74e5ffbe4aa1f960dae59424c79f7dba5f207b561afaf0efc12ad7f2b"` [INFO] [stdout] f919aef74e5ffbe4aa1f960dae59424c79f7dba5f207b561afaf0efc12ad7f2b