[INFO] updating cached repository tsathishkumar/csvdiff-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tsathishkumar/csvdiff-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tsathishkumar/csvdiff-rs" "work/ex/clippy-test-run/sources/stable/gh/tsathishkumar/csvdiff-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tsathishkumar/csvdiff-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tsathishkumar/csvdiff-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsathishkumar/csvdiff-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsathishkumar/csvdiff-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e3a28ebaeaae610c98dcb55ca0065d725b5ad62c [INFO] sha for GitHub repo tsathishkumar/csvdiff-rs: e3a28ebaeaae610c98dcb55ca0065d725b5ad62c [INFO] validating manifest of tsathishkumar/csvdiff-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsathishkumar/csvdiff-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsathishkumar/csvdiff-rs [INFO] finished frobbing tsathishkumar/csvdiff-rs [INFO] frobbed toml for tsathishkumar/csvdiff-rs written to work/ex/clippy-test-run/sources/stable/gh/tsathishkumar/csvdiff-rs/Cargo.toml [INFO] started frobbing tsathishkumar/csvdiff-rs [INFO] finished frobbing tsathishkumar/csvdiff-rs [INFO] frobbed toml for tsathishkumar/csvdiff-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsathishkumar/csvdiff-rs/Cargo.toml [INFO] crate tsathishkumar/csvdiff-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsathishkumar/csvdiff-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tsathishkumar/csvdiff-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f28eb4d9842f2ab4e41a1220243f0e2a9e151016ed623fb9b8a3871220e3a9e [INFO] running `"docker" "start" "-a" "1f28eb4d9842f2ab4e41a1220243f0e2a9e151016ed623fb9b8a3871220e3a9e"` [INFO] [stderr] Checking serde v1.0.48 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking atty v0.2.10 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking twox-hash v1.1.0 [INFO] [stderr] Checking chan v0.1.21 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking csvdiff-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::cmp::Ordering` [INFO] [stderr] --> src/digest.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::cmp::Ordering; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp::Ordering` [INFO] [stderr] --> src/digest.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::cmp::Ordering; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/digest.rs:19:39 [INFO] [stderr] | [INFO] [stderr] 19 | let (hash_sender, hash_receiver): (Sender<(String, StringRecord)>, Receiver<(String, StringRecord)>) = channel(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/digest.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match record { [INFO] [stderr] 30 | | Ok(string_record) => { [INFO] [stderr] 31 | | let record = string_record.get(0).unwrap().to_owned(); [INFO] [stderr] 32 | | hash_sender.send((String::from(record), string_record)).unwrap(); [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | _ => () [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | if let Ok(string_record) = record { [INFO] [stderr] 30 | let record = string_record.get(0).unwrap().to_owned(); [INFO] [stderr] 31 | hash_sender.send((String::from(record), string_record)).unwrap(); [INFO] [stderr] 32 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/digest.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | hash_sender.send((String::from(record), string_record)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `record` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/digest.rs:41:39 [INFO] [stderr] | [INFO] [stderr] 41 | let (hash_sender, hash_receiver): (Sender<(String, StringRecord)>, Receiver<(String, StringRecord)>) = channel(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/digest.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | Some(existing_record) => match existing_record.eq(&get_hash(value.as_slice().as_bytes())) { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 47 | | true => (), [INFO] [stderr] 48 | | false => println!("Changed {:?}", value) [INFO] [stderr] 49 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if !existing_record.eq(&get_hash(value.as_slice().as_bytes())) { println!("Changed {:?}", value) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/digest.rs:59:35 [INFO] [stderr] | [INFO] [stderr] 59 | hash_sender.send((String::from(record), string_record)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/digest.rs:19:39 [INFO] [stderr] | [INFO] [stderr] 19 | let (hash_sender, hash_receiver): (Sender<(String, StringRecord)>, Receiver<(String, StringRecord)>) = channel(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/digest.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match record { [INFO] [stderr] 30 | | Ok(string_record) => { [INFO] [stderr] 31 | | let record = string_record.get(0).unwrap().to_owned(); [INFO] [stderr] 32 | | hash_sender.send((String::from(record), string_record)).unwrap(); [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | _ => () [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | if let Ok(string_record) = record { [INFO] [stderr] 30 | let record = string_record.get(0).unwrap().to_owned(); [INFO] [stderr] 31 | hash_sender.send((String::from(record), string_record)).unwrap(); [INFO] [stderr] 32 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/digest.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | hash_sender.send((String::from(record), string_record)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `record` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/digest.rs:41:39 [INFO] [stderr] | [INFO] [stderr] 41 | let (hash_sender, hash_receiver): (Sender<(String, StringRecord)>, Receiver<(String, StringRecord)>) = channel(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/digest.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | Some(existing_record) => match existing_record.eq(&get_hash(value.as_slice().as_bytes())) { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 47 | | true => (), [INFO] [stderr] 48 | | false => println!("Changed {:?}", value) [INFO] [stderr] 49 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if !existing_record.eq(&get_hash(value.as_slice().as_bytes())) { println!("Changed {:?}", value) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/digest.rs:59:35 [INFO] [stderr] | [INFO] [stderr] 59 | hash_sender.send((String::from(record), string_record)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.77s [INFO] running `"docker" "inspect" "1f28eb4d9842f2ab4e41a1220243f0e2a9e151016ed623fb9b8a3871220e3a9e"` [INFO] running `"docker" "rm" "-f" "1f28eb4d9842f2ab4e41a1220243f0e2a9e151016ed623fb9b8a3871220e3a9e"` [INFO] [stdout] 1f28eb4d9842f2ab4e41a1220243f0e2a9e151016ed623fb9b8a3871220e3a9e