[INFO] updating cached repository tronje/git-prompt-helper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tronje/git-prompt-helper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tronje/git-prompt-helper" "work/ex/clippy-test-run/sources/stable/gh/tronje/git-prompt-helper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tronje/git-prompt-helper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tronje/git-prompt-helper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tronje/git-prompt-helper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tronje/git-prompt-helper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9dea81b20e1df85d38905c6522bb69832b11a21f [INFO] sha for GitHub repo tronje/git-prompt-helper: 9dea81b20e1df85d38905c6522bb69832b11a21f [INFO] validating manifest of tronje/git-prompt-helper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tronje/git-prompt-helper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tronje/git-prompt-helper [INFO] finished frobbing tronje/git-prompt-helper [INFO] frobbed toml for tronje/git-prompt-helper written to work/ex/clippy-test-run/sources/stable/gh/tronje/git-prompt-helper/Cargo.toml [INFO] started frobbing tronje/git-prompt-helper [INFO] finished frobbing tronje/git-prompt-helper [INFO] frobbed toml for tronje/git-prompt-helper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tronje/git-prompt-helper/Cargo.toml [INFO] crate tronje/git-prompt-helper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tronje/git-prompt-helper against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tronje/git-prompt-helper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bbb9fc015c3a5b7ecd362e9bc9e31bca23b210d0bfb898029c006e44a9fe8c0c [INFO] running `"docker" "start" "-a" "bbb9fc015c3a5b7ecd362e9bc9e31bca23b210d0bfb898029c006e44a9fe8c0c"` [INFO] [stderr] Checking git-prompt-helper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / if output == "true\n" { [INFO] [stderr] 26 | | true [INFO] [stderr] 27 | | } else { [INFO] [stderr] 28 | | false [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `output == "true\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / if output == "" { [INFO] [stderr] 41 | | true [INFO] [stderr] 42 | | } else { [INFO] [stderr] 43 | | false [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `output == ""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / if output == "true\n" { [INFO] [stderr] 26 | | true [INFO] [stderr] 27 | | } else { [INFO] [stderr] 28 | | false [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `output == "true\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / if output == "" { [INFO] [stderr] 41 | | true [INFO] [stderr] 42 | | } else { [INFO] [stderr] 43 | | false [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `output == ""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "bbb9fc015c3a5b7ecd362e9bc9e31bca23b210d0bfb898029c006e44a9fe8c0c"` [INFO] running `"docker" "rm" "-f" "bbb9fc015c3a5b7ecd362e9bc9e31bca23b210d0bfb898029c006e44a9fe8c0c"` [INFO] [stdout] bbb9fc015c3a5b7ecd362e9bc9e31bca23b210d0bfb898029c006e44a9fe8c0c