[INFO] updating cached repository tristanred/PakPak [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tristanred/PakPak [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tristanred/PakPak" "work/ex/clippy-test-run/sources/stable/gh/tristanred/PakPak"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tristanred/PakPak'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tristanred/PakPak" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tristanred/PakPak"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tristanred/PakPak'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 93d7ace7f97c222777b37bb1c6bbb04ac0dcfc4a [INFO] sha for GitHub repo tristanred/PakPak: 93d7ace7f97c222777b37bb1c6bbb04ac0dcfc4a [INFO] validating manifest of tristanred/PakPak on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tristanred/PakPak on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tristanred/PakPak [INFO] finished frobbing tristanred/PakPak [INFO] frobbed toml for tristanred/PakPak written to work/ex/clippy-test-run/sources/stable/gh/tristanred/PakPak/Cargo.toml [INFO] started frobbing tristanred/PakPak [INFO] finished frobbing tristanred/PakPak [INFO] frobbed toml for tristanred/PakPak written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tristanred/PakPak/Cargo.toml [INFO] crate tristanred/PakPak has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tristanred/PakPak against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tristanred/PakPak:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56a57a2b7780e38100ff98e4c49b0db239cbf2c02afca31a079ed861e91ba09f [INFO] running `"docker" "start" "-a" "56a57a2b7780e38100ff98e4c49b0db239cbf2c02afca31a079ed861e91ba09f"` [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking clap v2.29.4 [INFO] [stderr] Checking pakpak v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return Ok(true) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pak.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | Err(_) => panic!("Directory not found.") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pak.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | Err(_) => panic!("Cannot read dir") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return Ok(true) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pak.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | Err(_) => panic!("Directory not found.") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/pak.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | Err(_) => panic!("Cannot read dir") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.47s [INFO] running `"docker" "inspect" "56a57a2b7780e38100ff98e4c49b0db239cbf2c02afca31a079ed861e91ba09f"` [INFO] running `"docker" "rm" "-f" "56a57a2b7780e38100ff98e4c49b0db239cbf2c02afca31a079ed861e91ba09f"` [INFO] [stdout] 56a57a2b7780e38100ff98e4c49b0db239cbf2c02afca31a079ed861e91ba09f