[INFO] updating cached repository travisbhartwell/rbasic [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/travisbhartwell/rbasic [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/travisbhartwell/rbasic" "work/ex/clippy-test-run/sources/stable/gh/travisbhartwell/rbasic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/travisbhartwell/rbasic'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/travisbhartwell/rbasic" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travisbhartwell/rbasic"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travisbhartwell/rbasic'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dc72b0767c3ab74c01832a3204d9feda7d9b4e1d [INFO] sha for GitHub repo travisbhartwell/rbasic: dc72b0767c3ab74c01832a3204d9feda7d9b4e1d [INFO] validating manifest of travisbhartwell/rbasic on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of travisbhartwell/rbasic on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing travisbhartwell/rbasic [INFO] finished frobbing travisbhartwell/rbasic [INFO] frobbed toml for travisbhartwell/rbasic written to work/ex/clippy-test-run/sources/stable/gh/travisbhartwell/rbasic/Cargo.toml [INFO] started frobbing travisbhartwell/rbasic [INFO] finished frobbing travisbhartwell/rbasic [INFO] frobbed toml for travisbhartwell/rbasic written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travisbhartwell/rbasic/Cargo.toml [INFO] crate travisbhartwell/rbasic has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting travisbhartwell/rbasic against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/travisbhartwell/rbasic:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c15af0e46ccbd56bd65a27249ff68fd496a42bd2cc1472f8851b43a572b8d6f2 [INFO] running `"docker" "start" "-a" "c15af0e46ccbd56bd65a27249ff68fd496a42bd2cc1472f8851b43a572b8d6f2"` [INFO] [stderr] Checking either v1.0.2 [INFO] [stderr] Checking itertools v0.5.8 [INFO] [stderr] Checking rbasic v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/evaluator.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | fn parse_expression(mut token_iter: &mut Peekable>) [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/evaluator.rs:271:34 [INFO] [stderr] | [INFO] [stderr] 271 | fn parse_and_eval_expression<'a>(mut token_iter: &mut Peekable>, [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/evaluator.rs:298:28 [INFO] [stderr] | [INFO] [stderr] 298 | if stack.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/evaluator.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | fn parse_expression(mut token_iter: &mut Peekable>) [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/evaluator.rs:271:34 [INFO] [stderr] | [INFO] [stderr] 271 | fn parse_and_eval_expression<'a>(mut token_iter: &mut Peekable>, [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/evaluator.rs:298:28 [INFO] [stderr] | [INFO] [stderr] 298 | if stack.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.56s [INFO] running `"docker" "inspect" "c15af0e46ccbd56bd65a27249ff68fd496a42bd2cc1472f8851b43a572b8d6f2"` [INFO] running `"docker" "rm" "-f" "c15af0e46ccbd56bd65a27249ff68fd496a42bd2cc1472f8851b43a572b8d6f2"` [INFO] [stdout] c15af0e46ccbd56bd65a27249ff68fd496a42bd2cc1472f8851b43a572b8d6f2