[INFO] updating cached repository tperdue321/rust_generics
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tperdue321/rust_generics
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tperdue321/rust_generics" "work/ex/clippy-test-run/sources/stable/gh/tperdue321/rust_generics"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tperdue321/rust_generics'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tperdue321/rust_generics" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tperdue321/rust_generics"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tperdue321/rust_generics'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] be67fc9a1ad6f2582d1896151b4e3562e3e83da9
[INFO] sha for GitHub repo tperdue321/rust_generics: be67fc9a1ad6f2582d1896151b4e3562e3e83da9
[INFO] validating manifest of tperdue321/rust_generics on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tperdue321/rust_generics on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tperdue321/rust_generics
[INFO] finished frobbing tperdue321/rust_generics
[INFO] frobbed toml for tperdue321/rust_generics written to work/ex/clippy-test-run/sources/stable/gh/tperdue321/rust_generics/Cargo.toml
[INFO] started frobbing tperdue321/rust_generics
[INFO] finished frobbing tperdue321/rust_generics
[INFO] frobbed toml for tperdue321/rust_generics written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tperdue321/rust_generics/Cargo.toml
[INFO] crate tperdue321/rust_generics has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tperdue321/rust_generics against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tperdue321/rust_generics:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fb4e5949541430e98692c2f3dc5668248258bd48b5882e4717c567be2f786fab
[INFO] running `"docker" "start" "-a" "fb4e5949541430e98692c2f3dc5668248258bd48b5882e4717c567be2f786fab"`
[INFO] [stderr]     Checking generics v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:220:3
[INFO] [stderr]     |
[INFO] [stderr] 220 | /   let mut longest = str1;
[INFO] [stderr] 221 | |   if str2.len() > str1.len() {
[INFO] [stderr] 222 | |     longest = str2;
[INFO] [stderr] 223 | |   }
[INFO] [stderr]     | |___^ help: it is more idiomatic to write: `let <mut> longest = if str2.len() > str1.len() { str2 } else { str1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:220:3
[INFO] [stderr]     |
[INFO] [stderr] 220 | /   let mut longest = str1;
[INFO] [stderr] 221 | |   if str2.len() > str1.len() {
[INFO] [stderr] 222 | |     longest = str2;
[INFO] [stderr] 223 | |   }
[INFO] [stderr]     | |___^ help: it is more idiomatic to write: `let <mut> longest = if str2.len() > str1.len() { str2 } else { str1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.68s
[INFO] running `"docker" "inspect" "fb4e5949541430e98692c2f3dc5668248258bd48b5882e4717c567be2f786fab"`
[INFO] running `"docker" "rm" "-f" "fb4e5949541430e98692c2f3dc5668248258bd48b5882e4717c567be2f786fab"`
[INFO] [stdout] fb4e5949541430e98692c2f3dc5668248258bd48b5882e4717c567be2f786fab