[INFO] updating cached repository totem3/rem [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/totem3/rem [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/totem3/rem" "work/ex/clippy-test-run/sources/stable/gh/totem3/rem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/totem3/rem'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/totem3/rem" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totem3/rem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totem3/rem'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 366c9e150d71dca9890d69b125efa7669bce53af [INFO] sha for GitHub repo totem3/rem: 366c9e150d71dca9890d69b125efa7669bce53af [INFO] validating manifest of totem3/rem on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of totem3/rem on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing totem3/rem [INFO] finished frobbing totem3/rem [INFO] frobbed toml for totem3/rem written to work/ex/clippy-test-run/sources/stable/gh/totem3/rem/Cargo.toml [INFO] started frobbing totem3/rem [INFO] finished frobbing totem3/rem [INFO] frobbed toml for totem3/rem written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totem3/rem/Cargo.toml [INFO] crate totem3/rem has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting totem3/rem against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/totem3/rem:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2339fadc4c9a47744f6bf2ac9e2b33b868545c6ff01b3c014e8aa4eea52184d5 [INFO] running `"docker" "start" "-a" "2339fadc4c9a47744f6bf2ac9e2b33b868545c6ff01b3c014e8aa4eea52184d5"` [INFO] [stderr] Checking rem v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:82:24 [INFO] [stderr] | [INFO] [stderr] 82 | HandlerError { reason: reason } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler_info.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | instructions: instructions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler_info.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:82:24 [INFO] [stderr] | [INFO] [stderr] 82 | HandlerError { reason: reason } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reason` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler_info.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | instructions: instructions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compiler_info.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rem_value.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self { [INFO] [stderr] 42 | | &RemValue::String_(ref s) => write!(f, "{}", s), [INFO] [stderr] 43 | | &RemValue::Number(ref n) => write!(f, "{}", n), [INFO] [stderr] 44 | | &RemValue::Boolean(ref n) => write!(f, "{}", n), [INFO] [stderr] 45 | | &RemValue::Empty => write!(f, ""), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self { [INFO] [stderr] 42 | RemValue::String_(ref s) => write!(f, "{}", s), [INFO] [stderr] 43 | RemValue::Number(ref n) => write!(f, "{}", n), [INFO] [stderr] 44 | RemValue::Boolean(ref n) => write!(f, "{}", n), [INFO] [stderr] 45 | RemValue::Empty => write!(f, ""), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &Operand::Register(ref i) => write!(f, "${}", i), [INFO] [stderr] 23 | | &Operand::Value(ref v) => write!(f, "{}", v), [INFO] [stderr] 24 | | &Operand::Label(ref v) => write!(f, ":{}", v), [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | Operand::Register(ref i) => write!(f, "${}", i), [INFO] [stderr] 23 | Operand::Value(ref v) => write!(f, "{}", v), [INFO] [stderr] 24 | Operand::Label(ref v) => write!(f, ":{}", v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:55:32 [INFO] [stderr] | [INFO] [stderr] 55 | v if s.starts_with("$") => { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:64:32 [INFO] [stderr] | [INFO] [stderr] 64 | v if s.starts_with(":") => Ok(Operand::Label(v.to_string())), [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/instruction.rs:85:32 [INFO] [stderr] | [INFO] [stderr] 85 | HandlerError { reason: format!("{}", reason) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `reason.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | let ref a = registers[*i]; [INFO] [stderr] | ----^^^^^----------------- help: try: `let a = ®isters[*i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | let ref b = registers[*j]; [INFO] [stderr] | ----^^^^^----------------- help: try: `let b = ®isters[*j];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/instruction.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | / match &self.0 { [INFO] [stderr] 278 | | &Value(ref v) => println!("{}", v), [INFO] [stderr] 279 | | &Register(ref i) => { [INFO] [stderr] 280 | | let registers = registers.borrow(); [INFO] [stderr] ... | [INFO] [stderr] 284 | | _ => return Err(HandlerError::str("cannot echo label")), [INFO] [stderr] 285 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 277 | match self.0 { [INFO] [stderr] 278 | Value(ref v) => println!("{}", v), [INFO] [stderr] 279 | Register(ref i) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:281:21 [INFO] [stderr] | [INFO] [stderr] 281 | let ref value = registers[*i].value; [INFO] [stderr] | ----^^^^^^^^^----------------------- help: try: `let value = ®isters[*i].value;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/instruction.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | / match &self.0 { [INFO] [stderr] 299 | | &Value(ref v) => println!("{}", v), [INFO] [stderr] 300 | | &Register(ref i) => { [INFO] [stderr] 301 | | let registers = registers.borrow(); [INFO] [stderr] ... | [INFO] [stderr] 305 | | _ => return Err(HandlerError::str("cannot echo label")), [INFO] [stderr] 306 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 298 | match self.0 { [INFO] [stderr] 299 | Value(ref v) => println!("{}", v), [INFO] [stderr] 300 | Register(ref i) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | let ref value = registers[*i].value; [INFO] [stderr] | ----^^^^^^^^^----------------------- help: try: `let value = ®isters[*i].value;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | let ref src = registers[*j]; [INFO] [stderr] | ----^^^^^^^----------------- help: try: `let src = ®isters[*j];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:333:13 [INFO] [stderr] | [INFO] [stderr] 333 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:430:21 [INFO] [stderr] | [INFO] [stderr] 430 | let ref register = registers.borrow()[*i]; [INFO] [stderr] | ----^^^^^^^^^^^^-------------------------- help: try: `let register = ®isters.borrow()[*i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:459:21 [INFO] [stderr] | [INFO] [stderr] 459 | let ref register = registers.borrow()[*i]; [INFO] [stderr] | ----^^^^^^^^^^^^-------------------------- help: try: `let register = ®isters.borrow()[*i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:476:21 [INFO] [stderr] | [INFO] [stderr] 476 | let ref register = registers.borrow()[*i]; [INFO] [stderr] | ----^^^^^^^^^^^^-------------------------- help: try: `let register = ®isters.borrow()[*i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:509:13 [INFO] [stderr] | [INFO] [stderr] 509 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rem_value.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self { [INFO] [stderr] 42 | | &RemValue::String_(ref s) => write!(f, "{}", s), [INFO] [stderr] 43 | | &RemValue::Number(ref n) => write!(f, "{}", n), [INFO] [stderr] 44 | | &RemValue::Boolean(ref n) => write!(f, "{}", n), [INFO] [stderr] 45 | | &RemValue::Empty => write!(f, ""), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self { [INFO] [stderr] 42 | RemValue::String_(ref s) => write!(f, "{}", s), [INFO] [stderr] 43 | RemValue::Number(ref n) => write!(f, "{}", n), [INFO] [stderr] 44 | RemValue::Boolean(ref n) => write!(f, "{}", n), [INFO] [stderr] 45 | RemValue::Empty => write!(f, ""), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:565:13 [INFO] [stderr] | [INFO] [stderr] 565 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/parser.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn parse(r: &mut R) -> Result { [INFO] [stderr] 42 | | let mut vec: Vec> = Vec::new(); [INFO] [stderr] 43 | | let mut labels: HashMap = HashMap::new(); [INFO] [stderr] 44 | | let mut lnum = 0; [INFO] [stderr] ... | [INFO] [stderr] 355 | | Ok(ci) [INFO] [stderr] 356 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:55:26 [INFO] [stderr] | [INFO] [stderr] 55 | let _op = if ss.len() > 0 { ss[0].clone() } else { "" }; [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ss.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parser.rs:55:41 [INFO] [stderr] | [INFO] [stderr] 55 | let _op = if ss.len() > 0 { ss[0].clone() } else { "" }; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 55 | let _op = if ss.len() > 0 { &(*ss[0]).clone() } else { "" }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 55 | let _op = if ss.len() > 0 { &str::clone(ss[0]) } else { "" }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | v if v.starts_with(":") => { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instruction.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &Operand::Register(ref i) => write!(f, "${}", i), [INFO] [stderr] 23 | | &Operand::Value(ref v) => write!(f, "{}", v), [INFO] [stderr] 24 | | &Operand::Label(ref v) => write!(f, ":{}", v), [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | Operand::Register(ref i) => write!(f, "${}", i), [INFO] [stderr] 23 | Operand::Value(ref v) => write!(f, "{}", v), [INFO] [stderr] 24 | Operand::Label(ref v) => write!(f, ":{}", v), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `executor::Executor` [INFO] [stderr] --> src/executor.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | Executor { [INFO] [stderr] 12 | | registers: init_registers(), [INFO] [stderr] 13 | | pc: 0, [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:55:32 [INFO] [stderr] | [INFO] [stderr] 55 | v if s.starts_with("$") => { [INFO] [stderr] | ^^^ help: try using a char instead: `'$'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/instruction.rs:64:32 [INFO] [stderr] | [INFO] [stderr] 64 | v if s.starts_with(":") => Ok(Operand::Label(v.to_string())), [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executor.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | let ref inst = instructions[self.pc]; [INFO] [stderr] | ----^^^^^^^^------------------------- help: try: `let inst = &instructions[self.pc];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/instruction.rs:85:32 [INFO] [stderr] | [INFO] [stderr] 85 | HandlerError { reason: format!("{}", reason) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `reason.to_string()` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/executor.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match p { [INFO] [stderr] 32 | | Err(e) => { [INFO] [stderr] 33 | | println!("{:?}", e); [INFO] [stderr] 34 | | break; [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | _ => {} [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | if let Err(e) = p { [INFO] [stderr] 32 | println!("{:?}", e); [INFO] [stderr] 33 | break; [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | let ref a = registers[*i]; [INFO] [stderr] | ----^^^^^----------------- help: try: `let a = ®isters[*i];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:176:21 [INFO] [stderr] | [INFO] [stderr] 176 | let ref b = registers[*j]; [INFO] [stderr] | ----^^^^^----------------- help: try: `let b = ®isters[*j];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `rem`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/instruction.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | / match &self.0 { [INFO] [stderr] 278 | | &Value(ref v) => println!("{}", v), [INFO] [stderr] 279 | | &Register(ref i) => { [INFO] [stderr] 280 | | let registers = registers.borrow(); [INFO] [stderr] ... | [INFO] [stderr] 284 | | _ => return Err(HandlerError::str("cannot echo label")), [INFO] [stderr] 285 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 277 | match self.0 { [INFO] [stderr] 278 | Value(ref v) => println!("{}", v), [INFO] [stderr] 279 | Register(ref i) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:281:21 [INFO] [stderr] | [INFO] [stderr] 281 | let ref value = registers[*i].value; [INFO] [stderr] | ----^^^^^^^^^----------------------- help: try: `let value = ®isters[*i].value;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/instruction.rs:298:9 [INFO] [stderr] | [INFO] [stderr] 298 | / match &self.0 { [INFO] [stderr] 299 | | &Value(ref v) => println!("{}", v), [INFO] [stderr] 300 | | &Register(ref i) => { [INFO] [stderr] 301 | | let registers = registers.borrow(); [INFO] [stderr] ... | [INFO] [stderr] 305 | | _ => return Err(HandlerError::str("cannot echo label")), [INFO] [stderr] 306 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 298 | match self.0 { [INFO] [stderr] 299 | Value(ref v) => println!("{}", v), [INFO] [stderr] 300 | Register(ref i) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:302:21 [INFO] [stderr] | [INFO] [stderr] 302 | let ref value = registers[*i].value; [INFO] [stderr] | ----^^^^^^^^^----------------------- help: try: `let value = ®isters[*i].value;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | let ref src = registers[*j]; [INFO] [stderr] | ----^^^^^^^----------------- help: try: `let src = ®isters[*j];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:333:13 [INFO] [stderr] | [INFO] [stderr] 333 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:354:13 [INFO] [stderr] | [INFO] [stderr] 354 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:430:21 [INFO] [stderr] | [INFO] [stderr] 430 | let ref register = registers.borrow()[*i]; [INFO] [stderr] | ----^^^^^^^^^^^^-------------------------- help: try: `let register = ®isters.borrow()[*i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:459:21 [INFO] [stderr] | [INFO] [stderr] 459 | let ref register = registers.borrow()[*i]; [INFO] [stderr] | ----^^^^^^^^^^^^-------------------------- help: try: `let register = ®isters.borrow()[*i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:476:21 [INFO] [stderr] | [INFO] [stderr] 476 | let ref register = registers.borrow()[*i]; [INFO] [stderr] | ----^^^^^^^^^^^^-------------------------- help: try: `let register = ®isters.borrow()[*i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:509:13 [INFO] [stderr] | [INFO] [stderr] 509 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:528:13 [INFO] [stderr] | [INFO] [stderr] 528 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:565:13 [INFO] [stderr] | [INFO] [stderr] 565 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/instruction.rs:584:13 [INFO] [stderr] | [INFO] [stderr] 584 | let ref mut dst = registers[dst_index]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------ help: try: `let dst = &mut registers[dst_index];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/parser.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn parse(r: &mut R) -> Result { [INFO] [stderr] 42 | | let mut vec: Vec> = Vec::new(); [INFO] [stderr] 43 | | let mut labels: HashMap = HashMap::new(); [INFO] [stderr] 44 | | let mut lnum = 0; [INFO] [stderr] ... | [INFO] [stderr] 355 | | Ok(ci) [INFO] [stderr] 356 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:55:26 [INFO] [stderr] | [INFO] [stderr] 55 | let _op = if ss.len() > 0 { ss[0].clone() } else { "" }; [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ss.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/parser.rs:55:41 [INFO] [stderr] | [INFO] [stderr] 55 | let _op = if ss.len() > 0 { ss[0].clone() } else { "" }; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 55 | let _op = if ss.len() > 0 { &(*ss[0]).clone() } else { "" }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 55 | let _op = if ss.len() > 0 { &str::clone(ss[0]) } else { "" }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | v if v.starts_with(":") => { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `executor::Executor` [INFO] [stderr] --> src/executor.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | Executor { [INFO] [stderr] 12 | | registers: init_registers(), [INFO] [stderr] 13 | | pc: 0, [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executor.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | let ref inst = instructions[self.pc]; [INFO] [stderr] | ----^^^^^^^^------------------------- help: try: `let inst = &instructions[self.pc];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/executor.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match p { [INFO] [stderr] 32 | | Err(e) => { [INFO] [stderr] 33 | | println!("{:?}", e); [INFO] [stderr] 34 | | break; [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | _ => {} [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | if let Err(e) = p { [INFO] [stderr] 32 | println!("{:?}", e); [INFO] [stderr] 33 | break; [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rem`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2339fadc4c9a47744f6bf2ac9e2b33b868545c6ff01b3c014e8aa4eea52184d5"` [INFO] running `"docker" "rm" "-f" "2339fadc4c9a47744f6bf2ac9e2b33b868545c6ff01b3c014e8aa4eea52184d5"` [INFO] [stdout] 2339fadc4c9a47744f6bf2ac9e2b33b868545c6ff01b3c014e8aa4eea52184d5