[INFO] updating cached repository tonyrubak/rustnetcat
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tonyrubak/rustnetcat
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tonyrubak/rustnetcat" "work/ex/clippy-test-run/sources/stable/gh/tonyrubak/rustnetcat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tonyrubak/rustnetcat'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tonyrubak/rustnetcat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tonyrubak/rustnetcat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tonyrubak/rustnetcat'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 566ac75711034d96484b19b12c8131cadbcde4fd
[INFO] sha for GitHub repo tonyrubak/rustnetcat: 566ac75711034d96484b19b12c8131cadbcde4fd
[INFO] validating manifest of tonyrubak/rustnetcat on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tonyrubak/rustnetcat on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tonyrubak/rustnetcat
[INFO] finished frobbing tonyrubak/rustnetcat
[INFO] frobbed toml for tonyrubak/rustnetcat written to work/ex/clippy-test-run/sources/stable/gh/tonyrubak/rustnetcat/Cargo.toml
[INFO] started frobbing tonyrubak/rustnetcat
[INFO] finished frobbing tonyrubak/rustnetcat
[INFO] frobbed toml for tonyrubak/rustnetcat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tonyrubak/rustnetcat/Cargo.toml
[INFO] crate tonyrubak/rustnetcat has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tonyrubak/rustnetcat against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tonyrubak/rustnetcat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2cda8f9e331403b313e5db6d60793dc717f09e6882e1e2f82798a996a8e053e1
[INFO] running `"docker" "start" "-a" "2cda8f9e331403b313e5db6d60793dc717f09e6882e1e2f82798a996a8e053e1"`
[INFO] [stderr]     Checking getopts v0.2.17
[INFO] [stderr]     Checking runet v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 |     return output;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 |     return output;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:91:29
[INFO] [stderr]    |
[INFO] [stderr] 91 |     if !prog_opts.listen && prog_opts.target.len() > 0 && prog_opts.port > 0 {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!prog_opts.target.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/main.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         Err(_) => {
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:146:46
[INFO] [stderr]     |
[INFO] [stderr] 146 |     let (cmd_str, args) = match command.find(" ") {
[INFO] [stderr]     |                                              ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 |             let _ = println!("Read {} bytes", read_sz);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:189:8
[INFO] [stderr]     |
[INFO] [stderr] 189 |     if options.execute.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!options.execute.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:217:21
[INFO] [stderr]     |
[INFO] [stderr] 217 |     let target = if options.target.len() == 0 {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `options.target.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:224:9
[INFO] [stderr]     |
[INFO] [stderr] 224 | /         match stream {
[INFO] [stderr] 225 | |             Ok(stream) => {
[INFO] [stderr] 226 | |                 let opts = options.clone();
[INFO] [stderr] 227 | |                 thread::spawn(move || client_handler(stream, opts));
[INFO] [stderr] 228 | |             }
[INFO] [stderr] 229 | |             Err(_ ) => {}
[INFO] [stderr] 230 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 224 |         if let Ok(stream) = stream {
[INFO] [stderr] 225 |     let opts = options.clone();
[INFO] [stderr] 226 |     thread::spawn(move || client_handler(stream, opts));
[INFO] [stderr] 227 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:91:29
[INFO] [stderr]    |
[INFO] [stderr] 91 |     if !prog_opts.listen && prog_opts.target.len() > 0 && prog_opts.port > 0 {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!prog_opts.target.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/main.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         Err(_) => {
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:146:46
[INFO] [stderr]     |
[INFO] [stderr] 146 |     let (cmd_str, args) = match command.find(" ") {
[INFO] [stderr]     |                                              ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =`
[INFO] [stderr]    --> src/main.rs:174:13
[INFO] [stderr]     |
[INFO] [stderr] 174 |             let _ = println!("Read {} bytes", read_sz);
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:189:8
[INFO] [stderr]     |
[INFO] [stderr] 189 |     if options.execute.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!options.execute.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:217:21
[INFO] [stderr]     |
[INFO] [stderr] 217 |     let target = if options.target.len() == 0 {
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `options.target.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:224:9
[INFO] [stderr]     |
[INFO] [stderr] 224 | /         match stream {
[INFO] [stderr] 225 | |             Ok(stream) => {
[INFO] [stderr] 226 | |                 let opts = options.clone();
[INFO] [stderr] 227 | |                 thread::spawn(move || client_handler(stream, opts));
[INFO] [stderr] 228 | |             }
[INFO] [stderr] 229 | |             Err(_ ) => {}
[INFO] [stderr] 230 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 224 |         if let Ok(stream) = stream {
[INFO] [stderr] 225 |     let opts = options.clone();
[INFO] [stderr] 226 |     thread::spawn(move || client_handler(stream, opts));
[INFO] [stderr] 227 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.47s
[INFO] running `"docker" "inspect" "2cda8f9e331403b313e5db6d60793dc717f09e6882e1e2f82798a996a8e053e1"`
[INFO] running `"docker" "rm" "-f" "2cda8f9e331403b313e5db6d60793dc717f09e6882e1e2f82798a996a8e053e1"`
[INFO] [stdout] 2cda8f9e331403b313e5db6d60793dc717f09e6882e1e2f82798a996a8e053e1