[INFO] updating cached repository tomvidm/rusty-cas [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tomvidm/rusty-cas [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tomvidm/rusty-cas" "work/ex/clippy-test-run/sources/stable/gh/tomvidm/rusty-cas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomvidm/rusty-cas'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tomvidm/rusty-cas" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomvidm/rusty-cas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomvidm/rusty-cas'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3e22427513d23384a02bb705850a9930e1a073d3 [INFO] sha for GitHub repo tomvidm/rusty-cas: 3e22427513d23384a02bb705850a9930e1a073d3 [INFO] validating manifest of tomvidm/rusty-cas on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomvidm/rusty-cas on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomvidm/rusty-cas [INFO] finished frobbing tomvidm/rusty-cas [INFO] frobbed toml for tomvidm/rusty-cas written to work/ex/clippy-test-run/sources/stable/gh/tomvidm/rusty-cas/Cargo.toml [INFO] started frobbing tomvidm/rusty-cas [INFO] finished frobbing tomvidm/rusty-cas [INFO] frobbed toml for tomvidm/rusty-cas written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomvidm/rusty-cas/Cargo.toml [INFO] crate tomvidm/rusty-cas has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomvidm/rusty-cas against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomvidm/rusty-cas:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d05ca03ebb888336316fa216bbc84cd9b8bacaafa7477fc172b11e5be59db5f0 [INFO] running `"docker" "start" "-a" "d05ca03ebb888336316fa216bbc84cd9b8bacaafa7477fc172b11e5be59db5f0"` [INFO] [stderr] Checking sym v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symexpr_rc.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symexpr_rc.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symexpr_rc.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symexpr_rc.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symexpr_rc.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symexpr_rc.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symexpr_rc.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/symexpr_rc.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | function: function, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `function` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | Expr::Numeric(numeric) => return numeric.is_unity(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `numeric.is_unity()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | Expr::Numeric(numeric) => return numeric.is_zero(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `numeric.is_zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:128:39 [INFO] [stderr] | [INFO] [stderr] 128 | Expr::Numeric(numeric) => return numeric.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `numeric.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | Expr::IndepVar(key) => return values[*key], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `values[*key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | Expr::Unary(expr) => return expr.eval(values), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.eval(values)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:131:35 [INFO] [stderr] | [INFO] [stderr] 131 | Expr::Binary(expr) => return expr.eval(values) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.eval(values)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:137:37 [INFO] [stderr] | [INFO] [stderr] 137 | Expr::IndepVar(_key) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | Expr::Unary(expr) => return expr.argument.depends_on_any_variable(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.argument.depends_on_any_variable()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | Expr::Binary(expr) => return expr.lhs.depends_on_any_variable() || [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 140 | | expr.rhs.depends_on_any_variable(), [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 139 | Expr::Binary(expr) => expr.lhs.depends_on_any_variable() || [INFO] [stderr] 140 | expr.rhs.depends_on_any_variable(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:147:41 [INFO] [stderr] | [INFO] [stderr] 147 | Expr::IndepVar(this_key) => return *this_key == key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*this_key == key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | Expr::Unary(expr) => return expr.argument.depends_on_variable(key), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.argument.depends_on_variable(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | Expr::Binary(expr) => return expr.lhs.depends_on_variable(key) || [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 150 | | expr.rhs.depends_on_variable(key), [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 149 | Expr::Binary(expr) => expr.lhs.depends_on_variable(key) || [INFO] [stderr] 150 | expr.rhs.depends_on_variable(key), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:162:40 [INFO] [stderr] | [INFO] [stderr] 162 | Some(binary_rc) => return binary_rc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `binary_rc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | None => return Rc::clone(expr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rc::clone(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | _ => return Rc::clone(expr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rc::clone(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:174:35 [INFO] [stderr] | [INFO] [stderr] 174 | UnaryFunction::Neg => return -self.argument.eval(values), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `-self.argument.eval(values)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:175:35 [INFO] [stderr] | [INFO] [stderr] 175 | UnaryFunction::Exp => return self.argument.eval(values).exp() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.argument.eval(values).exp()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:183:36 [INFO] [stderr] | [INFO] [stderr] 183 | BinaryFunction::Add => return self.lhs.eval(values) + [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 184 | | self.rhs.eval(values), [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 183 | BinaryFunction::Add => self.lhs.eval(values) + [INFO] [stderr] 184 | self.rhs.eval(values), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:185:36 [INFO] [stderr] | [INFO] [stderr] 185 | BinaryFunction::Mul => return self.lhs.eval(values) * [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 186 | | self.rhs.eval(values) [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 185 | BinaryFunction::Mul => self.lhs.eval(values) * [INFO] [stderr] 186 | self.rhs.eval(values) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | return Some(Rc::clone(&self.rhs)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&self.rhs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | return Some(Rc::clone(&self.lhs)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&self.lhs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | return Some(Rc::new(Expr::zero())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::new(Expr::zero()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | return Some(Rc::clone(&self.rhs)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&self.rhs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | return Some(Rc::clone(&self.lhs)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&self.lhs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:212:18 [INFO] [stderr] | [INFO] [stderr] 212 | _ => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | Some(expr) => return Some(expr.eval(&values)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(expr.eval(&values))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:34:27 [INFO] [stderr] | [INFO] [stderr] 34 | Some(expr) => return Some(expr.eval(&self.variable_list)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(expr.eval(&self.variable_list))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | return index [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | return new_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | return index [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | return new_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | return "ans".to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"ans".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | Numeric::Real(real) => return real, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `real` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | Numeric::Complex(complex) => return complex as RealType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `complex as RealType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:64:42 [INFO] [stderr] | [INFO] [stderr] 64 | Numeric::Integer(integer) => return integer as RealType [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `integer as RealType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | Numeric::Real(real) => return *real == 0., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*real == 0.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:71:42 [INFO] [stderr] | [INFO] [stderr] 71 | Numeric::Complex(complex) => return *complex == 0., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*complex == 0.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:72:42 [INFO] [stderr] | [INFO] [stderr] 72 | Numeric::Integer(integer) => return *integer == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*integer == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | Numeric::Real(real) => return *real == 1., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*real == 1.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | Numeric::Complex(complex) => return *complex == 1., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*complex == 1.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:80:42 [INFO] [stderr] | [INFO] [stderr] 80 | Numeric::Integer(integer) => return *integer == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*integer == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:86:36 [INFO] [stderr] | [INFO] [stderr] 86 | Numeric::Real(real) => return Numeric::from_real(real.powi(pow as i32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(real.powi(pow as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:87:42 [INFO] [stderr] | [INFO] [stderr] 87 | Numeric::Complex(complex) => return Numeric::from_complex(complex.powi(pow as i32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(complex.powi(pow as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:88:42 [INFO] [stderr] | [INFO] [stderr] 88 | Numeric::Integer(integer) => return Numeric::from_integer(integer.pow(pow as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(integer.pow(pow as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | Numeric::Real(real) => return Numeric::from_real(real.exp()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(real.exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:95:42 [INFO] [stderr] | [INFO] [stderr] 95 | Numeric::Complex(complex) => return Numeric::from_complex(complex.exp()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(complex.exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:96:42 [INFO] [stderr] | [INFO] [stderr] 96 | Numeric::Integer(integer) => return Numeric::from_real((*integer as RealType).exp()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real((*integer as RealType).exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | Numeric::Real(real) => return Numeric::from_real(-real), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(-real)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:107:42 [INFO] [stderr] | [INFO] [stderr] 107 | Numeric::Complex(complex) => return Numeric::from_complex(-complex), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(-complex)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:108:42 [INFO] [stderr] | [INFO] [stderr] 108 | Numeric::Integer(integer) => return Numeric::from_integer(-integer) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(-integer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | return Numeric::from_real(lhs_real + rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(lhs_real + rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | return Numeric::from_complex(lhs_complex + rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(lhs_complex + rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | return Numeric::from_integer(lhs_integer + rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(lhs_integer + rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | return Numeric::from_real(lhs_real - rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(lhs_real - rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | return Numeric::from_complex(lhs_complex - rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(lhs_complex - rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | return Numeric::from_integer(lhs_integer - rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(lhs_integer - rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | return Numeric::from_real(lhs_real * rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(lhs_real * rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | return Numeric::from_complex(lhs_complex * rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(lhs_complex * rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | return Numeric::from_integer(lhs_integer * rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(lhs_integer * rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | return Numeric::from_real(lhs_real / rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(lhs_real / rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | return Numeric::from_complex(lhs_complex / rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(lhs_complex / rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | return Numeric::from_integer(lhs_integer / rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(lhs_integer / rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/lexer.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::char` [INFO] [stderr] --> src/lexer.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::char; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | Token::Term(_term) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | Token::Operator(_op) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:53:52 [INFO] [stderr] | [INFO] [stderr] 53 | TermToken::Number(_numeric) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:65:53 [INFO] [stderr] | [INFO] [stderr] 65 | TermToken::VariableKey(_key) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return Operator(Add) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Operator(Add)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Term` [INFO] [stderr] --> src/lexer.rs:125:23 [INFO] [stderr] | [INFO] [stderr] 125 | use self::Token::{Term, Operator}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Number`, `VariableKey` [INFO] [stderr] --> src/lexer.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | use self::TermToken::{Number, VariableKey}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | return Token::Term(TermToken::Number(result)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Term(TermToken::Number(result))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | return tokens.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Number`, `VariableKey` [INFO] [stderr] --> src/lexer.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | use self::TermToken::{Number, VariableKey}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | return postfix; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `postfix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lexer.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | /// Push top operator to output [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return input [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | Expr::Numeric(numeric) => return numeric.is_unity(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `numeric.is_unity()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:77:18 [INFO] [stderr] | [INFO] [stderr] 77 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | Expr::Numeric(numeric) => return numeric.is_zero(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `numeric.is_zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:84:18 [INFO] [stderr] | [INFO] [stderr] 84 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:128:39 [INFO] [stderr] | [INFO] [stderr] 128 | Expr::Numeric(numeric) => return numeric.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `numeric.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | Expr::IndepVar(key) => return values[*key], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `values[*key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | Expr::Unary(expr) => return expr.eval(values), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.eval(values)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:131:35 [INFO] [stderr] | [INFO] [stderr] 131 | Expr::Binary(expr) => return expr.eval(values) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.eval(values)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:137:37 [INFO] [stderr] | [INFO] [stderr] 137 | Expr::IndepVar(_key) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:138:34 [INFO] [stderr] | [INFO] [stderr] 138 | Expr::Unary(expr) => return expr.argument.depends_on_any_variable(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.argument.depends_on_any_variable()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | Expr::Binary(expr) => return expr.lhs.depends_on_any_variable() || [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 140 | | expr.rhs.depends_on_any_variable(), [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 139 | Expr::Binary(expr) => expr.lhs.depends_on_any_variable() || [INFO] [stderr] 140 | expr.rhs.depends_on_any_variable(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:147:41 [INFO] [stderr] | [INFO] [stderr] 147 | Expr::IndepVar(this_key) => return *this_key == key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*this_key == key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:148:34 [INFO] [stderr] | [INFO] [stderr] 148 | Expr::Unary(expr) => return expr.argument.depends_on_variable(key), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `expr.argument.depends_on_variable(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | Expr::Binary(expr) => return expr.lhs.depends_on_variable(key) || [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 150 | | expr.rhs.depends_on_variable(key), [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 149 | Expr::Binary(expr) => expr.lhs.depends_on_variable(key) || [INFO] [stderr] 150 | expr.rhs.depends_on_variable(key), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:162:40 [INFO] [stderr] | [INFO] [stderr] 162 | Some(binary_rc) => return binary_rc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `binary_rc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | None => return Rc::clone(expr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rc::clone(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | _ => return Rc::clone(expr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rc::clone(expr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:174:35 [INFO] [stderr] | [INFO] [stderr] 174 | UnaryFunction::Neg => return -self.argument.eval(values), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `-self.argument.eval(values)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:175:35 [INFO] [stderr] | [INFO] [stderr] 175 | UnaryFunction::Exp => return self.argument.eval(values).exp() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.argument.eval(values).exp()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:183:36 [INFO] [stderr] | [INFO] [stderr] 183 | BinaryFunction::Add => return self.lhs.eval(values) + [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 184 | | self.rhs.eval(values), [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 183 | BinaryFunction::Add => self.lhs.eval(values) + [INFO] [stderr] 184 | self.rhs.eval(values), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:185:36 [INFO] [stderr] | [INFO] [stderr] 185 | BinaryFunction::Mul => return self.lhs.eval(values) * [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 186 | | self.rhs.eval(values) [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 185 | BinaryFunction::Mul => self.lhs.eval(values) * [INFO] [stderr] 186 | self.rhs.eval(values) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | return Some(Rc::clone(&self.rhs)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&self.rhs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | return Some(Rc::clone(&self.lhs)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&self.lhs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:203:21 [INFO] [stderr] | [INFO] [stderr] 203 | return Some(Rc::new(Expr::zero())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::new(Expr::zero()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | return Some(Rc::clone(&self.rhs)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&self.rhs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | return Some(Rc::clone(&self.lhs)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&self.lhs))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:209:21 [INFO] [stderr] | [INFO] [stderr] 209 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symexpr_rc.rs:212:18 [INFO] [stderr] | [INFO] [stderr] 212 | _ => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | Some(expr) => return Some(expr.eval(&values)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(expr.eval(&values))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:34:27 [INFO] [stderr] | [INFO] [stderr] 34 | Some(expr) => return Some(expr.eval(&self.variable_list)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(expr.eval(&self.variable_list))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | None => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | return index [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | return new_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | return index [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | return new_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/symengine.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | return "ans".to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"ans".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | Numeric::Real(real) => return real, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `real` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:63:42 [INFO] [stderr] | [INFO] [stderr] 63 | Numeric::Complex(complex) => return complex as RealType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `complex as RealType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:64:42 [INFO] [stderr] | [INFO] [stderr] 64 | Numeric::Integer(integer) => return integer as RealType [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `integer as RealType` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | Numeric::Real(real) => return *real == 0., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*real == 0.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:71:42 [INFO] [stderr] | [INFO] [stderr] 71 | Numeric::Complex(complex) => return *complex == 0., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*complex == 0.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:72:42 [INFO] [stderr] | [INFO] [stderr] 72 | Numeric::Integer(integer) => return *integer == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*integer == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | Numeric::Real(real) => return *real == 1., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*real == 1.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | Numeric::Complex(complex) => return *complex == 1., [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*complex == 1.` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:80:42 [INFO] [stderr] | [INFO] [stderr] 80 | Numeric::Integer(integer) => return *integer == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*integer == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:86:36 [INFO] [stderr] | [INFO] [stderr] 86 | Numeric::Real(real) => return Numeric::from_real(real.powi(pow as i32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(real.powi(pow as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:87:42 [INFO] [stderr] | [INFO] [stderr] 87 | Numeric::Complex(complex) => return Numeric::from_complex(complex.powi(pow as i32)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(complex.powi(pow as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:88:42 [INFO] [stderr] | [INFO] [stderr] 88 | Numeric::Integer(integer) => return Numeric::from_integer(integer.pow(pow as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(integer.pow(pow as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | Numeric::Real(real) => return Numeric::from_real(real.exp()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(real.exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:95:42 [INFO] [stderr] | [INFO] [stderr] 95 | Numeric::Complex(complex) => return Numeric::from_complex(complex.exp()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(complex.exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:96:42 [INFO] [stderr] | [INFO] [stderr] 96 | Numeric::Integer(integer) => return Numeric::from_real((*integer as RealType).exp()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real((*integer as RealType).exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | Numeric::Real(real) => return Numeric::from_real(-real), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(-real)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:107:42 [INFO] [stderr] | [INFO] [stderr] 107 | Numeric::Complex(complex) => return Numeric::from_complex(-complex), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(-complex)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:108:42 [INFO] [stderr] | [INFO] [stderr] 108 | Numeric::Integer(integer) => return Numeric::from_integer(-integer) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(-integer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | return Numeric::from_real(lhs_real + rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(lhs_real + rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | return Numeric::from_complex(lhs_complex + rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(lhs_complex + rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | return Numeric::from_integer(lhs_integer + rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(lhs_integer + rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | return Numeric::from_real(lhs_real - rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(lhs_real - rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | return Numeric::from_complex(lhs_complex - rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(lhs_complex - rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | return Numeric::from_integer(lhs_integer - rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(lhs_integer - rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | return Numeric::from_real(lhs_real * rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(lhs_real * rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:198:17 [INFO] [stderr] | [INFO] [stderr] 198 | return Numeric::from_complex(lhs_complex * rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(lhs_complex * rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | return Numeric::from_integer(lhs_integer * rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(lhs_integer * rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | return Numeric::from_real(lhs_real / rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_real(lhs_real / rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:231:17 [INFO] [stderr] | [INFO] [stderr] 231 | return Numeric::from_complex(lhs_complex / rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_complex(lhs_complex / rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/numeric.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | return Numeric::from_integer(lhs_integer / rhs) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Numeric::from_integer(lhs_integer / rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io` [INFO] [stderr] --> src/lexer.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::char` [INFO] [stderr] --> src/lexer.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::char; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | Token::Term(_term) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | Token::Operator(_op) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:53:52 [INFO] [stderr] | [INFO] [stderr] 53 | TermToken::Number(_numeric) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:65:53 [INFO] [stderr] | [INFO] [stderr] 65 | TermToken::VariableKey(_key) => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:66:26 [INFO] [stderr] | [INFO] [stderr] 66 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:69:18 [INFO] [stderr] | [INFO] [stderr] 69 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:76:18 [INFO] [stderr] | [INFO] [stderr] 76 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:90:18 [INFO] [stderr] | [INFO] [stderr] 90 | _ => return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return Operator(Add) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Operator(Add)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Term` [INFO] [stderr] --> src/lexer.rs:125:23 [INFO] [stderr] | [INFO] [stderr] 125 | use self::Token::{Term, Operator}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Number`, `VariableKey` [INFO] [stderr] --> src/lexer.rs:126:27 [INFO] [stderr] | [INFO] [stderr] 126 | use self::TermToken::{Number, VariableKey}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | return Token::Term(TermToken::Number(result)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Term(TermToken::Number(result))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | return tokens.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Number`, `VariableKey` [INFO] [stderr] --> src/lexer.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | use self::TermToken::{Number, VariableKey}; [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lexer.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | return postfix; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `postfix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/lexer.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | /// Push top operator to output [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Term` [INFO] [stderr] --> src/lexer.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | use self::Token::{Term, Operator}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Number` [INFO] [stderr] --> src/lexer.rs:279:27 [INFO] [stderr] | [INFO] [stderr] 279 | use self::TermToken::{Number, VariableKey}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Number` [INFO] [stderr] --> src/lexer.rs:299:27 [INFO] [stderr] | [INFO] [stderr] 299 | use self::TermToken::{Number, VariableKey}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Number` [INFO] [stderr] --> src/lexer.rs:377:27 [INFO] [stderr] | [INFO] [stderr] 377 | use self::TermToken::{Number, VariableKey}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cli.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return input [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/symexpr_rc.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | _ => return None [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ch` [INFO] [stderr] --> src/lexer.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | for ch in slice.chars() { [INFO] [stderr] | ^^ help: consider using `_ch` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lexer.rs:135:10 [INFO] [stderr] | [INFO] [stderr] 135 | for (i, token) in tokens.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `temp_number` [INFO] [stderr] --> src/lexer.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | let mut temp_number = Numeric::from_integer(0); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_temp_number` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lexer.rs:166:10 [INFO] [stderr] | [INFO] [stderr] 166 | for (i, ch) in string.chars().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lexer.rs:207:10 [INFO] [stderr] | [INFO] [stderr] 207 | for (i, token) in tokens.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `string` [INFO] [stderr] --> src/cli.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | fn parse_input(string: &String) { [INFO] [stderr] | ^^^^^^ help: consider using `_string` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | for (i, x) in b.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `postfixed_tokens` is never read [INFO] [stderr] --> src/symengine.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | let mut postfixed_tokens: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lexer.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | let mut temp_number = Numeric::from_integer(0); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/symexpr_rc.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | _ => return None [INFO] [stderr] | ^ [INFO] [stderr] warning: method is never used: `eval_expr_with` [INFO] [stderr] --> src/symengine.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | fn eval_expr_with(&self,key: &String, values: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_variable` [INFO] [stderr] --> src/symengine.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | fn get_variable(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `tokenize_number` [INFO] [stderr] --> src/lexer.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | fn tokenize_number(slice: &str) -> Token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `string_to_postfix` [INFO] [stderr] --> src/lexer.rs:261:1 [INFO] [stderr] | [INFO] [stderr] 261 | pub fn string_to_postfix(string: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_input` [INFO] [stderr] --> src/cli.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | fn parse_input(string: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ch` [INFO] [stderr] --> src/lexer.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | for ch in slice.chars() { [INFO] [stderr] | ^^ help: consider using `_ch` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lexer.rs:135:10 [INFO] [stderr] | [INFO] [stderr] 135 | for (i, token) in tokens.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `temp_number` [INFO] [stderr] --> src/lexer.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | let mut temp_number = Numeric::from_integer(0); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_temp_number` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lexer.rs:166:10 [INFO] [stderr] | [INFO] [stderr] 166 | for (i, ch) in string.chars().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symexpr_rc.rs:126:32 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn eval(&self, values: &Vec) -> Numeric { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Numeric]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/symexpr_rc.rs:128:46 [INFO] [stderr] | [INFO] [stderr] 128 | Expr::Numeric(numeric) => return numeric.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*numeric` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symexpr_rc.rs:172:28 [INFO] [stderr] | [INFO] [stderr] 172 | fn eval(&self, values: &Vec) -> Numeric { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Numeric]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symexpr_rc.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | fn eval(&self, values: &Vec) -> Numeric { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Numeric]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lexer.rs:207:10 [INFO] [stderr] | [INFO] [stderr] 207 | for (i, token) in tokens.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `string` [INFO] [stderr] --> src/cli.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | fn parse_input(string: &String) { [INFO] [stderr] | ^^^^^^ help: consider using `_string` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | for (i, x) in b.iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `values` [INFO] [stderr] --> src/symexpr_rc.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | let values: Vec = vec![ [INFO] [stderr] | ^^^^^^ help: consider using `_values` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/symengine.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | let key = String::from("x"); [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `postfixed_tokens` is never read [INFO] [stderr] --> src/symengine.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | let mut postfixed_tokens: Vec = Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | fn eval_expr_with(&self,key: &String, values: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symengine.rs:25:51 [INFO] [stderr] | [INFO] [stderr] 25 | fn eval_expr_with(&self,key: &String, values: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Numeric]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | fn eval_expr(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | fn get_variable(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | fn get_index_of_variable(&self, key: &String) -> Option<(usize)> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | fn assign_variable(&mut self, key: &String, val: Numeric) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:68:35 [INFO] [stderr] | [INFO] [stderr] 68 | fn get_expression(&self, key: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | fn get_index_of_expression(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | fn assign_expression(&mut self, key: &String, expr: &Rc) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:97:49 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn interpret(&mut self, expr_as_string: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:102:48 [INFO] [stderr] | [INFO] [stderr] 102 | fn parse_string(&mut self, expr_as_string: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/numeric.rs:78:43 [INFO] [stderr] | [INFO] [stderr] 78 | Numeric::Real(real) => return *real == 1., [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(*real - 1.).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/numeric.rs:78:43 [INFO] [stderr] | [INFO] [stderr] 78 | Numeric::Real(real) => return *real == 1., [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/numeric.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | Numeric::Complex(complex) => return *complex == 1., [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*complex - 1.).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/numeric.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | Numeric::Complex(complex) => return *complex == 1., [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: constant `LeftP` should have an upper case name such as `LEFT_P` [INFO] [stderr] --> src/lexer.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | const LeftP: Operator = Operator{precedence: 1, op: OperatorType::LeftP}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant `RightP` should have an upper case name such as `RIGHT_P` [INFO] [stderr] --> src/lexer.rs:102:1 [INFO] [stderr] | [INFO] [stderr] 102 | const RightP: Operator = Operator{precedence: 1, op: OperatorType::RightP}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `Add` should have an upper case name such as `ADD` [INFO] [stderr] --> src/lexer.rs:103:1 [INFO] [stderr] | [INFO] [stderr] 103 | const Add: Operator = Operator{precedence: 2, op: OperatorType::Add}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `Mul` should have an upper case name such as `MUL` [INFO] [stderr] --> src/lexer.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | const Mul: Operator = Operator{precedence: 4, op: OperatorType::Mul}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `Assignment` should have an upper case name such as `ASSIGNMENT` [INFO] [stderr] --> src/lexer.rs:105:1 [INFO] [stderr] | [INFO] [stderr] 105 | const Assignment: Operator = Operator{precedence: 4, op: OperatorType::Assignment}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:159:32 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn tokenize_string(string: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:174:83 [INFO] [stderr] | [INFO] [stderr] 174 | '0'...'9' => tokens.push(Term(TermToken::Number(Numeric::from_integer(ch.to_digit(10).unwrap() as IntegerType)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(ch.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lexer.rs:203:33 [INFO] [stderr] | [INFO] [stderr] 203 | pub fn infix_to_postfix(tokens: &Tokens) -> Tokens { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:261:34 [INFO] [stderr] | [INFO] [stderr] 261 | pub fn string_to_postfix(string: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cli.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | fn parse_input(string: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/cli.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/cli.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sym`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lexer.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | let mut temp_number = Numeric::from_integer(0); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `tokenize_number` [INFO] [stderr] --> src/lexer.rs:124:1 [INFO] [stderr] | [INFO] [stderr] 124 | fn tokenize_number(slice: &str) -> Token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `string_to_postfix` [INFO] [stderr] --> src/lexer.rs:261:1 [INFO] [stderr] | [INFO] [stderr] 261 | pub fn string_to_postfix(string: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_input` [INFO] [stderr] --> src/cli.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | fn parse_input(string: &String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symexpr_rc.rs:126:32 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn eval(&self, values: &Vec) -> Numeric { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Numeric]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/symexpr_rc.rs:128:46 [INFO] [stderr] | [INFO] [stderr] 128 | Expr::Numeric(numeric) => return numeric.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*numeric` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symexpr_rc.rs:172:28 [INFO] [stderr] | [INFO] [stderr] 172 | fn eval(&self, values: &Vec) -> Numeric { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Numeric]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symexpr_rc.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | fn eval(&self, values: &Vec) -> Numeric { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Numeric]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:25:34 [INFO] [stderr] | [INFO] [stderr] 25 | fn eval_expr_with(&self,key: &String, values: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/symengine.rs:25:51 [INFO] [stderr] | [INFO] [stderr] 25 | fn eval_expr_with(&self,key: &String, values: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Numeric]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | fn eval_expr(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | fn get_variable(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:46:42 [INFO] [stderr] | [INFO] [stderr] 46 | fn get_index_of_variable(&self, key: &String) -> Option<(usize)> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:53:40 [INFO] [stderr] | [INFO] [stderr] 53 | fn assign_variable(&mut self, key: &String, val: Numeric) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:68:35 [INFO] [stderr] | [INFO] [stderr] 68 | fn get_expression(&self, key: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | fn get_index_of_expression(&self, key: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | fn assign_expression(&mut self, key: &String, expr: &Rc) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:97:49 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn interpret(&mut self, expr_as_string: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symengine.rs:102:48 [INFO] [stderr] | [INFO] [stderr] 102 | fn parse_string(&mut self, expr_as_string: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/numeric.rs:78:43 [INFO] [stderr] | [INFO] [stderr] 78 | Numeric::Real(real) => return *real == 1., [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(*real - 1.).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/numeric.rs:78:43 [INFO] [stderr] | [INFO] [stderr] 78 | Numeric::Real(real) => return *real == 1., [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/numeric.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | Numeric::Complex(complex) => return *complex == 1., [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*complex - 1.).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/numeric.rs:79:49 [INFO] [stderr] | [INFO] [stderr] 79 | Numeric::Complex(complex) => return *complex == 1., [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: constant `LeftP` should have an upper case name such as `LEFT_P` [INFO] [stderr] --> src/lexer.rs:101:1 [INFO] [stderr] | [INFO] [stderr] 101 | const LeftP: Operator = Operator{precedence: 1, op: OperatorType::LeftP}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `RightP` should have an upper case name such as `RIGHT_P` [INFO] [stderr] --> src/lexer.rs:102:1 [INFO] [stderr] | [INFO] [stderr] 102 | const RightP: Operator = Operator{precedence: 1, op: OperatorType::RightP}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `Add` should have an upper case name such as `ADD` [INFO] [stderr] --> src/lexer.rs:103:1 [INFO] [stderr] | [INFO] [stderr] 103 | const Add: Operator = Operator{precedence: 2, op: OperatorType::Add}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `Mul` should have an upper case name such as `MUL` [INFO] [stderr] --> src/lexer.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | const Mul: Operator = Operator{precedence: 4, op: OperatorType::Mul}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `Assignment` should have an upper case name such as `ASSIGNMENT` [INFO] [stderr] --> src/lexer.rs:105:1 [INFO] [stderr] | [INFO] [stderr] 105 | const Assignment: Operator = Operator{precedence: 4, op: OperatorType::Assignment}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:159:32 [INFO] [stderr] | [INFO] [stderr] 159 | pub fn tokenize_string(string: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lexer.rs:174:83 [INFO] [stderr] | [INFO] [stderr] 174 | '0'...'9' => tokens.push(Term(TermToken::Number(Numeric::from_integer(ch.to_digit(10).unwrap() as IntegerType)))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(ch.to_digit(10).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lexer.rs:203:33 [INFO] [stderr] | [INFO] [stderr] 203 | pub fn infix_to_postfix(tokens: &Tokens) -> Tokens { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:261:34 [INFO] [stderr] | [INFO] [stderr] 261 | pub fn string_to_postfix(string: &String) -> Tokens { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cli.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | fn parse_input(string: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/cli.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | io::stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/cli.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | io::stdin().read_line(&mut input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sym`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d05ca03ebb888336316fa216bbc84cd9b8bacaafa7477fc172b11e5be59db5f0"` [INFO] running `"docker" "rm" "-f" "d05ca03ebb888336316fa216bbc84cd9b8bacaafa7477fc172b11e5be59db5f0"` [INFO] [stdout] d05ca03ebb888336316fa216bbc84cd9b8bacaafa7477fc172b11e5be59db5f0