[INFO] updating cached repository tomonari-t/hello-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tomonari-t/hello-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tomonari-t/hello-rust" "work/ex/clippy-test-run/sources/stable/gh/tomonari-t/hello-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomonari-t/hello-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tomonari-t/hello-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomonari-t/hello-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomonari-t/hello-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 376f4b24717ebece9c7e1400e0fb5604b7fca5df [INFO] sha for GitHub repo tomonari-t/hello-rust: 376f4b24717ebece9c7e1400e0fb5604b7fca5df [INFO] validating manifest of tomonari-t/hello-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomonari-t/hello-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomonari-t/hello-rust [INFO] finished frobbing tomonari-t/hello-rust [INFO] frobbed toml for tomonari-t/hello-rust written to work/ex/clippy-test-run/sources/stable/gh/tomonari-t/hello-rust/Cargo.toml [INFO] started frobbing tomonari-t/hello-rust [INFO] finished frobbing tomonari-t/hello-rust [INFO] frobbed toml for tomonari-t/hello-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomonari-t/hello-rust/Cargo.toml [INFO] crate tomonari-t/hello-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomonari-t/hello-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomonari-t/hello-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 65f549a128d814c6611877e601cf3c322f5d7d64640c58be85cef6d5920b42ab [INFO] running `"docker" "start" "-a" "65f549a128d814c6611877e601cf3c322f5d7d64640c58be85cef6d5920b42ab"` [INFO] [stderr] Checking hello-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | total [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | let total = n + m; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | total [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | let total = n + m; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "65f549a128d814c6611877e601cf3c322f5d7d64640c58be85cef6d5920b42ab"` [INFO] running `"docker" "rm" "-f" "65f549a128d814c6611877e601cf3c322f5d7d64640c58be85cef6d5920b42ab"` [INFO] [stdout] 65f549a128d814c6611877e601cf3c322f5d7d64640c58be85cef6d5920b42ab