[INFO] updating cached repository tomddolezal/dir.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tomddolezal/dir.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tomddolezal/dir.rs" "work/ex/clippy-test-run/sources/stable/gh/tomddolezal/dir.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomddolezal/dir.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tomddolezal/dir.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomddolezal/dir.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomddolezal/dir.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 94b32c5dc59c6dcf712f5ebc7d23d742711a5ff7 [INFO] sha for GitHub repo tomddolezal/dir.rs: 94b32c5dc59c6dcf712f5ebc7d23d742711a5ff7 [INFO] validating manifest of tomddolezal/dir.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomddolezal/dir.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomddolezal/dir.rs [INFO] finished frobbing tomddolezal/dir.rs [INFO] frobbed toml for tomddolezal/dir.rs written to work/ex/clippy-test-run/sources/stable/gh/tomddolezal/dir.rs/Cargo.toml [INFO] started frobbing tomddolezal/dir.rs [INFO] finished frobbing tomddolezal/dir.rs [INFO] frobbed toml for tomddolezal/dir.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomddolezal/dir.rs/Cargo.toml [INFO] crate tomddolezal/dir.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomddolezal/dir.rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomddolezal/dir.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8bb724b4f82d6acb37495666e2fdbf097080b89cd371d5496bbc4dcb72d5ef0 [INFO] running `"docker" "start" "-a" "d8bb724b4f82d6acb37495666e2fdbf097080b89cd371d5496bbc4dcb72d5ef0"` [INFO] [stderr] Checking dir v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / let mut dir = env::current_dir(); [INFO] [stderr] 8 | | [INFO] [stderr] 9 | | if args.len() > 1 { [INFO] [stderr] 10 | | dir = fs::canonicalize(PathBuf::from(&args[1])); [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let dir = if args.len() > 1 { fs::canonicalize(PathBuf::from(&args[1])) } else { env::current_dir() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / let mut dir = env::current_dir(); [INFO] [stderr] 8 | | [INFO] [stderr] 9 | | if args.len() > 1 { [INFO] [stderr] 10 | | dir = fs::canonicalize(PathBuf::from(&args[1])); [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let dir = if args.len() > 1 { fs::canonicalize(PathBuf::from(&args[1])) } else { env::current_dir() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "d8bb724b4f82d6acb37495666e2fdbf097080b89cd371d5496bbc4dcb72d5ef0"` [INFO] running `"docker" "rm" "-f" "d8bb724b4f82d6acb37495666e2fdbf097080b89cd371d5496bbc4dcb72d5ef0"` [INFO] [stdout] d8bb724b4f82d6acb37495666e2fdbf097080b89cd371d5496bbc4dcb72d5ef0