[INFO] updating cached repository tombruijn/backup-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tombruijn/backup-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tombruijn/backup-rust" "work/ex/clippy-test-run/sources/stable/gh/tombruijn/backup-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tombruijn/backup-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tombruijn/backup-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tombruijn/backup-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tombruijn/backup-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 29cd685a96cebc514aaae6651ea2797a05a40ff0 [INFO] sha for GitHub repo tombruijn/backup-rust: 29cd685a96cebc514aaae6651ea2797a05a40ff0 [INFO] validating manifest of tombruijn/backup-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tombruijn/backup-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tombruijn/backup-rust [INFO] finished frobbing tombruijn/backup-rust [INFO] frobbed toml for tombruijn/backup-rust written to work/ex/clippy-test-run/sources/stable/gh/tombruijn/backup-rust/Cargo.toml [INFO] started frobbing tombruijn/backup-rust [INFO] finished frobbing tombruijn/backup-rust [INFO] frobbed toml for tombruijn/backup-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tombruijn/backup-rust/Cargo.toml [INFO] crate tombruijn/backup-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tombruijn/backup-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tombruijn/backup-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a50c15b071ad312414c54acf1f7ff7fda286009f070ed3a427363d2178ae8967 [INFO] running `"docker" "start" "-a" "a50c15b071ad312414c54acf1f7ff7fda286009f070ed3a427363d2178ae8967"` [INFO] [stderr] Checking backup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / return match command.spawn() { [INFO] [stderr] 21 | | Err(why) => panic!("couldn't spawn tar: {}", why.description()), [INFO] [stderr] 22 | | Ok(process) => process, [INFO] [stderr] 23 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | match command.spawn() { [INFO] [stderr] 21 | Err(why) => panic!("couldn't spawn tar: {}", why.description()), [INFO] [stderr] 22 | Ok(process) => process, [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / return match command.spawn() { [INFO] [stderr] 31 | | Err(why) => panic!("couldn't spawn gzip: {}", why.description()), [INFO] [stderr] 32 | | Ok(process) => process, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | match command.spawn() { [INFO] [stderr] 31 | Err(why) => panic!("couldn't spawn gzip: {}", why.description()), [INFO] [stderr] 32 | Ok(process) => process, [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(size) => return size, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / return match command.spawn() { [INFO] [stderr] 21 | | Err(why) => panic!("couldn't spawn tar: {}", why.description()), [INFO] [stderr] 22 | | Ok(process) => process, [INFO] [stderr] 23 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | match command.spawn() { [INFO] [stderr] 21 | Err(why) => panic!("couldn't spawn tar: {}", why.description()), [INFO] [stderr] 22 | Ok(process) => process, [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / return match command.spawn() { [INFO] [stderr] 31 | | Err(why) => panic!("couldn't spawn gzip: {}", why.description()), [INFO] [stderr] 32 | | Ok(process) => process, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | match command.spawn() { [INFO] [stderr] 31 | Err(why) => panic!("couldn't spawn gzip: {}", why.description()), [INFO] [stderr] 32 | Ok(process) => process, [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(size) => return size, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "a50c15b071ad312414c54acf1f7ff7fda286009f070ed3a427363d2178ae8967"` [INFO] running `"docker" "rm" "-f" "a50c15b071ad312414c54acf1f7ff7fda286009f070ed3a427363d2178ae8967"` [INFO] [stdout] a50c15b071ad312414c54acf1f7ff7fda286009f070ed3a427363d2178ae8967