[INFO] updating cached repository tomasz-pankowski/rust-class-ps1 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tomasz-pankowski/rust-class-ps1 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tomasz-pankowski/rust-class-ps1" "work/ex/clippy-test-run/sources/stable/gh/tomasz-pankowski/rust-class-ps1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tomasz-pankowski/rust-class-ps1'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tomasz-pankowski/rust-class-ps1" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomasz-pankowski/rust-class-ps1"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomasz-pankowski/rust-class-ps1'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f97feee69ac50a6c831ca73fe4211eebb8e89f69 [INFO] sha for GitHub repo tomasz-pankowski/rust-class-ps1: f97feee69ac50a6c831ca73fe4211eebb8e89f69 [INFO] validating manifest of tomasz-pankowski/rust-class-ps1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tomasz-pankowski/rust-class-ps1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tomasz-pankowski/rust-class-ps1 [INFO] finished frobbing tomasz-pankowski/rust-class-ps1 [INFO] frobbed toml for tomasz-pankowski/rust-class-ps1 written to work/ex/clippy-test-run/sources/stable/gh/tomasz-pankowski/rust-class-ps1/Cargo.toml [INFO] started frobbing tomasz-pankowski/rust-class-ps1 [INFO] finished frobbing tomasz-pankowski/rust-class-ps1 [INFO] frobbed toml for tomasz-pankowski/rust-class-ps1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomasz-pankowski/rust-class-ps1/Cargo.toml [INFO] crate tomasz-pankowski/rust-class-ps1 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tomasz-pankowski/rust-class-ps1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tomasz-pankowski/rust-class-ps1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8b6ee8e218ed9c0d3731c7470f8378e216773ba1c06819c60cab003cd5dfd1f [INFO] running `"docker" "start" "-a" "e8b6ee8e218ed9c0d3731c7470f8378e216773ba1c06819c60cab003cd5dfd1f"` [INFO] [stderr] Checking ps1 v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:109:2 [INFO] [stderr] | [INFO] [stderr] 109 | request [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | let request = HttpRequest{path: Path::new(path)};//html/stronka.html [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/main.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | Err(why) => panic!("couldn't open"), [INFO] [stderr] | ^^^ help: consider using `_why` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | Err(why) => panic!("couldn't read "), [INFO] [stderr] | ^^^ help: consider using `_why` instead [INFO] [stderr] [INFO] [stderr] warning: variable `response_default` is assigned to, but never used [INFO] [stderr] --> src/main.rs:72:10 [INFO] [stderr] | [INFO] [stderr] 72 | let response_default; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_response_default` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `response_default` is never read [INFO] [stderr] --> src/main.rs:74:7 [INFO] [stderr] | [INFO] [stderr] 74 | response_default =format!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:109:2 [INFO] [stderr] | [INFO] [stderr] 109 | request [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:108:16 [INFO] [stderr] | [INFO] [stderr] 108 | let request = HttpRequest{path: Path::new(path)};//html/stronka.html [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: static variable `counter` should have an upper case name such as `COUNTER` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | static mut counter: i32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | stream.read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:87:6 [INFO] [stderr] | [INFO] [stderr] 87 | stream.write(page_content.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ps1`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/main.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | Err(why) => panic!("couldn't open"), [INFO] [stderr] | ^^^ help: consider using `_why` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `why` [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | Err(why) => panic!("couldn't read "), [INFO] [stderr] | ^^^ help: consider using `_why` instead [INFO] [stderr] [INFO] [stderr] warning: variable `response_default` is assigned to, but never used [INFO] [stderr] --> src/main.rs:72:10 [INFO] [stderr] | [INFO] [stderr] 72 | let response_default; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: consider using `_response_default` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `response_default` is never read [INFO] [stderr] --> src/main.rs:74:7 [INFO] [stderr] | [INFO] [stderr] 74 | response_default =format!( [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: static variable `counter` should have an upper case name such as `COUNTER` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | static mut counter: i32 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | stream.read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:87:6 [INFO] [stderr] | [INFO] [stderr] 87 | stream.write(page_content.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ps1`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e8b6ee8e218ed9c0d3731c7470f8378e216773ba1c06819c60cab003cd5dfd1f"` [INFO] running `"docker" "rm" "-f" "e8b6ee8e218ed9c0d3731c7470f8378e216773ba1c06819c60cab003cd5dfd1f"` [INFO] [stdout] e8b6ee8e218ed9c0d3731c7470f8378e216773ba1c06819c60cab003cd5dfd1f