[INFO] updating cached repository tobyjsullivan/rs-string-n-thread [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tobyjsullivan/rs-string-n-thread [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tobyjsullivan/rs-string-n-thread" "work/ex/clippy-test-run/sources/stable/gh/tobyjsullivan/rs-string-n-thread"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tobyjsullivan/rs-string-n-thread'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tobyjsullivan/rs-string-n-thread" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tobyjsullivan/rs-string-n-thread"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tobyjsullivan/rs-string-n-thread'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b0c986edfa55fba490e42e6f513d646dd226bff0 [INFO] sha for GitHub repo tobyjsullivan/rs-string-n-thread: b0c986edfa55fba490e42e6f513d646dd226bff0 [INFO] validating manifest of tobyjsullivan/rs-string-n-thread on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tobyjsullivan/rs-string-n-thread on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tobyjsullivan/rs-string-n-thread [INFO] finished frobbing tobyjsullivan/rs-string-n-thread [INFO] frobbed toml for tobyjsullivan/rs-string-n-thread written to work/ex/clippy-test-run/sources/stable/gh/tobyjsullivan/rs-string-n-thread/Cargo.toml [INFO] started frobbing tobyjsullivan/rs-string-n-thread [INFO] finished frobbing tobyjsullivan/rs-string-n-thread [INFO] frobbed toml for tobyjsullivan/rs-string-n-thread written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tobyjsullivan/rs-string-n-thread/Cargo.toml [INFO] crate tobyjsullivan/rs-string-n-thread has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tobyjsullivan/rs-string-n-thread against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tobyjsullivan/rs-string-n-thread:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9ec7333da4c0b8ee47d3cffa90ef4c7e24d633a4c56913c345847a6a61feff8f [INFO] running `"docker" "start" "-a" "9ec7333da4c0b8ee47d3cffa90ef4c7e24d633a4c56913c345847a6a61feff8f"` [INFO] [stderr] Checking ex1 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | fn three(s: &String) -> String { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 46 | fn three(s: &str) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `s.clone()` to [INFO] [stderr] | [INFO] [stderr] 47 | let mut out = s.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | fn three(s: &String) -> String { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 46 | fn three(s: &str) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `s.clone()` to [INFO] [stderr] | [INFO] [stderr] 47 | let mut out = s.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "9ec7333da4c0b8ee47d3cffa90ef4c7e24d633a4c56913c345847a6a61feff8f"` [INFO] running `"docker" "rm" "-f" "9ec7333da4c0b8ee47d3cffa90ef4c7e24d633a4c56913c345847a6a61feff8f"` [INFO] [stdout] 9ec7333da4c0b8ee47d3cffa90ef4c7e24d633a4c56913c345847a6a61feff8f