[INFO] updating cached repository tmstieff/react-redux-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tmstieff/react-redux-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tmstieff/react-redux-cli" "work/ex/clippy-test-run/sources/stable/gh/tmstieff/react-redux-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tmstieff/react-redux-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tmstieff/react-redux-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmstieff/react-redux-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmstieff/react-redux-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 155d48aa680267343c576309b2df6ef0a80d52d1 [INFO] sha for GitHub repo tmstieff/react-redux-cli: 155d48aa680267343c576309b2df6ef0a80d52d1 [INFO] validating manifest of tmstieff/react-redux-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tmstieff/react-redux-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tmstieff/react-redux-cli [INFO] finished frobbing tmstieff/react-redux-cli [INFO] frobbed toml for tmstieff/react-redux-cli written to work/ex/clippy-test-run/sources/stable/gh/tmstieff/react-redux-cli/Cargo.toml [INFO] started frobbing tmstieff/react-redux-cli [INFO] finished frobbing tmstieff/react-redux-cli [INFO] frobbed toml for tmstieff/react-redux-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmstieff/react-redux-cli/Cargo.toml [INFO] crate tmstieff/react-redux-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tmstieff/react-redux-cli against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tmstieff/react-redux-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15151eaaaf27b99e0aa9c61e3f88d000edf04a35c68df540123bbc5974daaeec [INFO] running `"docker" "start" "-a" "15151eaaaf27b99e0aa9c61e3f88d000edf04a35c68df540123bbc5974daaeec"` [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking argparse v0.2.1 [INFO] [stderr] Checking react-redux-cli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ctrl/generator.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok("All good".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("All good".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ctrl/generator.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return result.files; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ctrl/search.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / return TemplateSearchResult { [INFO] [stderr] 56 | | files, [INFO] [stderr] 57 | | selected_template_dir, [INFO] [stderr] 58 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 55 | TemplateSearchResult { [INFO] [stderr] 56 | files, [INFO] [stderr] 57 | selected_template_dir, [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/ctrl/generator.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/ctrl/generator.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | let home_dir = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `write_file` [INFO] [stderr] --> src/ctrl/generator.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn write_file(dir: &Path, file_name: String, content: &String, show_confirmation: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ctrl/generator.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / let mut current_dir = match current_dir_buf.into_os_string().into_string() { [INFO] [stderr] 37 | | Ok(dir) => dir, [INFO] [stderr] 38 | | Err(e) => panic!("Could not find the current working directory, {:?}", e) [INFO] [stderr] 39 | | }; [INFO] [stderr] ... | [INFO] [stderr] 42 | | current_dir = dir; [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 36 | let current_dir = if !dir.eq("") { dir } else { match current_dir_buf.into_os_string().into_string() { [INFO] [stderr] 37 | Ok(dir) => dir, [INFO] [stderr] 38 | Err(e) => panic!("Could not find the current working directory, {:?}", e) [INFO] [stderr] 39 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ctrl/generator.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if template_files.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `template_files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ctrl/generator.rs:92:59 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn write_file(dir: &Path, file_name: String, content: &String, show_confirmation: bool) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ctrl/search.rs:14:55 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn find_templates(template: String, search_paths: &Vec, verbose: bool) -> TemplateSearchResult { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ctrl/generator.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok("All good".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("All good".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ctrl/generator.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return result.files; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ctrl/search.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / return TemplateSearchResult { [INFO] [stderr] 56 | | files, [INFO] [stderr] 57 | | selected_template_dir, [INFO] [stderr] 58 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 55 | TemplateSearchResult { [INFO] [stderr] 56 | files, [INFO] [stderr] 57 | selected_template_dir, [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ctrl/search.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | path = path + "/**/*.tpl"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path += "/**/*.tpl"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | writeln!(io::stderr(), "{}", e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/ctrl/generator.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/ctrl/generator.rs:45:30 [INFO] [stderr] | [INFO] [stderr] 45 | let home_dir = match home_dir() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ctrl/generator.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / let mut current_dir = match current_dir_buf.into_os_string().into_string() { [INFO] [stderr] 37 | | Ok(dir) => dir, [INFO] [stderr] 38 | | Err(e) => panic!("Could not find the current working directory, {:?}", e) [INFO] [stderr] 39 | | }; [INFO] [stderr] ... | [INFO] [stderr] 42 | | current_dir = dir; [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 36 | let current_dir = if !dir.eq("") { dir } else { match current_dir_buf.into_os_string().into_string() { [INFO] [stderr] 37 | Ok(dir) => dir, [INFO] [stderr] 38 | Err(e) => panic!("Could not find the current working directory, {:?}", e) [INFO] [stderr] 39 | } }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ctrl/generator.rs:76:12 [INFO] [stderr] | [INFO] [stderr] 76 | if template_files.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `template_files.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/ctrl/generator.rs:92:59 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn write_file(dir: &Path, file_name: String, content: &String, show_confirmation: bool) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ctrl/search.rs:14:55 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn find_templates(template: String, search_paths: &Vec, verbose: bool) -> TemplateSearchResult { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ctrl/search.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | path = path + "/**/*.tpl"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path += "/**/*.tpl"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | writeln!(io::stderr(), "{}", e).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "15151eaaaf27b99e0aa9c61e3f88d000edf04a35c68df540123bbc5974daaeec"` [INFO] running `"docker" "rm" "-f" "15151eaaaf27b99e0aa9c61e3f88d000edf04a35c68df540123bbc5974daaeec"` [INFO] [stdout] 15151eaaaf27b99e0aa9c61e3f88d000edf04a35c68df540123bbc5974daaeec