[INFO] updating cached repository tkyk0317/Algorithm_Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tkyk0317/Algorithm_Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tkyk0317/Algorithm_Rust" "work/ex/clippy-test-run/sources/stable/gh/tkyk0317/Algorithm_Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tkyk0317/Algorithm_Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tkyk0317/Algorithm_Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tkyk0317/Algorithm_Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tkyk0317/Algorithm_Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 25a3f4436d899e1fe1dd93de8968e79664edb743 [INFO] sha for GitHub repo tkyk0317/Algorithm_Rust: 25a3f4436d899e1fe1dd93de8968e79664edb743 [INFO] validating manifest of tkyk0317/Algorithm_Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tkyk0317/Algorithm_Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tkyk0317/Algorithm_Rust [INFO] finished frobbing tkyk0317/Algorithm_Rust [INFO] frobbed toml for tkyk0317/Algorithm_Rust written to work/ex/clippy-test-run/sources/stable/gh/tkyk0317/Algorithm_Rust/Cargo.toml [INFO] started frobbing tkyk0317/Algorithm_Rust [INFO] finished frobbing tkyk0317/Algorithm_Rust [INFO] frobbed toml for tkyk0317/Algorithm_Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tkyk0317/Algorithm_Rust/Cargo.toml [INFO] crate tkyk0317/Algorithm_Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tkyk0317/Algorithm_Rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tkyk0317/Algorithm_Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 26711169e6c3a4cdfa13ef8c0f59bffba84b8a03b753b76c1165c8fb38814aef [INFO] running `"docker" "start" "-a" "26711169e6c3a4cdfa13ef8c0f59bffba84b8a03b753b76c1165c8fb38814aef"` [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking algorithm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sort/merge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / if end - start == 2 { [INFO] [stderr] 17 | | if result[start + 1] < result[start] { [INFO] [stderr] 18 | | result.swap(start, start + 1); [INFO] [stderr] 19 | | return; [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | if end - start == 2 && result[start + 1] < result[start] { [INFO] [stderr] 17 | result.swap(start, start + 1); [INFO] [stderr] 18 | return; [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | if count > 1000000 { break; } [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/sort/merge.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / if end - start == 2 { [INFO] [stderr] 17 | | if result[start + 1] < result[start] { [INFO] [stderr] 18 | | result.swap(start, start + 1); [INFO] [stderr] 19 | | return; [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 16 | if end - start == 2 && result[start + 1] < result[start] { [INFO] [stderr] 17 | result.swap(start, start + 1); [INFO] [stderr] 18 | return; [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | if count > 1000000 { break; } [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sort/quick.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | for i in (left + 1)..(right + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((left + 1)..=right)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | count = count + 5000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count += 5000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sort/quick.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | for i in (left + 1)..(right + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((left + 1)..=right)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | count = count + 5000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count += 5000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.73s [INFO] running `"docker" "inspect" "26711169e6c3a4cdfa13ef8c0f59bffba84b8a03b753b76c1165c8fb38814aef"` [INFO] running `"docker" "rm" "-f" "26711169e6c3a4cdfa13ef8c0f59bffba84b8a03b753b76c1165c8fb38814aef"` [INFO] [stdout] 26711169e6c3a4cdfa13ef8c0f59bffba84b8a03b753b76c1165c8fb38814aef